From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1348 invoked from network); 13 Oct 2021 20:03:39 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 13 Oct 2021 20:03:39 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1634155419; b=cuXuxFoEKmFvInl6zYRbYXhlfS1RnTm4g0wRMTglZGzBLEwZ5lffwPMupvDkYfFQy6hfrEGMij VyZMx1F9iJgmt20pRe2PP7nwsnq5W/g1CBikb7qqJ5xNjTCZr1OZ2VGVD9oF6tIbjy7jyJt4Xq WFpiIEc3vthjzUVJ2sA7xl7mVzIQ2OEADGhVfC6S3lVCRrm6diGk0vjgOqludiJjzcHr/IHxxP Nx86bhD1fSfJK07mrwRv2EkDUZvxpNIUDkEcxu4yExkfvN86//jNXZBI9x7egR67pnBQjda8n9 YyePvqvQZuewQ2CRrDDPhZ6nNELFLz/nQ2LDG5DGlALQKQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f173.google.com) smtp.remote-ip=209.85.219.173; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1634155419; bh=pFijc4GfWfgd2y1P0Mt9p0VuwqEmg3RB2AnxTqscsPY=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Yz6tskpKniESo1ci3xRxf54wsMt8rbdCt4RgsY9WctLUk2TuSsgzKFfmncpSgeDXvuB8TaUzOE 9vDgc+SJVNYjQJk+zBKCXl/j9NtffOTvdcblRTbnz6do3MuebaG7ax9NjcA4AFL1FgByFAUFmg fuTWI/+SQsY3VMbOlJRtXSXfrBGAyUqicc02kP9DBatsbCMsa+ln8c0RmsXcxx7FFtPzUA1+mH z9mLjkPtJejeRXxj1iF8We7nDvE70lQp9zj40IaE+w6RQhV4lE9MWP/uKjbV+SS+9C54DqqRxI kIq26qzjK7sik+FLLB7Jfkwl4toSkfBpqVca+pD+clcOQQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=W99bhPH/GvvWIYdk4muDmxRVHsWKf796RbI0pVNnwkM=; b=P4rqFeTCjk3Aa1UOF4lGPBVrzb wWagGtCAnpjnpSMP6CIonDq0dIC9bhnNlP0vRtjRP5gY5v5lsNtp1foZh93/qhib4lOaVKjB4dKOh 1kzbWrHl/7G28KJ60i/PlZdWI9MiIwuL4aPRxjXasrI7RhTFzYGi4KDwUC6PyJytYeI9p7q27CEvo xwq3lv7084wdqmsxu6DdSAXqI82leNQyWgCjLl9l00joSUZoWaKFXu6N5CuKatOBoIoXzjqUpeE+U q/kukQPK0MW4eJIVipodSd3bqGKCgWVZazzdssRU8Em2ZibewLb7CpPEnAzHO32bgSZIhrM7pwHQ1 F8g40d8w==; Received: from authenticated user by zero.zsh.org with local id 1makTT-0000k6-3W; Wed, 13 Oct 2021 20:03:39 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f173.google.com) smtp.remote-ip=209.85.219.173; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f173.google.com ([209.85.219.173]:41606) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1makSh-0000PH-PP; Wed, 13 Oct 2021 20:02:52 +0000 Received: by mail-yb1-f173.google.com with SMTP id s4so9221286ybs.8 for ; Wed, 13 Oct 2021 13:02:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W99bhPH/GvvWIYdk4muDmxRVHsWKf796RbI0pVNnwkM=; b=66G/3bUl4hppZElhv1kzds8QVv3XVuS2fTgHGWzNR0nOUGpAxnPzPM7Wia26G24bYo 1xGzs5/l7u6TzqKqQrRbRLbYQOBbFacebGL0sKK9e418uYgPhAlGt57yAU7G5nvzoDOi hgKbsOYrZTRJmAy/pF144jru0DFBKdMmHvToW/9eAynM59685tEngW9EbBF94QtMywrT ABtjKKZ2CyVwz4SC6aO4kyqV3cnasf2seUSjcQ/kEz6DmeO0+RtPURrbYhYXlC60wuqc r0d5fjT2ktuF1alY0kNhYN0YqOZMP5YP2hJagCX7KkpeXCAJ0V6q08JzX+r6jw5LqjNQ BZmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W99bhPH/GvvWIYdk4muDmxRVHsWKf796RbI0pVNnwkM=; b=utazg/2snxhrWwio7ijxpgtiAV0w5XQtPegY+YZY7D2v1ECNylervMJGYLZeQMxY75 hIAbn8snzNcs2b5SDjflIXlU/BfOcBT3WW2jbj3HEmPHyr/dL14r85Xlr76InEFXoU1U dn7NEKERLn8qDEBD9kD0f/CHpEmkTluAcrdM0SAV4i9V5THGhcOFzGNiXb0Nw3WRV1hD mmfq3JE/JF0O+QiLgx+kSzFgZSp21XU3LzXO2mITtM1Mh5HcfS8kmucrjKZ//mSEoY16 ACHm66BKnGuy2U7OQPZR4P5lXnJNzIIQ90g9okKx71fl5rb1KiwEykrdiafVgDeh2rPa RxWA== X-Gm-Message-State: AOAM532Id9wKU14e0qh0nruu+2QGBOSGaQTee6gy6BRBfVO1WCD4pBkq rvZLAAuc3+XhUK3bRUJh1N3tWlNLvf5MU983qhyqtw== X-Google-Smtp-Source: ABdhPJyNH9ihxv+beNF2Ba691SDDo8DeynN/szGAhTv28QdLNEUqe6JD5f6mtxHgOWGFgpvRcffhGNn+oBJQY5VdX6M= X-Received: by 2002:a25:bb93:: with SMTP id y19mr1604013ybg.266.1634155370742; Wed, 13 Oct 2021 13:02:50 -0700 (PDT) MIME-Version: 1.0 References: <20211012152532.GC17948@tarpaulin.shahaf.local2> <20211013193740.GA27436@tarpaulin.shahaf.local2> In-Reply-To: <20211013193740.GA27436@tarpaulin.shahaf.local2> From: Bart Schaefer Date: Wed, 13 Oct 2021 13:02:39 -0700 Message-ID: Subject: Re: [RFC] Add xfail tests for || form of completion matchers To: Daniel Shahaf Cc: Marlon Richert , Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49484 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Wed, Oct 13, 2021 at 12:38 PM Daniel Shahaf wrote: > > If you want to clarify the documentation of the feature as designed, Just for the record, I believe that's what Marlon has done in the doc patch. I would not apply the xfail patch in its current state (where it removes existing tests and replaces them with xfails). Adding that set of xfails as new tests and documenting that they represent proposed behavior changes (without removing the existing tests) would be preferred.