From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 801 invoked from network); 26 Oct 2023 14:06:13 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 26 Oct 2023 14:06:13 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1698329173; b=NtAMfjO4T7X13OAyH6yn5ILbA4Wkm+m2hedPsKxGkgIj7yX0raKXuy7mhzFVDXsAD1hxTjLG7n R/W5/FFAHt43q7tiqplDxBhqgh4qs3P/PmIzR73v9SouuoRvG9kv0VuUeg16zg//PkRYJ+8PMi 9mAfQgQ46t0VhKAMDOFv6FoSDXy30+plv8c5hrifZvpMRi6hQtdSgZHfqHoGnjwnoI0iMKH++f Y402sohTN7Akgnm6U7bo4gO10FZ6leAaph3J7XMKWisgIjvPU5ii/iWLgezlYocldY4oSpYuMJ FbPsnbU9G/mrRkWGHIfzsz13C8pGBpCVJr1Fz6Q9iFIoOw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f44.google.com) smtp.remote-ip=209.85.218.44; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1698329173; bh=HoDbJzyKq3V/AC9opgsyPFzzI8IhQU6inxtTaFP24Io=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature:DKIM-Signature; b=h6FR8vwJCEZbjOJSkm3zEVEKcGF2NQWFe/0WvoZBVVSeKMKpyZ56Q2vwKkuaPXsJ8vZ9lVS0cW PEx6KQMKp/SqDvvT+n77unXxv/ZVqQ3C+E5YVD/pIV+Yn61B8S9KPAdTZksieQrnGMq1v/nfQ2 zHDR53/F7UfPZtAC7f22vIyHcH4ONw86GqvfCrhNzWxWnXRfP6wMR6xAmZlsufC8dhSy5cQQae hkCK2C8rtheVD5ythpiSkYGc9khkC4EBXgPfTI5vrorWVQCBeYowfjWWMjPrUdAW8n1frqd+y1 PxFaAFXWncUe3bi5mUUY3SgH8qZAA1Mzp9P9savNn6+sqw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=EV4o3By5H2Txh/a2NT4Srvf3SBLlnBO32mQ2ynwU5Q4=; b=oXgpCOsxAVniVAOx4RZcps+LU6 2CadILXSHjpo+EjQH+gv57vLcxFFT09vv+uB78mu6ksCeTcfY8IGNu4BsqWWAIxhhhdu1GQ1IC5xr IDZmJgVZ8l73zdBBzvlf92H290wWIUMzZe9PsTAWwXOqSJBQo6k1SfUWx7zQ4hQs6bNkT2jbPpPX/ Ffh0EdQPg3/Dy6PNDoRjPqE/Dam2GsmOqBXq+9OJr0+xplhkgUpRPN4Bkws+WnxVPwfKXgS4e7Za8 1mTogDhVUMkMdWz+X7lYqJaTVvgqWkwiF7Rgh8dr2fqFUd2NLJIPbxBLrACiFBwaol1weAnaDfpsy RASwuOcg==; Received: by zero.zsh.org with local id 1qw100-0001tm-I3; Thu, 26 Oct 2023 14:06:12 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f44.google.com) smtp.remote-ip=209.85.218.44; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f44.google.com ([209.85.218.44]:49319) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qw0zW-0001bL-Am; Thu, 26 Oct 2023 14:05:43 +0000 Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-9ada2e6e75fso160785666b.2 for ; Thu, 26 Oct 2023 07:05:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1698329141; x=1698933941; darn=zsh.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EV4o3By5H2Txh/a2NT4Srvf3SBLlnBO32mQ2ynwU5Q4=; b=iE8WV9qu7F04Fs2Lh0Nv0vFAc6agG/hyz6L10xCs6xxw+sJ9l0niXvvTaLehKJ0sOv y23chDWwIJu7YvRj/bZi/qXOaW2pObagE2k1gL+OxScpOxIgVyWfVOe+Pm9Ikg5MbgcB vNDPeRcoOAfWo71Ac6Xxgz8FQGLu8kAF38NcPmxqjXJJqQgsOn0AuvrTgfZnMjx6pn8e /K7qkePzcTlGInxFHhhC0at5/qWwTsiSXRr5vFAPWSXWBpeW2OE0nO3xpNCjLRc1jeQJ MvKrWdSXKsjubwOHUkHubJrZMZYCoeB99PtpiTeSfr+KiQ7VZVn502+4+Spxe9HRNRL3 Entw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698329141; x=1698933941; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EV4o3By5H2Txh/a2NT4Srvf3SBLlnBO32mQ2ynwU5Q4=; b=RJmDuKVC5tP4OXzlDmgT+4twdYWUFoKhRVCWXS/kTta9JUphS6MszLkzFfJXsJcxpT uVHA0wtSo5VbWM8kbvA7O8AsGALcD9EDDIG7ZuWToncIzK95Y7AkoNFL3+HqrzgPhOF+ 5z01WXdzZuIqMKowRqmmzyphq5qPylfc6WKCJUbMCJN5POgrHo6h5z9K3ye6GBHaRMEz 8I/+jcRjbGai/pMHhYs4leCezv7URJFc5JuOjUZN7oIfIMQS7lFp/8LcGeyUPO5qGPss Eip9AdGqAhsG6ZJ2JQQizfwZU6E8LdB4lPUQaRrmOd6/C+gVkfJOe8GP0N1xofyc5Eph xm/Q== X-Gm-Message-State: AOJu0YzW47XiY+/bXTA4Mzgb/OuEtSRfxdXkMg6fgspHX1nI8wCmdYTz MKWhrnBclRssg6TPlRY1u7DQ9b6Txxkna1MhCSQBo8bH+mXTFOj0 X-Google-Smtp-Source: AGHT+IGhBcMOTf8WKN4qj2pHtr7ZseQ5I2FaShm2SUUK9exzOS76w0m1ip7TdhDfJl0wBE9Z95WcDklotMHn/xn07fs= X-Received: by 2002:a17:907:71d5:b0:9a5:7759:19c0 with SMTP id zw21-20020a17090771d500b009a5775919c0mr250093ejb.64.1698329141184; Thu, 26 Oct 2023 07:05:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Thu, 26 Oct 2023 07:05:29 -0700 Message-ID: Subject: Re: [PATCH] Fix a bunch of Coverity-reported defects To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52249 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Thu, Oct 26, 2023 at 2:19=E2=80=AFAM Roman Perepelitsa wrote: > > On Thu, Oct 26, 2023 at 5:37=E2=80=AFAM Bart Schaefer wrote: > > > > A batch of the warnings that I ignored were assignments of one field > > of a union to another field of the same union, e.g., a casted long > > onto a double, etc., which elicited "overlapping copy" warnings. > > This can indeed cause problems. The conditions under which it happens > are subtle. Here's an example: https://godbolt.org/z/EvxTzM1hn. > > inline int foo(int* x, float* y) { > *x =3D 1; > *y =3D 2; > return *x; > } None of the instances flagged by coverity involved indirection through pointers, so I suspect we're OK there.