From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-45022-ml=inbox.vuxu.org@zsh.org>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=5.0 tests=MAILING_LIST_MULTI,
	RCVD_IN_DNSWL_NONE autolearn=ham autolearn_force=no version=3.4.2
Received: from primenet.com.au (ns1.primenet.com.au [203.24.36.2])
	by inbox.vuxu.org (OpenSMTPD) with ESMTP id d4210a18
	for <ml@inbox.vuxu.org>;
	Fri, 13 Dec 2019 21:11:35 +0000 (UTC)
Received: (qmail 20269 invoked by alias); 13 Dec 2019 21:10:58 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
List-Unsubscribe: <mailto:zsh-workers-unsubscribe@zsh.org>
X-Seq: 45022
Received: (qmail 13375 invoked by uid 1010); 13 Dec 2019 21:10:58 -0000
X-Qmail-Scanner-Diagnostics: from mail-lf1-f42.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.102.1/25656. spamassassin: 3.4.2.  
 Clear:RC:0(209.85.167.42):SA:0(-1.9/5.0):. 
 Processed in 2.128447 secs); 13 Dec 2019 21:10:58 -0000
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: pass (ns1.primenet.com.au: SPF record at _netblocks.google.com designates 209.85.167.42 as permitted sender)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=R6I/mnS7ZqQqUqDqPwZE2fp84D8xjaBMdoCxCNRfnRk=;
        b=J1yFjrUeqJHSKGJUo3JiqpI1mQACL7820j5D2wT2kpixT37mUyT5xIbGPqTtXvBefm
         oOTS781bw9AyRKdfTFJ+zrCUY5lY9P2XRfKirjkf6xSYEG8Hq38GjwQEZTSJLk1KGwLm
         vz0cS0ZkyvmUVQPKTWA9Mds2i9d/8As3r+f7q4K3L9qa0nC573wbsEeaOlku1hLfHYBK
         RbRF0Plq2qXeWt+eoT95nu0tqzWc6hWx2Iu/q4wVfgKKqd/kE8EzRwfS86ruZQvz7RwX
         bWUF7/QMEEdBwj8MK55vnJHJBIX+vrYiR8zUBsWFxqdiTXE5L7zvG3d4CwkFXpTNyms+
         YbpA==
X-Gm-Message-State: APjAAAW/8RWpHVIZi3Q80978lhKBnrY5egXYcaVE6ZalbypwWyN/HzQS
	YYrZR2QXDCfkX5mntlLA0iwqIdjrc2ahIaKuR8T0oLDZO00=
X-Google-Smtp-Source: APXvYqwm8I0vuZwl/itDaOmv/o7B/82g1lRYLTdulQjY3q0ZbTS7PiAdislX/3P5uta/TODM1GLmEjPO9I41UIb30zg=
X-Received: by 2002:a19:ae18:: with SMTP id f24mr10463107lfc.155.1576271421258;
 Fri, 13 Dec 2019 13:10:21 -0800 (PST)
MIME-Version: 1.0
References: <CGME20191213171028eucas1p2e7820377701008b2d05c898192b7c17e@eucas1p2.samsung.com>
 <569822988.994307929.1576256973462.JavaMail.root@zimbra62-e11.priv.proxad.net>
 <1576258224.5214.31.camel@samsung.com>
In-Reply-To: <1576258224.5214.31.camel@samsung.com>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Fri, 13 Dec 2019 13:10:07 -0800
Message-ID: <CAH+w=7YkBVd7owgYo518hwOz1Kq9ZUxvLYgk_V1ZJ_sd5pVOOw@mail.gmail.com>
Subject: Re: TR : Re : [BUG] Crash due to malloc call in signal handler
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: multipart/alternative; boundary="0000000000002251d305999c4a41"

--0000000000002251d305999c4a41
Content-Type: text/plain; charset="UTF-8"

On Fri, Dec 13, 2019, 9:31 AM Peter Stephenson <p.stephenson@samsung.com>
wrote:

>
> If you're using the current git source, exec.c line 4673 has a call to
> fgetc(), which is indeed outside where signals are queued. ... The fix
> might be
> not to fdopen() the input file, but just read into a buffer with
> read().
>

Yeah, calling stdio routines with signals unblocked is not safe.  We should
be doing explicit memory management here.

>

--0000000000002251d305999c4a41--