From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2391 invoked from network); 7 Aug 2021 22:42:06 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 7 Aug 2021 22:42:06 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1628376126; b=RQ2HkiOVnamOo0kuQyqKanAfJfDzYPs2sWbeCDRnui66i+VHn74NmVm3KuS1yaFLvEBmzaGFBT FzDdWhE69yoLCPdl2HOYG1YM9wvsnSAM4QU2rD4PFb1wMqm3OQICHSEqs+HJX1NdWzdr0pdfU1 +nlaVbXZnvtOQeiIbAVgA1wtRnMO+tyMRQk3qRqKjAQfd0mmvaX4KaS7B0HZWH9pzF98bTvtVl Bk8n6q+tdtUXQ0GLdHrpjcY2meoTpIjW/Avb/4HNtUklsUXEZTbLrgWW2s/VWvrg7QYC8e71Z9 Mk5Up3RUG5fNJUpckGcP8hGWW3z7i7SsPW2rymBFV7UV0g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1628376126; bh=JTlMHLDh0t0ZgO0YNqAP3NivFyz53qpdnDdU61fBsNg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=JbXKUebuP0k2whJsEaWyaDAOyxIlKx40BEu7bEHC8wUGjU0eyTY6BeS63HTdztS2geZe1fKU90 MyCOM3KkEdAlpkzzEnyOPJ7UcJLqWZe+ZYgyVPTVAN+w1TDzRNM9DdwRqIdE+7miK04nFij7O2 VmJCTNp4C++/6dCanWvB8vMhASFt9TIlgXYOd1IBBgYVhbT+oMrBe/8khlK07EY2wgLfaumHuJ 58AkgulgqUB7GEOuFdzIvIPYKzjH1Y5fqbDgWmg6mfVhnVLOWNFMmb0animUOAVR4G5tn9TosU wjNm9kbjBlhRnHkVvaZCx6b6/AtPrPY8o2GXJXdhir/2fQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=3Utt4Y3qMhVhM1y27CtPCtFhS5xWxkqD+H8Bjl3UT28=; b=BvRl9AjlGNcTRUKCmQjYTCnUu2 z7qQpHpnBwNNhPdOgyOXu77IXEzpivMo3raGTNwwezuf8g1W6i32H0JU3FC+65mq2oBZ1vP9/MBKt BPDrNpN/AnmxNzTaRWjhcxd8aSFLpZ3iuOkSeGUOOTNRh8YYYsRTEiFJXZAjkM+bgP9FYLy0iaqgC YecAmsUf/WirXgvl1ug890AYVoePxiv/gOjrRisQRJzbZ6wHAOJQwMEoEEAM10mUBQvomH/HmjZ9u R6OwCehJjJX/OFiaSW2kxwV2KCmzk67pKKDcxUOhObqfxuucmTbG/BbvJvD0xylG6Y0MicyYDRDts cfx/GDTA==; Received: from authenticated user by zero.zsh.org with local id 1mCV11-0000an-UK; Sat, 07 Aug 2021 22:42:03 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f171.google.com ([209.85.219.171]:38789) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mCV0j-0000IL-ET; Sat, 07 Aug 2021 22:41:46 +0000 Received: by mail-yb1-f171.google.com with SMTP id c137so21928111ybf.5 for ; Sat, 07 Aug 2021 15:41:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3Utt4Y3qMhVhM1y27CtPCtFhS5xWxkqD+H8Bjl3UT28=; b=tTT5wAjaDJs2sCGWvCdeVkZr+XtPyNNDkwNRFPkRUQoFWRlGfUiTmBxyDVSiVbtqXT VSawdvsdt3+393qgcM7/TeNBcdiepUCf+fSdk3gXNTQQ3YKsH4Jdj3zWQ7F7lx1U5J8d dxzSN+r8FySKfP6uQfwT0jCSB2ExKdhbFECbpQJuP56322z3YA0gLlYcnmfpiFnvXptS XJjZYGmBeTeN+Vj+sZfNJCNsBDagLmWBKgj6FFf2k8E+vIry44eveg9jz7Kx6V+a3/Nr tzjK28tAff/ZYD4fPIpjwr6zbW/BSNpNhhg61Cg0QxpOuIIX/DVgTcuVFLbSI/LruPMi ws2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3Utt4Y3qMhVhM1y27CtPCtFhS5xWxkqD+H8Bjl3UT28=; b=GeTczjxz0X2Sgfyx+WUObsSUVQIo9BMjT0dUpjkNJPt5W4cBFq4mTEa6Yukq44BBPv FdduoJfBuQvjXvMyWInGy0ViOI/px+sIFXijSuCSqaTF9YYGsQuoM4dLuzQZwH+r6IDf UjeOaZB8afQDGd5S5K+dkZXkhx9HI5CCyWKjqypUd7rzZjCsTC5EAkwx83G29NFyQUbQ KD0iEF5eeIsqSdAG1AYpDtVOBOFr+qfsHjS3c5FUAdCorow4IpG+VLa9wzFV1CYxsXlu VYxshfdOyLK6Hifw6x5VwWVPv/nrXXmqzwfbt+2krN+51S3neWbtMdaihMc3k4g3PHtI +PNQ== X-Gm-Message-State: AOAM5301A5pmaYRzN+F9EsldIOSbtI7O8Vd9vua830sQ5SXg1RccWNrr /LAsv/kvGPT7O1VcNUPMeAR/Ll/NK2syxQ7V5mblRA== X-Google-Smtp-Source: ABdhPJx/SgPlJVL7O+wpL9TZ8++r9MH1It2gMEKoYYvU2WUS6rr+PIgIz1+Ts9KRxnYQn67vgOO9oyNdLuqKWi9GNL4= X-Received: by 2002:a25:d312:: with SMTP id e18mr22361478ybf.14.1628376103962; Sat, 07 Aug 2021 15:41:43 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sat, 7 Aug 2021 15:41:33 -0700 Message-ID: Subject: Re: [PATCH] Increase $COLUMNS when generating long option completions To: Marlon Richert Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49257 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Sat, Aug 7, 2021 at 12:56 PM Marlon Richert wrote: > > How does this patch look to you? Frankly, it looks unnecessarily complicated. What's the rationale for using COLUMNS=999 as a command prefix in every "eval", rather than just declaring once local -x COLUMNS=999 at the start of the function?? Why rearrange the other declarations?