From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10678 invoked by alias); 6 Aug 2018 14:00:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 43247 Received: (qmail 3710 invoked by uid 1010); 6 Aug 2018 14:00:25 -0000 X-Qmail-Scanner-Diagnostics: from mail-lj1-f196.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.208.196):SA:0(-1.9/5.0):. Processed in 1.739304 secs); 06 Aug 2018 14:00:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_PASS,T_DKIMWL_WL_MED,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BcaGZ1ZPHc4KLvffxPqiz8HJf4YxxyEII3sOYllfNjk=; b=NBHdIdE2SIq4kVZJOhcmqpLw/c42V69J7x659gO/rWcUmpjKicomw8GzvqRgtEa3M3 0Gw8z/gJBBW6q+/wMPtdfuBHp7p6wxZzAd/UuFw0iqsVhGgzMweXnzRtG87CvLKxMOcO JHqKfAtpSxin8wjt39HkoukIf+gtIuwkUq3hs+DlR9TqL0wLkuEtgfNP5WQQTFQEStnu UIx8bitu6o5Ki+92Ldf/l7bUZ5/YaO+e6dXwYzWj+iKGdyvBj9VvFiRxGSf+CBJYrZUx KsycBKnQOK7TvytcxdOrZA+jXdzhfJCYDnPJI3kSUqSGW/TkFYwDMn4lbZuXSBugVyxD 00LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BcaGZ1ZPHc4KLvffxPqiz8HJf4YxxyEII3sOYllfNjk=; b=ATBArzKRrBiJrybSZwrqj1TafxeNsJvHL6abCRajtPaWTJq2SgFU0vayaGlbpd3T8e s/pFx366LJV4/HVEU8zIp4vxeifKqKP5D0m1u12iIjL5XqBbgROksnAIqGONk2obhV83 Mny0shUyY1+rNYYTnXxfsRJRi7WKrysOLGQTwyD7V4GqxiXXdo6RTWt12QX05g0I42vP f0oF56rQ3weBlKlxkKSg3WYEKabo+FXqMzb6NbzZekOVXauDB4EJqUfVhxQZQsNTfWZi eNHo47G6xzGvKdxI8WAJ3mE4iRkhd7lre6rloZHltAITRnQsIa4wnpsPM1hEaao+hwU3 TEDg== X-Gm-Message-State: AOUpUlGP2kAhOYaYXR8wxL5I2vqfOpeXHZ7P4aFFSI3sxlNMNBVZdfcc u/OgUEuzpALtWli7t9XRMKJXNFt3SwI7R4+QlunmNxxJ X-Google-Smtp-Source: AAOMgpcZyDpfxisI0empVLu04lXf5MwIRI25RMj6uDYMhkZslO58ZwxTVPUnLEoSpvWQTT/2VtvmePbHAi+rSSiXSIk= X-Received: by 2002:a2e:5d88:: with SMTP id v8-v6mr12211618lje.137.1533564019036; Mon, 06 Aug 2018 07:00:19 -0700 (PDT) MIME-Version: 1.0 References: <20180806072813.5051-1-av6@dwimlabs.net> <20180806072813.5051-3-av6@dwimlabs.net> <20180806092032.uizmxvlc2oku2ik6@tarpaulin.shahaf.local2> <20180806092931eucas1p1c89ebf9f2ee4f5bb40ac2c650cf4a6f2~IQZLFzTOa0396203962eucas1p1k@eucas1p1.samsung.com> <1533557168.2552060.1464840800.74A5BE28@webmail.messagingengine.com> In-Reply-To: <1533557168.2552060.1464840800.74A5BE28@webmail.messagingengine.com> From: Bart Schaefer Date: Mon, 6 Aug 2018 09:00:06 -0500 Message-ID: Subject: Re: [PATCH 2/5] _hg: declare appropriate local parameters for ->string form To: Daniel Shahaf Cc: Zsh hackers list Content-Type: multipart/alternative; boundary="0000000000009862300572c4b273" --0000000000009862300572c4b273 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 6, 2018, 7:06 AM Daniel Shahaf wrote: > Peter Stephenson wrote on Mon, 06 Aug 2018 10:29 +0100: > > > > Are you suggesting avoiding looking at the return value, but looking at > > what its effect would have been at the point where you would have looked > > it? > > Yes. > There are a few cases where it is desirable to return nonzero even when matches have been added, and also the reverse. > --0000000000009862300572c4b273--