From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21163 invoked from network); 25 Apr 2022 18:57:45 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 25 Apr 2022 18:57:45 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1650913065; b=kqBQo1bzlyqtVhjTsHugc+Jha9kF/joQ/a9b57hkM/O2dqzGPeN2m8F6QxAvoNaupNVE1s8xce yrnT/sol+Wmgu1G7Gzsf4e5tksahpEhEJ6Y21LrKCwFe/qZ5Ib4WgO8njDeyIuLExMiXcXRv6G KsAGelzrly7YeHQrCtcscS/aZp2X0xmUUHuSPxHpYjPnzmM5lZpnety7n8zZYQWEg3sC7sdy7+ uk4g2z9CbOz+D0pc+yophYi30jSbGzhLrw/sRbi21L2cmQNIZuxf/EaxJwDMfPeLmZLF8/6+5k 0hP3snBS76eoC+FFLxxUHsasotYTP2r5eijGB6wPAFuRhQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1650913065; bh=WQ9r79i8K/SOGij3/3bepSmpPbqJq2m+JFFf+fgjfzI=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Gg+fKnjq97EpcXKBtOdDoxbJK/zUR3AsXmBTRb3qPpfkS0t3OlTMzSh6oGd3kOp4JLUG2UnXcD +t9Mj5XfaioILkbyUzU0P3SM5CLtUjCI/iL//kC++6SmHgmCq0/oR84EV+wmbodfyaR1WawC65 dPuC95YLzDwrInqjEDxYevVa0fsNLBI852EdcOXYRTbz9ajgySP2d7d1oTiBHWzuSQhZoc2J6n fWJe13yL8kPhKJ3dB2ItbSxASsbS14SyWvOzYWvYe+ikO9y5tFBtfi1pUtxpIRKAWIkPF/YXih Gynjk0/EsbBw5ZJAeNOgbevqFk35X6KHHLNeu01zmLaG7w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=G5n0s9vmOUZnmxBzbamgnRKlKn+aFUWF0WHcAzKmj0Q=; b=TcJd646/Nvxa4/Dl3mlrwp5P7+ BGu+NqYvvNAuxYsgmWofXAQDnWFZzm5ne4stpJBaQ00HgCZP1K7R2qfPInHF2YeyEva+2sTi487OH xDgF0lEecHe74aoPCbHIT/hwEIL4gjpq8bJUl1NVbsR1rDI37+SAEqbn6C2VkkcYaTB/oDN+plS2F gsykpSQDxEUyzxd+fnxuvNejoRjtb7auiYKEIPrCRgECkZgdr1P0dm+l+NktKIP54LOAsF7CmSqH7 cGcP9wIsQvjHWwUvQq3za4krjrcBxIrLbN0QPihr8XyzCw9GsAX6nwMAqtcaVo40v6W4Djto3eeB2 ZviBuW4w==; Received: from authenticated user by zero.zsh.org with local id 1nj3u4-0009r1-MT; Mon, 25 Apr 2022 18:57:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f51.google.com) smtp.remote-ip=209.85.208.51; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f51.google.com ([209.85.208.51]:33385) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nj3tX-0009Y7-AC; Mon, 25 Apr 2022 18:57:12 +0000 Received: by mail-ed1-f51.google.com with SMTP id p4so3971734edx.0 for ; Mon, 25 Apr 2022 11:57:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G5n0s9vmOUZnmxBzbamgnRKlKn+aFUWF0WHcAzKmj0Q=; b=Pg6MMvl64qV/q0Fhkbjpbev+wCdwZ6f5VEwx41mqlRpLE0Q1dIG9sJnd+5ocAq1T76 wpPd/FzrYygaomje6c9M9908HzXFTBVNRxsK+lIwUpdgv8i6mNPnNrH10n57F21376Av odHGq//up39Zb5KwFi9zJKomswcQoV5JfqArx9di2/cBovY+WIYSVrIvOTaUlDLI7b8I tfrNDLKcSKPLki7Ri6Ykh09QRyTAcuIGgeyAgC3Zsmy8Ebs/OhWU6EjTLlsiyAbdHByk 1m3KzQs45a3LYs2KZR3uv9bGjZFwwkadxk+atpUNp+KA2KXLgM7Fh85q//j/zXVOPc8l EtdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G5n0s9vmOUZnmxBzbamgnRKlKn+aFUWF0WHcAzKmj0Q=; b=fm5RHSP9t2kJdYheOVw60DoX71aLccL/jZoIlauGkBCkKCSd/xp1MenIloiTdceYvA Xq0/a0aOINR0DE0dqtDEgdc9Vvn3yn5uOspOD3xPKKrGiCKyc6NvQXWTI6VV4VqnQN4y P9esOwdUCyTBnFrDQXMOSV8m1GryuenfLaj+8nxLHrwqUoGEntvw8aPdw4q+/eRrhDHa y19YNfFHqhS3tTmmpcBZHv0x3aAs6BhJ/yG2tyLtcCTKDxRkCK3lsCQQP0lmkKEdtWZ9 BYbyfJTTP6GFtlNxC8Hh3G5JOxs+O8NlRS8lUn+Tql0PWqG9teo/ISfqNK/C9la4CbIB jztA== X-Gm-Message-State: AOAM533dBVMhKQwgLqPh7idPExSWL/eOi6o8ReMq8owqzBoGZNwnBDQo tszuYuRrvyKK7Zzic8Ek1yTplxiEXikqZXm7qxbSfQ== X-Google-Smtp-Source: ABdhPJzup+SI2rTwv+N7Oa5ENJJkwwnLhDl3ZTGC5efl3vtmq54Od4vCwp8k/ZYZOfnW9eCMouU5ScSBtz0l2xou/Fk= X-Received: by 2002:a05:6402:4404:b0:423:d791:5e64 with SMTP id y4-20020a056402440400b00423d7915e64mr21051114eda.249.1650913030823; Mon, 25 Apr 2022 11:57:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Mon, 25 Apr 2022 11:56:59 -0700 Message-ID: Subject: Re: ZSH performance regression in 5.8.1.2-test To: Jordan Patterson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 50091 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, Apr 25, 2022 at 11:26 AM Jordan Patterson wrote: > > This recent fix has led to a performance regression in zsh: 49792: > Non-interative shell input is line buffered. Hm. If we use stdio for speed, we have memory management re-entrance issues that can lead to a crash. If we use direct read of more than one character at a time, we can't enforce line buffering. Is there a way we can detect the case where we need to line-buffer and avoid it otherwise?