From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 18267 invoked from network); 9 Jun 2022 22:04:37 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 9 Jun 2022 22:04:37 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1654812277; b=g++6kAVDBpRL7IyP3478QG1o3LDLN+JOsAE4LGgC7XgSC9gvzuUbUwKQsaHFnSBDXIXmL6/TCM JP1Lk7X7XTPR8YHIBNnYXTGZL/otYB/w/5g42sI7U1VsUQITCnDh+hLyGevpzKNiZQUWz2HSHO xSkLkw5yuji2ZuKhfD5T9aFZaruDmnKsDOqLGsD9arjyKhL1AJ7O8pe9NhJUDX5W1MyOXN8QT9 WW8qBdyzWQ2gIvl1+JrYes+dHjoG48hMWmVKsJkMq2TmKa0mfIM5Fb/wxBUqUZLNSrTtlw49zU s6nQM2t3+7ejdZDSoxd/xLiSdFttNpXQ9dYiEZPWhaReuA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f46.google.com) smtp.remote-ip=209.85.218.46; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1654812277; bh=6MILZ351QgZMgdmtchtwMsaq3BNFhQjXYGnlfJPhiH4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Wy1mlCDEC8/TKBCMaivN/ep4uWxjoa9JIGxEo6JZ5BF8QgFFnHwpGdJTTUxuLDpuaIyqJPVkiV GCMptlKSCPcM5PWpIkXhr9OZ0ndfKcIWsTHnNweVO90GpL/4gYC0B1HXGwfk5kJ3Fi+VDMfNqW JYEF691XfsO4aWgV8bAMrWJCYMu8OUc3Uq7rorfnU+BOgMQcNPlQF11gpR3dYlV/mnrpLfp0ih 65YbV0nh6h53emOFegqDeMwR1MzjlNM0be441UwJm2QfC3FmUoM6EpZx5UZ/KFknWMFG8s3CVb J2Gub58mvNOWGizXwNvAiMec4dUyDm6zSjwYghJI/tg2lQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=6MILZ351QgZMgdmtchtwMsaq3BNFhQjXYGnlfJPhiH4=; b=m/uxFNuzhGcAYwnd48SECRK/tg dTF/vCkvf3HEpHuRifPOVY9lqpFSPR+LCZ1ApQtTcWKAw8yAEwWcKv/FammSZLQz6QzRkC9bbxPVl 98bIxWTeCWavRMf8Dvah76qCqS+ZQRWKjmySe50BbEfakAyTctNy2VE9KHuhzzclauY67xNxpUQPq yLq/YWcSKuBOjm4vlgAWfwBVUKJN+AOjlV7ksdDeC+AcgFVKiZOe4LCqiLeIlNj2jzX5tBkUb/WYk t42nxM56GN33wqYyIi/gwLO1L/2zXKJbPiEn4jVQ7lWrSZYFCPn1xvSJHdFwdQyHs2+sbU0o4uC7p CJu5FraQ==; Received: from authenticated user by zero.zsh.org with local id 1nzQGa-000OK2-SD; Thu, 09 Jun 2022 22:04:36 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f46.google.com) smtp.remote-ip=209.85.218.46; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f46.google.com ([209.85.218.46]:36769) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nzQGJ-000NzI-1k; Thu, 09 Jun 2022 22:04:19 +0000 Received: by mail-ej1-f46.google.com with SMTP id s12so42876946ejx.3 for ; Thu, 09 Jun 2022 15:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=6MILZ351QgZMgdmtchtwMsaq3BNFhQjXYGnlfJPhiH4=; b=2S/ME8zbZ3h0MFKYLUd9RaXQbDkN2m0c1BEVT/bwYFgygA/mHA2vxFSbI9k+1YwpXn CVR26UiisumhdmUVZxELQRxCDz6j+IhPvEjKjs3BUtzyGiurzCquWMqWHaiFey/H5J1W qZpANWOyariJekA7YZk2CcN7D6mFRADzABUBUaubDUhEZb6kUiBf5mV4dv7IcIMMFTNW V21WWm9D/OZ52evOCMml/dRAsHQOAqpGj4rfwjRk7W8aMcQxeWzXkWmC8a+gWGUPKnlH K4BYoOK5J7EYTJRr8JsVJwbeTVcuZ6AM7Sbg+W8lufgMmpOcgYDjVj/5kncNoBuKCnR2 h59Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=6MILZ351QgZMgdmtchtwMsaq3BNFhQjXYGnlfJPhiH4=; b=fKBWz8xkOdhdcoQgYmxEryxe8OVLHE7QnWEO273oetkL2bTQyYuhXrtkUK8wgGOd/j 8zZxi14dyypK2DVBbPBb+irifiMz9PZAkCqHK1iQjUlLrrR2f/KBwtKyzOHUom0uYg// 2wpn8CmMUoYH5TprZu0evGanAkH3AbZt+JCWwDdfBWz5iK+t2RfNvRMeYdt0zPgyRRM3 UYOWy/Eo64Yjj3Zo8fDwkDVfrWPPgvkHYDJae83KououJlOwXGrYm+oaordmc84TcELQ UIJOh+GmSMSvk1fYG7ObHSf73fVmls18hy9K3ZN+gP5UuXt0gITSZpzzk8VAo1kT/ZzJ 46iw== X-Gm-Message-State: AOAM533lQ8s2HqoH5+56Ep+e2p5l+LI5BybGbYmBlW16Qry0pZ5By28P jHeSdwcUAkywcHFnX4zI4mnPxuXWumCRXbV/a2VT2CmAEoY= X-Google-Smtp-Source: ABdhPJz8gQFOmfT0S79FdozdGlaQsVPJO5tNXOhxxHdZEbG6sGpCWXQhl5oFdE4c2JO2mXaLRPxh7eQsDzEN+9KGYKk= X-Received: by 2002:a17:906:c1:b0:712:1fb1:641 with SMTP id 1-20020a17090600c100b007121fb10641mr752101eji.55.1654812258445; Thu, 09 Jun 2022 15:04:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Thu, 9 Jun 2022 15:04:07 -0700 Message-ID: Subject: [PATCH] Re: Segfault with "private" parameters inside "always" block To: Zsh hackers list Content-Type: multipart/mixed; boundary="000000000000d5e53505e10b0017" X-Seq: 50363 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: --000000000000d5e53505e10b0017 Content-Type: text/plain; charset="UTF-8" On Thu, Jun 9, 2022 at 2:03 PM Bart Schaefer wrote: > > zsh/param/private assumes the heap created in startparamscope() is the > only active heap until endparamscope(), but "always" blocks allocate > and free another layer of heap, which invalidates the memory "private" > uses for the parameter GSU structures. That was a lot simpler/more straightforward than I expected. --000000000000d5e53505e10b0017 Content-Type: text/plain; charset="US-ASCII"; name="private_mem.txt" Content-Disposition: attachment; filename="private_mem.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l47kgry50 ZGlmZiAtLWdpdCBhL1NyYy9Nb2R1bGVzL3BhcmFtX3ByaXZhdGUuYyBiL1NyYy9Nb2R1bGVzL3Bh cmFtX3ByaXZhdGUuYwppbmRleCBjNTM4MzkxNTIuLjA2NWZhNjNkMiAxMDA2NDQKLS0tIGEvU3Jj L01vZHVsZXMvcGFyYW1fcHJpdmF0ZS5jCisrKyBiL1NyYy9Nb2R1bGVzL3BhcmFtX3ByaXZhdGUu YwpAQCAtOTIsNyArOTIsNyBAQCBtYWtlcHJpdmF0ZShIYXNoTm9kZSBobiwgVU5VU0VEKGludCBm bGFncykpCiAJICAgIG1ha2Vwcml2YXRlX2Vycm9yID0gMTsKIAkgICAgcmV0dXJuOwogCX0KLQlz dHJ1Y3QgZ3N1X2Nsb3N1cmUgKmdzdSA9IHpoYWxsb2Moc2l6ZW9mKHN0cnVjdCBnc3VfY2xvc3Vy ZSkpOworCXN0cnVjdCBnc3VfY2xvc3VyZSAqZ3N1ID0gemFsbG9jKHNpemVvZihzdHJ1Y3QgZ3N1 X2Nsb3N1cmUpKTsKIAlzd2l0Y2ggKFBNX1RZUEUocG0tPm5vZGUuZmxhZ3MpKSB7CiAJY2FzZSBQ TV9TQ0FMQVI6CiAJICAgIGdzdS0+ZyA9ICh2b2lkICopKHBtLT5nc3Uucyk7CkBAIC0yNjksNiAr MjY5LDggQEAgcHBzX3Vuc2V0Zm4oUGFyYW0gcG0sIGludCBleHBsaWNpdCkKIAlnc3UtPnVuc2V0 Zm4ocG0sIGV4cGxpY2l0KTsKICAgICBpZiAoZXhwbGljaXQpCiAJcG0tPmdzdS5zID0gKEdzdVNj YWxhciljOworICAgIGVsc2UKKwl6ZnJlZShjLCBzaXplb2Yoc3RydWN0IGdzdV9jbG9zdXJlKSk7 CiB9CiAKIC8qKi8KQEAgLTMwNiw2ICszMDgsOCBAQCBwcGlfdW5zZXRmbihQYXJhbSBwbSwgaW50 IGV4cGxpY2l0KQogCWdzdS0+dW5zZXRmbihwbSwgZXhwbGljaXQpOwogICAgIGlmIChleHBsaWNp dCkKIAlwbS0+Z3N1LmkgPSAoR3N1SW50ZWdlciljOworICAgIGVsc2UKKwl6ZnJlZShjLCBzaXpl b2Yoc3RydWN0IGdzdV9jbG9zdXJlKSk7CiB9CiAKIC8qKi8KQEAgLTM0Myw2ICszNDcsOCBAQCBw cGZfdW5zZXRmbihQYXJhbSBwbSwgaW50IGV4cGxpY2l0KQogCWdzdS0+dW5zZXRmbihwbSwgZXhw bGljaXQpOwogICAgIGlmIChleHBsaWNpdCkKIAlwbS0+Z3N1LmYgPSAoR3N1RmxvYXQpYzsKKyAg ICBlbHNlCisJemZyZWUoYywgc2l6ZW9mKHN0cnVjdCBnc3VfY2xvc3VyZSkpOwogfQogCiAvKiov CkBAIC0zODEsNiArMzg3LDggQEAgcHBhX3Vuc2V0Zm4oUGFyYW0gcG0sIGludCBleHBsaWNpdCkK IAlnc3UtPnVuc2V0Zm4ocG0sIGV4cGxpY2l0KTsKICAgICBpZiAoZXhwbGljaXQpCiAJcG0tPmdz dS5hID0gKEdzdUFycmF5KWM7CisgICAgZWxzZQorCXpmcmVlKGMsIHNpemVvZihzdHJ1Y3QgZ3N1 X2Nsb3N1cmUpKTsKIH0KIAogc3RhdGljIEhhc2hUYWJsZSBlbXB0eXRhYmxlOwpAQCAtNDIwLDYg KzQyOCw4IEBAIHBwaF91bnNldGZuKFBhcmFtIHBtLCBpbnQgZXhwbGljaXQpCiAJZ3N1LT51bnNl dGZuKHBtLCBleHBsaWNpdCk7CiAgICAgaWYgKGV4cGxpY2l0KQogCXBtLT5nc3UuaCA9IChHc3VI YXNoKWM7CisgICAgZWxzZQorCXpmcmVlKGMsIHNpemVvZihzdHJ1Y3QgZ3N1X2Nsb3N1cmUpKTsK IH0KIAogLyoK --000000000000d5e53505e10b0017--