zsh-workers
 help / color / Atom feed
* BUG: calendar style date completion broken
@ 2019-10-16 19:59 Manuel Presnitz
  2019-10-17  2:02 ` dana
  0 siblings, 1 reply; 4+ messages in thread
From: Manuel Presnitz @ 2019-10-16 19:59 UTC (permalink / raw)
  To: zsh-workers

Hi,

using the (at the time of writing) latest head of the zsh source
(zsh-5.7.1-148-g59901e6), the usage of the "calendar style date
completion" (_dates completer with menu selection) returns only
gibberish.

A minimal example to reproduce should be

$ autoload -Uz compinit
$ compinit
$ zstyle ':completion:*' menu select=1
$ ls *(cw <TAB>

Instead of a nicely formatted calendar you get some garbage to
select from.

Unfortunately I wasn't able to fix this bug myself, as the completion
system is (still) black magic for me, so I could not supply a patch.

Instead I narrowed down the first occurrence of the bug to this
commit

[ cd6fd2b0a 44274: allow finer control of completion match
[ soring with compadd's -o option

I hope this is at least a little help for you.

Thanks a lot,
Manuel.



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: BUG: calendar style date completion broken
  2019-10-16 19:59 BUG: calendar style date completion broken Manuel Presnitz
@ 2019-10-17  2:02 ` dana
  2019-10-17  3:39   ` Bart Schaefer
  2019-10-19 11:37   ` Re[2]: " Manuel Presnitz
  0 siblings, 2 replies; 4+ messages in thread
From: dana @ 2019-10-17  2:02 UTC (permalink / raw)
  To: mpy; +Cc: zsh-workers

On 16 Oct 2019, at 14:59, Manuel Presnitz <mpy@gmx.net> wrote:
> Instead of a nicely formatted calendar you get some garbage to
> select from.
>
> Unfortunately I wasn't able to fix this bug myself, as the completion
> system is (still) black magic for me, so I could not supply a patch.

I don't think i've ever used this function before, so someone should probably
confirm that it's all there, but this seems to bring the calendar back for me
at least

dana


diff --git a/Completion/Unix/Type/_dates b/Completion/Unix/Type/_dates
index 0af10eb24..b75b3af0c 100644
--- a/Completion/Unix/Type/_dates
+++ b/Completion/Unix/Type/_dates
@@ -73,7 +73,7 @@ for ((;rows;rows--)); do
   (( spacing = COLUMNS - 32 * columns + 2 ))
   disp[-1]="${(l.spacing.)}"
   (( spacing < 2 )) && spacer=0 disp[-1]=()
-  expl[1+expl[(i)-V]]=dates-$rows
+  expl[1+expl[(i)-J]]=dates-$rows
   compadd -x "$mlabels" "$expl[@]" -d disp -E $(( $#disp ))
 
   for ((line=0;line<6;line++)); do


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: BUG: calendar style date completion broken
  2019-10-17  2:02 ` dana
@ 2019-10-17  3:39   ` Bart Schaefer
  2019-10-19 11:37   ` Re[2]: " Manuel Presnitz
  1 sibling, 0 replies; 4+ messages in thread
From: Bart Schaefer @ 2019-10-17  3:39 UTC (permalink / raw)
  To: dana; +Cc: mpy, zsh-workers

On Wed, Oct 16, 2019 at 7:03 PM dana <dana@dana.is> wrote:
>
> I don't think i've ever used this function before, so someone should probably
> confirm that it's all there, but this seems to bring the calendar back for me

Something to do with workers/44274 perhaps?

> -  expl[1+expl[(i)-V]]=dates-$rows
> +  expl[1+expl[(i)-J]]=dates-$rows

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re[2]: BUG: calendar style date completion broken
  2019-10-17  2:02 ` dana
  2019-10-17  3:39   ` Bart Schaefer
@ 2019-10-19 11:37   ` " Manuel Presnitz
  1 sibling, 0 replies; 4+ messages in thread
From: Manuel Presnitz @ 2019-10-19 11:37 UTC (permalink / raw)
  To: dana; +Cc: zsh-workers

dana hat am 16.10.2019 um 21:02 folgendes geschrieben:

> I don't think i've ever used this function before, so someone should probably
> confirm that it's all there, but this seems to bring the calendar back for me
> at least

Thanks a lot! The patch works for me as well. However I don't use the calendar function
very extensively, but so far I haven't observed any further regression.

Manuel.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-16 19:59 BUG: calendar style date completion broken Manuel Presnitz
2019-10-17  2:02 ` dana
2019-10-17  3:39   ` Bart Schaefer
2019-10-19 11:37   ` Re[2]: " Manuel Presnitz

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git