broken patch in Zsh Mailing List Archive

broken patch in Zsh Mailing List Archive

[Jun. T]

I've noticed that the patch in

https://www.zsh.org/mla/workers/2024/msg00461.html
workers/52899: [PATCH 1/1] zsh/random

is duplicated, and moreover, the 1st half is corrupted.
For example, a line starting with
  +For example, if $#a is 16, you would ...
is combined with the following line. There are a few more
shuch lines.

I guess the 1st half is from the mail text and the 2nd
half is from the attached file. I have no idea why the
1st half has been corrupted.

So what is the recommended way to send a patch?
Include in the mail text (and do not attach a file), or,
if it is not possible, attach a file?

Re: broken patch in Zsh Mailing List Archive

[Bart Schaefer]

On Mon, Jun 17, 2024 at 8:11 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> So what is the recommended way to send a patch?
> Include in the mail text (and do not attach a file), or,
> if it is not possible, attach a file?

The ideal would be to include it in the mail text, but that requires
that the mail be (plain) text without line folding, and that's
increasingly difficult to enforce, particularly with web-based
interfaces (scowling at you, gmail).

So the practice I've been following (when I don't forget / am not
answering in a hurry) is to create a text/plain (.txt) file and attach
it, because the zsh.org archive will inline that as if it were in the
mail text.

Sending the patch in both places is just confusing.