From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: ksh compatibility: initial value of $_
Date: Fri, 31 Mar 2023 12:02:38 -0700 [thread overview]
Message-ID: <CAH+w=7YyZEQ14VR3WCVftZwANcD5vOhhCXNY0BkCo+BnM2E+Qw@mail.gmail.com> (raw)
In-Reply-To: <E94281FE-8AAB-4410-999B-1E2C350D5104@kba.biglobe.ne.jp>
On Fri, Mar 31, 2023 at 7:32 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> +++ b/Src/init.c
> @@ -1084,9 +1084,18 @@ setupvals(char *cmd, char *runscript, char *zsh_name)
> + zunderscore = getenv("_");
> + if (zunderscore) {
> + zunderscore = metafy(ztrdup(zunderscore), -1, META_REALLOC);
> + underscoreused = strlen(zunderscore) + 1;
> + underscorelen = (underscoreused + 31) & ~31;
> + zunderscore = (char *)zrealloc(zunderscore, underscorelen);
> + }
> + else {
> + zunderscore = (char *)zalloc(underscorelen = 32);
> + underscoreused = 1;
> + *zunderscore = '\0';
> + }
Is there a simple way to call setunderscore() here instead of
duplicating most of it? The complication mostly seems to be that
metafy() doesn't handle a NULL string, so we can't just
metafy(getenv()).
> + zunderscore = metafy(ztrdup(zunderscore), -1, META_REALLOC);
This at least could just be
zunderscore = metafy(zunderscore, -1, META_ALLOC);
??
next prev parent reply other threads:[~2023-03-31 19:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 1:52 Bart Schaefer
2023-03-23 10:40 ` Jun T
2023-03-31 8:18 ` Jun T
2023-03-31 14:31 ` Jun. T
2023-03-31 17:45 ` Bart Schaefer
2023-04-03 11:16 ` Jun. T
2023-04-03 16:48 ` Bart Schaefer
2023-03-31 19:02 ` Bart Schaefer [this message]
2023-03-31 19:03 ` Bart Schaefer
2023-04-03 12:13 ` Jun. T
2023-04-03 16:50 ` Bart Schaefer
2023-04-04 16:24 ` Jun. T
2023-04-05 1:03 ` Oliver Kiddle
2023-04-05 8:15 ` zeurkous
2023-04-05 9:00 ` Oliver Kiddle
2023-04-05 16:24 ` Jun. T
2023-04-05 8:14 ` dana
2023-04-05 18:16 ` Jun. T
2023-04-08 4:03 ` dana
2023-04-08 16:22 ` Oliver Kiddle
2023-04-09 13:30 ` Jun. T
2023-04-10 0:51 ` Jun T
2023-04-15 5:02 ` Felipe Contreras
2023-04-15 22:24 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7YyZEQ14VR3WCVftZwANcD5vOhhCXNY0BkCo+BnM2E+Qw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).