zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Oliver Kiddle <opk@zsh.org>
Cc: Zsh workers <zsh-workers@zsh.org>
Subject: Re: PATCH: don't reopen completion dump for append 26 times
Date: Mon, 27 Sep 2021 12:40:30 -0700	[thread overview]
Message-ID: <CAH+w=7Z+B99FKPdhYvYpuY8ajfpv7CoX3RjfyWnZ5+yagTOZfQ@mail.gmail.com> (raw)
In-Reply-To: <49155-1632766585.200905@F_BP.pomt.vBre>

On Mon, Sep 27, 2021 at 11:17 AM Oliver Kiddle <opk@zsh.org> wrote:
>
> However, any objections to the following change? Or would it be better
> to enclose everything in braces and use a stdout redirection?

Unless there's another reason to enclose everything in braces -- such
as, in order to use an anonymous function to increase the local level
or change setopts -- I think the patch as-is would be fine.


      reply	other threads:[~2021-09-27 19:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-27 18:16 Oliver Kiddle
2021-09-27 19:40 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Z+B99FKPdhYvYpuY8ajfpv7CoX3RjfyWnZ5+yagTOZfQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=opk@zsh.org \
    --cc=zsh-workers@zsh.org \
    --subject='Re: PATCH: don'\''t reopen completion dump for append 26 times' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this inbox:

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).