From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 2802 invoked from network); 4 Dec 2023 00:05:57 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Dec 2023 00:05:57 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1701648357; b=ftqLbe7RvxTEsp0E8MpUX8YBb6dvgT/mx0+dV0c0EoA4rIAuSbokUkj8qex1MMoQDoaas7WnYy /e7eAJRGef3rMGQIBjBX7Y+3a2r6ERB407AMXf703dBVAih2JQ56Sik3tt+YgT8T0xFsSdOJAh qv3mWQG6VShZnP0RpPE6c/6O80FmZRyoRgwn2/8yoN0QHg6Arh3EYnGxnSrLtemrNJjF3HuB54 przasO8lIu2PeHmSP6aDE0huXQ72R70ldQ1X1KQ2DABwS3vslr9YAn2FppVxd3EguRXoy8bazT P3ptaTh4GSAINE8BQVKeLF6nezV1mS4jmh5Hudqem3fb/Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f48.google.com) smtp.remote-ip=209.85.218.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1701648357; bh=vxKCf75Sm6QOqKSsGzDkKnAuxhV8kFlZoogZ7hWeGbY=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=GGDThyBk0J+TSospZfYi6AZUuj2m+Jz91BaBmpNQMrpin2jAIEpNOp/rF/ZQwVPv67IJ+3QsPW JaEU9EqVCwB3q4EAkZVYegG+Hqd31yi0SiS44CdTv2en7cwQOyaMkIa1BbORBJPuhYLO91tb0G yFRts2IMAGf5A1p7bX7WzmqVcVkTYdU+37EAgjsJStpvgv7t42mnHfMsxZtp7eZtYCBD1lzdDo 2OFsQ8/XsZCNOnUeF+8ZsNyqKfDDjLpXUIAEQ2SXPC7evvIIRlV0Jj3NwWKP+WXT7DpdJPByD4 ZYwFtjQORLETm5bp2Lt8jGhlsohB/HcYL7Ugkpuc6CoC1w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=lcF48c+NGq16a3h4fBjxjriI/mgYTIkObacwkjTIEHM=; b=Fhx8mGAfjDBFU0I0RA+GV/KSPO VErlDBHNqfGfVxEs+yrjpEJkwTcLkcjGJsPzxQPcwLImoqrJNvFM9uqRkvGifJbBl7sNdiZXvDcHS 6MScAYm7WLX8K0ocV77J2R/hlPSkyuhAD2p66uvSixIhvsYGzDsbV8OkX+7OrNT6v6k7MLCFTOUTQ AhMIpMk0jt1qIUy9+ozAOEIe/fJveZnC6086XNfSldT0L5ksQYJgSxWtv63tqp+DWlAAMABtVOS9r 4Sd51cn/mAu7aXcOnRXbF21KwOXFeeZOWjVO5Ylv1UFZr9pDEjEYK42rhzQHuAmBI3IkeUtdazw14 1hA7sVEA==; Received: by zero.zsh.org with local id 1r9wTE-000N3S-5a; Mon, 04 Dec 2023 00:05:56 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f48.google.com) smtp.remote-ip=209.85.218.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f48.google.com ([209.85.218.48]:57603) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1r9wSf-000MlE-Rw; Mon, 04 Dec 2023 00:05:22 +0000 Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-a196f84d217so372899366b.3 for ; Sun, 03 Dec 2023 16:05:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1701648321; x=1702253121; darn=zsh.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=lcF48c+NGq16a3h4fBjxjriI/mgYTIkObacwkjTIEHM=; b=O5etPQPZz0mgAfaO9Y/M9LZo5sy0xZhzSFrOj24d4g4XAKi18S2g6eHDXOoaUcKhbj 0L3umzgR7x4/n+yFwwx5QelLqQ7nwPTpPQLouGE61zdqX1xMpDRQltycq7xWpCXUcVlu BTK2CFgRX+dF5sqv45qfJhYFaKLgNFkdIAd+3/r9rt0czClB6rWLpPQaLGYbrmlL3hlu aFAdVReU+qhjgQ1tJ/kxvHjqNrf3nndFZAonCJJ4I0cDxvxbPymt1TQGFh6+R7iFfWpf SA+eWA1eZDrYZUPjdzE1QrElISKrfSmXinHvEnj14UMyNAVeG5JO4cG9uDCWsi+EpFhs 8FIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701648321; x=1702253121; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lcF48c+NGq16a3h4fBjxjriI/mgYTIkObacwkjTIEHM=; b=N+K0hGdCcC8B9jaCJARytmjiD0IfMw5c96y4VMChgo+q3+LLScbBQvbPPXJEFpsKqL dZwl2ng9XRZnJaW7h8LA1LEmafsGTCuD27/mWQJXOK59Klj0bh/XKplOCIu3SFq13RFW vjP+NolscgHfpMWJUDadndDqLMZvz766nNr80va3V+tVyp1exaIayaQbpY/7vJVoIknS 26VWn1vtbG0UhazL3svr6IpsLuFkd+F6KuyLTL+Pganusv/6btjmNosn8FrC8Y3rd1Ug F06qNyvd//Rv8lgBvnAsupIjAaytPdpkLYmOTMpDjzQ8fikrMzpfOtZxTivhbKWESOVL we+g== X-Gm-Message-State: AOJu0YzjF2pDbkXQfUDaXRzRgf1LKtMohAngrqTBtoNj3MfYx7iAYWu/ h9vwD5V93uz3eoNTsrw5pvBiNESUI5/ELBSUFg85N2XIi19Ut4uVwX0= X-Google-Smtp-Source: AGHT+IFjeIbmXJKAjb7/midfMI2t2XEUmcB5novQOC45NykTC9Besuzwh9zfe0HJQX47y4J6XCDiroa3YrLEt0S2nRg= X-Received: by 2002:a17:907:6eab:b0:a19:a1ba:8cc4 with SMTP id sh43-20020a1709076eab00b00a19a1ba8cc4mr3543924ejc.98.1701648321159; Sun, 03 Dec 2023 16:05:21 -0800 (PST) MIME-Version: 1.0 References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> <27223-1701637728.078257@Bkhc.Hp7M.X2jV> In-Reply-To: <27223-1701637728.078257@Bkhc.Hp7M.X2jV> From: Bart Schaefer Date: Sun, 3 Dec 2023 16:05:09 -0800 Message-ID: Subject: Re: PATCH: Improve quote handling in _ant completion To: "zsh-workers@zsh.org" Content-Type: multipart/mixed; boundary="000000000000b7486e060ba3df12" X-Seq: 52366 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --000000000000b7486e060ba3df12 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Dec 3, 2023 at 1:08=E2=80=AFPM Oliver Kiddle wrote: > > It definitely would be best renamed with _ant_ as a prefix. I would just > call it _ant_targets and include the compadd line in the function. That last is a little tricky because it calls itself recursively. > Perhaps whoever wrote it wanted to use it outside of completion. Heh. > It could also be rewritten to use fewer subshells. I'm not certain enough of what's going on in there to try to do that. One subshell is just to protect the parent against a "cd", the others probably tail-exec themselves except for the one that has an "echo $file | sed". Rewritten to avoid "sed" you mean? The s/// are mostly pretty gnarly. --000000000000b7486e060ba3df12 Content-Type: text/plain; charset="US-ASCII"; name="more-_ant.txt" Content-Disposition: attachment; filename="more-_ant.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lpq5fsoh0 ZGlmZiAtLWdpdCBhL0NvbXBsZXRpb24vVW5peC9Db21tYW5kL19hbnQgYi9Db21wbGV0aW9uL1Vu aXgvQ29tbWFuZC9fYW50CmluZGV4IDkxNDI4Yjg1NC4uZTViZmU3Y2Y5IDEwMDY0NAotLS0gYS9D b21wbGV0aW9uL1VuaXgvQ29tbWFuZC9fYW50CisrKyBiL0NvbXBsZXRpb24vVW5peC9Db21tYW5k L19hbnQKQEAgLTYsNyArNiw4IEBAIGxvY2FsIGN1cmNvbnRleHQ9IiRjdXJjb250ZXh0IiBzdGF0 ZSBsaW5lIGV4cGwgcmV0PTEKIHR5cGVzZXQgLUEgb3B0X2FyZ3MKIGxvY2FsIGJ1aWxkZmlsZSBj bGFzc3BhdGggY3AgdXNlcmphcnMgaW1wb3J0ZWRmaWxlcyB0YXJnZXQ9Jyo6dGFyZ2V0Oi0+dGFy Z2V0JyB0YXJnZXRzIHRtcAogCi1maW5kX3RhcmdldHMoKSB7CisoKCAkK2Z1bmN0aW9uc1tfYW50 X3RhcmdldHNdICkpIHx8CitfYW50X3RhcmdldHMoKSB7CiAgICAgaW1wb3J0ZWRmaWxlcz0oICQo c2VkIC1uICJzLyAqPGltcG9ydFtePl0qIGZpbGU9W1wiJ11cKFteXCInXSpcKVtcIiddLiovXDEv cCIgPCAkMSkgKQogICAgICMgVHdlYWtlZCB0byBvbWl0IHRhcmdldHMgYmVnaW5uaW5nIHdpdGgg Ii0iIHRoYXQgY2FuJ3QKICAgICAjIGJlIGludm9rZWQgZnJvbSB0aGUgY29tbWFuZCBsaW5lOyBz ZWUgenNoLXdvcmtlcnMvMjQxMjkuCkBAIC0xNCwxMiArMTUsMTIgQEAgZmluZF90YXJnZXRzKCkg ewogICAgIGlmICgoICQjaW1wb3J0ZWRmaWxlcyApKSA7IHRoZW4KICAgICAgICAgKCBjZCAkMTpo CiAgICAgICAgICAgICBmb3IgZmlsZSBpbiAkaW1wb3J0ZWRmaWxlcyA7IGRvCi0gICAgICAgICAg ICAgICAgZXhwYW5kZWQ9KCAkKGVjaG8gJGZpbGUgfCBzZWQgLW4gInN8XCR7YW50LmhvbWV9fCRB TlRfSE9NRXxwIikgKQotICAgICAgICAgICAgICAgIGlmIFtbICEgImJsYSRleHBhbmRlZCIgPSAi YmxhIiBdXTsgdGhlbgorICAgICAgICAgICAgICAgIGV4cGFuZGVkPSR7ZmlsZS8vXCR7YW50Lmhv bWV9LyRBTlRfSE9NRX0KKyAgICAgICAgICAgICAgICBpZiBbWyAkZXhwYW5kZWQiICE9ICIkZmls ZSIgXV07IHRoZW4KICAgICAgICAgICAgICAgICAgICAgZmlsZT0kZXhwYW5kZWQKICAgICAgICAg ICAgICAgICBmaQogICAgICAgICAgICAgICAgIGlmIFtbIC1mICRmaWxlIF1dOyB0aGVuCi0gICAg ICAgICAgICAgICAgICAgIGZpbmRfdGFyZ2V0cyAkZmlsZQorICAgICAgICAgICAgICAgICAgICBf YW50X3RhcmdldHMgJGZpbGUKICAgICAgICAgICAgICAgICBmaQogICAgICAgICBkb25lICkKICAg ICBmaQpAQCAtMTM1LDcgKzEzNiw3IEBAIGNhc2UgJHN0YXRlIGluCiAgICAgICAgICkvLyQnXDAx NSd9IgogICAgICAgICBfZGVzY3JpYmUgJ3RhcmdldCcgdG1wICYmIHJldD0wCiAgICAgICBlbHNl Ci0gICAgICAgIHRhcmdldHM9KCAkKGZpbmRfdGFyZ2V0cyAkYnVpbGRmaWxlKSApCisgICAgICAg IHRhcmdldHM9KCAkKF9hbnRfdGFyZ2V0cyAkYnVpbGRmaWxlKSApCiAgICAgICAgIF93YW50ZWQg dGFyZ2V0cyBleHBsIHRhcmdldCBjb21wYWRkIC1hIHRhcmdldHMgJiYgcmV0PTAKICAgICAgIGZp CiAgICAgZWxzZQo= --000000000000b7486e060ba3df12--