zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: Bug report; git tab-completion on macOS within paths containing unicode characters
Date: Mon, 29 Apr 2024 18:57:09 -0700	[thread overview]
Message-ID: <CAH+w=7Z-jRzpXGnKY8JFKFjwcnDyFg02drCn316JZb4W0OL6qg@mail.gmail.com> (raw)
In-Reply-To: <1C935B84-003D-4822-A142-EC9DF817EA54@kba.biglobe.ne.jp>

On Mon, Apr 29, 2024 at 5:41 PM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> > 2024/04/30 2:54、Bart Schaefer <schaefer@brasslantern.com>のメール:
> >
> > On Mon, Apr 29, 2024 at 10:38 AM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
> >>
> >> In __git_files (called from __git_other_files), 'git ls-files'
> >> is called two times.
> >
> > Comments in the function indicate this is intentional:
>
> Yes, but the second call is just for "better than nothing",
> so the first call should better succeed, I think.

I don't think the first call ever succeeds on files that are not
already known to git, which makes it odd to call it for "git add" in
the first place.  I'm not sure what the intention was here.  Hence my
attempt to call out Daniel.

> I tried
> git ls-files $'/path/to/\xc3\xbc/test2'
> and
> git ls-files $'/path/to/u\xcc\x88/test2'
> but both didn't work. Isn't this a bug of git?

Neither of those worked for me either, even without NFD characters in
the file name, until I was cd'd inside the repository.

It appears that "git ls-files" has to find a .git/ before it will do
any comparisons, even given an absolute path to a(nother) repository.
I don't know whether to class this as a bug in git.


  reply	other threads:[~2024-04-30  1:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-26  7:17 Yves Delley
2024-04-27 19:14 ` Bart Schaefer
2024-04-27 19:31   ` Bart Schaefer
2024-04-28  7:22     ` Yves Delley
2024-04-28 15:28       ` Bart Schaefer
2024-04-28 18:59         ` Bart Schaefer
2024-04-28 19:01           ` Bart Schaefer
2024-04-29 17:37             ` Jun. T
2024-04-29 17:54               ` Bart Schaefer
2024-04-30  0:41                 ` Jun. T
2024-04-30  1:57                   ` Bart Schaefer [this message]
2024-04-30  2:31                     ` Jun. T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Z-jRzpXGnKY8JFKFjwcnDyFg02drCn316JZb4W0OL6qg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).