zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Jun T <takimoto-j@kba.biglobe.ne.jp>
Cc: zsh-workers@zsh.org
Subject: Re: problem with 'ls | less' shell function
Date: Sat, 22 Oct 2022 16:22:07 -0700	[thread overview]
Message-ID: <CAH+w=7Z-pVbnq69qffjCxNefKMu9gSwUDAKqmye89a_nkytrJw@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7bQcrjGLBw=Ayeks5rmO77Z5_ABkE1zGr=bXkhioRiixw@mail.gmail.com>

OK, perhaps we're getting somewhere.  Still working with suspend of
dir() { ls -lrRt | less }

In bin_fg(), line 2564, we
attachtty(jobtab[jobtab[job].other].gleader)) which is using the
correct PID.  We then enter waitjobs() which calls waitonejob() for
that PID (so far so good).  However, that returns immediately, because
at that point the pipeline gets SIGTTOU -- which is confusing, because
it should be attached to the tty.  In any case, waitjobs() then falls
through to waiting for the function subshell, which is the also the
right thing.

It's a bit hard to follow here because sometimes the "other" field of
the jobtab struct is an offset into jobtab, and sometimes its an
actual PID, but the parent shell's internal record-keeping seems to be
correct.  However, it must be the case that something is sending
SIGCONT to "less" before the attachtty() has a chance to ... actually
change the process group?  If I stop at the point where the SIGCONT is
sent, and call getprp() from the debugger, the process group still
belongs to the parent shell despite the apparently successful call to
attachtty().


  reply	other threads:[~2022-10-22 23:23 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-17  9:17 Thomas Klausner
2022-10-17 14:50 ` Mikael Magnusson
2022-10-17 15:36   ` Thomas Klausner
2022-10-19  8:26     ` zsugabubus
2022-10-19 10:04       ` Jun T
2022-10-19 13:36         ` Jun. T
2022-10-20  0:10       ` Bart Schaefer
2022-10-20 16:26         ` Peter Stephenson
2022-10-21  5:45       ` Jun T
2022-10-21  7:40         ` Jun T
2022-10-21 21:22           ` Bart Schaefer
2022-10-21 21:24             ` Bart Schaefer
2022-10-22 23:22               ` Bart Schaefer [this message]
2022-10-22 23:43                 ` Bart Schaefer
2022-11-03 23:10                   ` Bart Schaefer
2022-11-04  6:09                     ` [PATCH] " Bart Schaefer
2022-11-04 15:10                       ` [PATCH] " Jun T
2022-11-05  0:09                         ` Bart Schaefer
2022-11-06 19:12                           ` Bart Schaefer
2022-11-07  8:43                             ` Jun T
2022-11-07 19:33                               ` Bart Schaefer
2022-11-07 19:44                                 ` Roman Perepelitsa
2022-11-08  0:46                                   ` Bart Schaefer
2022-11-08  0:44                                 ` Bart Schaefer
2022-11-08  5:03                                   ` Bart Schaefer
2022-11-09  5:03                                     ` Bart Schaefer
2022-10-19  9:33 ` Jun T
2022-10-19 10:01   ` Jun T

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7Z-pVbnq69qffjCxNefKMu9gSwUDAKqmye89a_nkytrJw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).