zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] fix completion of parameter names for ${<TAB> and ${(a)<TAB>
Date: Sun, 31 Oct 2021 21:24:43 -0700	[thread overview]
Message-ID: <CAH+w=7ZBzC-675qFhmC8xeeMcqrj-Vq0wUCx8ZUaRVB1dyF+Yw@mail.gmail.com> (raw)
In-Reply-To: <DCDED98D-8CF9-4DD3-8CAD-2E82F8E1FBD4@kba.biglobe.ne.jp>

On Fri, Oct 29, 2021 at 11:47 PM Jun. T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> ${<TAB> works if '>=' is replaced by '>' at line 1192 of compcore.c
> (I think this is a simple off-by-one error).

That makes sense ... if the previous skipparens test was for <= this
on should be >.

> But ${(a)<TAB> still
> doesn't work. In the patch below I removed the lines 1203-1209
> (and the use of the variable 'tb' that is now redundant) to fix
> this problem.

Thanks.  I think those lines were intended as an optimization but I
probably tested it only with completeinword and the cursor somewhere
other than at the end.

> The original problem (worker/48788⁩) that is fixed by
> the above commit is not affected by this patch. I _hope_ there are
> no bad side effects.

I didn't find any.


      reply	other threads:[~2021-11-01  4:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-30  6:46 Jun. T
2021-11-01  4:24 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZBzC-675qFhmC8xeeMcqrj-Vq0wUCx8ZUaRVB1dyF+Yw@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=takimoto-j@kba.biglobe.ne.jp \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).