From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26623 invoked from network); 1 Nov 2021 04:25:32 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 1 Nov 2021 04:25:32 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1635740732; b=XP/SW6eqL/M0Ez9EXUBQUSkvKrGg15LDRiXm3w/uqlS/DehiGahjke4t+PrdBjmbyjj+u9ftp/ etE0OJ2OEw80TmFwd7Dp5P36hgWq1/3kMUOjaG+jKWyfLpenExjUYl2kCsvnnoaJesTCZNV+F9 LA0EfkWQxXsbp4kp2yoj2maauxbGsM28+egsKZjUoARJDtatikp1bY8vyGYUYPoQ/4pyFCkVGC Xd+5kffxT1ab+rYGJ10xxiS4waCL1NK55e6RqFP9pQYJyP2j/NN/6hzHTsM9r7nCC0ojiGlVvs F/CwO6E7OsD33bT4oF4kMh5UZRIPxGypt3DlCP3GDPV/yA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1635740732; bh=syHuzwQawOpy3Tkfb/Zd+Cd/pG7XQ9rz9K0XDPk1Ccg=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=jOTlAO1Rk/TY/Qoc5Vw3/wacmitL5JixPsbKHcWMYIIj1rN6oJsgT+0QeK7s5tO+ie+NJQKe26 e+Qrxw/nZqhJWP9Cal5XBLIBWDGO0Qjp5H2wdsLWM/9X++qYEkrX6GdkXp4m+wDiz3sH5DuWm9 tFJ3p07I6Gu4JlxyHiw1iFlg4ikNx6Ybs+RSxnr/NTAwqoaQZimdhxeztz++S/cCLr7KtUnAwb n2divn5jpZ+PowZNa/Pb4n5QSuNgIZlhekCrigk/iMEkVrji+CV6mqymVn1m/gz+xk4kHckB+w Ktk7z1UGItrSTSXeOBWVZaS9uFlEEqGT8icUxKT+jFEsGg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=Xm3veoEn7Q4vDGuQPq8jde/cJEAzRJKsOsMIreA1Z2U=; b=QKDO9FTsAN3SUYN8KBIVnMXic2 24wKA2MLmD+IMk5vQ6ja4Wl+hK7lW34su9xFPbPkKW4sdIeZEmkKEin7Ad29xHtma5/ZfVyMYX/Z/ csqKMO6xZtu6fzycVjNlplfBRv/pyoNLUj6QnXR2W/Ax+HGt6Eff4WO74PE4RplxtpV5kXPvLpVZ4 UhRTUAgmOpE71uOJlfgz6vs6VqGUPhpJvta0jroevfkomnfI/aZ3183GTWapk5Lc2H/l3nsLcpF9v wBAfQBTb5tDkxALamy4HgMuC45Hvys+prbr7UOST+UOzwVUIzaSb0zSzuKRSvgCa5bLxS2HZoagFt ZK71HAFg==; Received: from authenticated user by zero.zsh.org with local id 1mhOt0-000KUl-Df; Mon, 01 Nov 2021 04:25:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f171.google.com) smtp.remote-ip=209.85.219.171; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f171.google.com ([209.85.219.171]:34783) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1mhOsR-000KD4-J2; Mon, 01 Nov 2021 04:24:56 +0000 Received: by mail-yb1-f171.google.com with SMTP id o12so41579606ybk.1 for ; Sun, 31 Oct 2021 21:24:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=Xm3veoEn7Q4vDGuQPq8jde/cJEAzRJKsOsMIreA1Z2U=; b=vbRetdDCpAvhCKzpO8X/pKxYBIkKwSnhEGrwulpuweUAg8W/gXlNhVwtBmHPj56BaM ExSglj65cDBT0A/pqwtP3UIfChS2BNuZt6riDyfhjJO5+vVpaGQcCLynAdmHqADBjMZa BWM9n/CKoMoMOuyRLRWAufOikK9+MNf9zIipcr4zr8FRh9f4ho1LHrKyIAvXektkPGfu re9x6V5ZHasQukrg165Irh4MHllTb8ltYaZsRLgViRFsfAjq6Qm38wfZeM3KR0bhRkyu 83z+fA4buv3bBqRx5dCH4uWNlJbXZRClkFcLQVGMxdDizulw3c9hvXmok1lRihZghH9J 3YHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Xm3veoEn7Q4vDGuQPq8jde/cJEAzRJKsOsMIreA1Z2U=; b=h2JvP31vSPl0UxMJgtW8DYkwpRNcG5a7G1UNYigjrLYQhdKZ69iIAOh013pcNnrrgV F8LZi70hv6vEpHMRFxsiqNi5wPkZTzGK8ztAHCzfujH3txcMS+P3tOy4xHOaSCTU67xk Zbbfp3hDBwnuY3mkw2pyBG6G1moCY6Y5lb6ivGDAnbyvxtjKEvJjKubZBEU9Z/QfZHwo u+8RUUV2PQZm6yZUTzLkp5QtVdh7F9l0cLItWWZ/3AjxVNBeqPfD01OSnHozcI3xJni8 228KzhCc0XOm7Kh0mUFlkZEdHMgtt2H1ZSXD1Kxged+5B+A27YsIIh9cEdwT2MDSiApP OS+Q== X-Gm-Message-State: AOAM531KZx1dmADj6x+20V4wJmgzu+yCFkHc5KdVXoKdn5R7cO4ITWza wWhJoIhvHOW9Cxzlh9BfJthZ3LBsjO9PRY4Q6NIYogKdZalo1Q== X-Google-Smtp-Source: ABdhPJwpH1x+kN0Z7GqAxghAKXZgDh7XYrhLhsDW9H5I1vt83Ao8JLtihjFPwg7I5qV7l3p5bDTLvwkuN+xzqdSFAf8= X-Received: by 2002:a25:1102:: with SMTP id 2mr30358772ybr.266.1635740694206; Sun, 31 Oct 2021 21:24:54 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sun, 31 Oct 2021 21:24:43 -0700 Message-ID: Subject: Re: [PATCH] fix completion of parameter names for ${ and ${(a) To: "Jun. T" Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 49541 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Fri, Oct 29, 2021 at 11:47 PM Jun. T wrot= e: > > ${ works if '>=3D' is replaced by '>' at line 1192 of compcore.c > (I think this is a simple off-by-one error). That makes sense ... if the previous skipparens test was for <=3D this on should be >. > But ${(a) still > doesn't work. In the patch below I removed the lines 1203-1209 > (and the use of the variable 'tb' that is now redundant) to fix > this problem. Thanks. I think those lines were intended as an optimization but I probably tested it only with completeinword and the cursor somewhere other than at the end. > The original problem (worker/48788=E2=81=A9) that is fixed by > the above commit is not affected by this patch. I _hope_ there are > no bad side effects. I didn't find any.