zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Bug in completion with curly braces?
Date: Sun, 22 Nov 2020 23:15:30 -0800	[thread overview]
Message-ID: <CAH+w=7ZCjRdyRXUQqGVkJSdoFvm0sm=oKtBj-pWz+kX2LLAtJg@mail.gmail.com> (raw)
In-Reply-To: <20201123030359.GA9114@tarpaulin.shahaf.local2>

On Sun, Nov 22, 2020 at 7:04 PM Daniel Shahaf <d.s@daniel.shahaf.name> wrote:
>
> Bart Schaefer wrote on Sun, Nov 22, 2020 at 12:35:52 -0800:
> > 1)  _comp_options includes "NO_ignorebraces" so isset(IGNOREBRACES) is
> > never true in zle_tricky.c:get_comp_string

This turns out to be wrong.  get_comp_string is called before
_comp_options is applied.

It's possible the whole problem comes down to the backslash improperly
added to $PREFIX.

> In z-sy-h we solved this by declaring an assoc parameter and setting it
> to the value of $options (or emulating that if zsh/parameter is
> unavailable for some reason).

This role is filled by $_comp_caller_options, which should be getting
set on entry to the completion system (via eval $_comp_setup).


  reply	other threads:[~2020-11-23  7:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-20  1:50 Felipe Contreras
2020-11-20  2:52 ` Mikael Magnusson
2020-11-21 15:28 ` Daniel Shahaf
2020-11-21 21:08   ` Felipe Contreras
2020-11-21 22:32     ` Bart Schaefer
2020-11-22  0:37       ` Felipe Contreras
2020-11-22  2:28         ` Bart Schaefer
2020-11-22  2:58           ` Felipe Contreras
2020-11-22 20:35             ` Bart Schaefer
2020-11-22 21:20               ` Bart Schaefer
2020-11-23  3:03               ` Daniel Shahaf
2020-11-23  7:15                 ` Bart Schaefer [this message]
2020-11-23  6:46               ` Felipe Contreras
2020-11-23  7:17                 ` Bart Schaefer
2021-04-18 21:43                   ` Bart Schaefer
2020-11-23 17:31                 ` Bart Schaefer
2020-11-24 23:21                   ` Oliver Kiddle
2020-11-25  5:06                     ` Felipe Contreras
2021-12-02 19:45                       ` PATCH: bashcompinit quoting (was Re: Bug in completion with curly braces?) Oliver Kiddle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZCjRdyRXUQqGVkJSdoFvm0sm=oKtBj-pWz+kX2LLAtJg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).