From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26991 invoked by alias); 29 Sep 2017 15:22:25 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41790 Received: (qmail 29662 invoked by uid 1010); 29 Sep 2017 15:22:25 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f169.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.169):SA:0(-1.4/5.0):. Processed in 4.243693 secs); 29 Sep 2017 15:22:25 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=eTLenDFFS+qB7/YEAUh0m/41po5PYxbjCvhsuRN7tnA=; b=LX8rS6GREvUNPSqRadQYbH4ZGRpLwRg0iUxzZioDATCp8zr0oMB6jCq0AdpzWK7v9i QKicBlBE6kzV9SnziJRpYg/jscwKmTu4wh8F6gh65yH03hNoK8HA1FPouef0rQxma8uN zmYYLSrGUSr1ZPOks5plh/rDXIuYueWaSPitRynI76wl/L3+aKn4JijT3mXXZX4LIeew OrflzvX0LAzMgnjikvyU9HTKGxRLBb2Cn5dNcrdLvuvDj2rqFUVti+H4eaA+jo8Y7w/R S/kflvI6dGFv4qjxcLlXWpHQ1hZgsGRQPIhXQ58oGuB2mYJMKbxc9iCGYR/LUQs2QNQh WOWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=eTLenDFFS+qB7/YEAUh0m/41po5PYxbjCvhsuRN7tnA=; b=rCG8xuhNJStNeKsMfbEoxinFsGSkEwOh3W2DMC9fT/TE4/giKNKnN1YfvsEaYZdQgD 3KJL7Kwsbv8HcE6jbxEap1yFiwx2r/tTAXL3h5l/pfMkcb5zE5YCmwNTeO3exfsZCOP/ 6mYOvrMtGJmU5JtrtWIXY8QQt3IZW3SsClJ0jfJSG/vZCO4zdgoxomx/HZGKFy0NnqdB KJzS72RlWLflv0SFeEuQPZOagcaUBroAHlAdBNKHBqeZ/nyy44EHRSeYwyuPqJOqjbqE T3CU93NdvmnpC3jv0eYyvFBTXvYlVgiVD4oeRB6cUiBWDirlCzs3J325DHtQ1/M7EbQf P7rg== X-Gm-Message-State: AMCzsaUyrv4W9dze1agO96G80f/1p99z0+oSh41EOxGWHhKK4ydU4SQs 2SH8ZTWdzZ4Kw0CquxBP/0BmoVQP+bB76pevEA7rTg== X-Google-Smtp-Source: AOwi7QCSXs7HXrlDZiy7nUPDa0UPizmdcl/5Af4S6KxOeAa6wz8LaMY1YzsiIk/WWrq8vk/Cr47CPoa3YsKZw1/ZhPw= X-Received: by 10.237.37.231 with SMTP id y36mr6628446qtc.199.1506698537745; Fri, 29 Sep 2017 08:22:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170929151614.56fd9cff@pwslap01u.europe.root.pri> References: <20170929121008.3da15b34@pwslap01u.europe.root.pri> <4913136.yYypKkW7sH@kdudka-nb> <20170929151614.56fd9cff@pwslap01u.europe.root.pri> From: Bart Schaefer Date: Fri, 29 Sep 2017 08:22:16 -0700 Message-ID: Subject: Re: Crash when completion script call itself. To: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" On Fri, Sep 29, 2017 at 7:16 AM, Peter Stephenson wrote: > This is the proposed change. I think the compromise of reducing the > value but making it more easily configurable is probably a good one. It > currently makes the new variable appear in all emulations, but I can > change that. Philosophically speaking, the value of 1000 for max depth was also based on user experience, and one might expect that most environments now have more stack space available than they did many years ago when 1000 was chosen. So reducing this value might make it more likely that people will encounter the "depth exceeded" error. At the least the error message should be updated to mention increasing FUNCNEST ? With respect to the #ifdefs, I think entirely removing FUNCNEST is a bad idea -- it should remain so that its value can be examined. We could go so far as to mark it readonly if preventing it from being reset is the intention. I guess that affects whether the shell keeps track of the current depth, too, but that doesn't seem like much overhead.