From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.stephenson@samsung.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: PATCH: job control debug
Date: Thu, 6 Sep 2018 20:18:14 -0700 [thread overview]
Message-ID: <CAH+w=7ZH1d8RZaHNVhb2k+RqBb_8kgxDurewtk1a6TWG9Vvh5Q@mail.gmail.com> (raw)
In-Reply-To: <20180906092250eucas1p13d651e07ae627d179dd0701e65f912d6~RxTLztJrP2263722637eucas1p12@eucas1p1.samsung.com>
On Thu, Sep 6, 2018 at 2:22 AM, Peter Stephenson
<p.stephenson@samsung.com> wrote:
> Typo fixed, now with setpgrp debugging.
>
> Starting to think the key difference may be set_gleader(11) --- transfer
> of job ownership on exit, which happens too early for that to be
> possible in the bad case.
I don't think that can be it, at least not directly. set_gleader()
only updates internal data structures. Something has to be either
changing the tty process group too soon, or not soon enough, in order
for a TTOU signal to be sent. The other possibility is that in the
"good" case the TTOU is sent but the process is ignoring it, whereas
in the bad case the process is allowing it. You may need to add some
debugging for that.
In particular entersubsh() does some juggling of SIGTTOU -- which I
think predates this bug appearing, but there may be an interaction of
that with some later change.
next prev parent reply other threads:[~2018-09-07 3:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20180905200816epcas5p18ce6c49baa637e7d83a769e97c4364fb@epcas5p1.samsung.com>
2018-09-05 20:07 ` Peter Stephenson
2018-09-06 8:09 ` Peter Stephenson
[not found] ` <20180906090902.1f344e9f@camnpupstephen.cam.scsc.local>
2018-09-06 9:22 ` Peter Stephenson
2018-09-07 3:18 ` Bart Schaefer [this message]
2018-09-07 9:18 ` Peter Stephenson
[not found] ` <20180907101852.62415ff9@camnpupstephen.cam.scsc.local>
2018-09-07 11:21 ` Peter Stephenson
[not found] ` <20180907122145.2af5bcba@camnpupstephen.cam.scsc.local>
2018-09-07 14:01 ` PATCH: Rimmerworld pipeline race Peter Stephenson
[not found] ` <20180907150140.46a05880@camnpupstephen.cam.scsc.local>
2018-09-07 14:58 ` Peter Stephenson
2018-09-07 16:46 ` Peter Stephenson
2018-09-07 23:40 ` Bart Schaefer
2018-09-08 17:37 ` Peter Stephenson
2018-09-08 18:40 ` Peter Stephenson
2018-09-10 22:55 ` Axel Beckert
2018-09-11 8:58 ` Peter Stephenson
2018-09-11 14:40 ` Vincent Lefevre
2018-09-11 15:03 ` Peter Stephenson
[not found] ` <20180911160326.33dfd575@camnpupstephen.cam.scsc.local>
2018-09-11 15:32 ` Peter Stephenson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZH1d8RZaHNVhb2k+RqBb_8kgxDurewtk1a6TWG9Vvh5Q@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=p.stephenson@samsung.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).