zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Marlon Richert <marlon.richert@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Proposal: Let compinit make standard widgets with _generic instead of _main_complete
Date: Sat, 20 Mar 2021 16:52:55 -0700	[thread overview]
Message-ID: <CAH+w=7ZL+soLWYiKUb1Ej20WHbs7johzVWJ+qEvevLP5tK_Z4w@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7b4b-FBVbrZ4SWSiqxP4OcuLmzQWjqZ39c6Q-WZzPq60Q@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1035 bytes --]

On Sat, Mar 20, 2021 at 11:09 AM Bart Schaefer <schaefer@brasslantern.com>
wrote:

>
> A potential issue with this is that it introduces a difference for
> other wrapper widgets that assume _main_complete is THE completion
> entry point.
>

How about this?  It introduces a generic-widgets style, a list of widget
names that _main_complete hands off to _generic (which changes the context
and hands them back).

diff --git a/Completion/Base/Core/_main_complete
b/Completion/Base/Core/_main_complete
index 169ca1f40..62d94e3ae 100644
--- a/Completion/Base/Core/_main_complete
+++ b/Completion/Base/Core/_main_complete
@@ -10,6 +10,14 @@
 # In case non-standard separators are in use.
 local IFS=$' \t\n\0'

+# Test generic-widgets only in global context to avoid recursion
+if [[ "${curcontext:-:::}" == ::: ]] &&
+   zstyle -t ":completion:::::" generic-widgets "$WIDGET"
+then
+    _generic "$@"
+    return
+fi
+
 # If you want to complete only set or unset options for the unsetopt
 # and setopt builtin, un-comment these lines:
 #

[-- Attachment #2: Type: text/html, Size: 1488 bytes --]

  reply	other threads:[~2021-03-20 23:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-19 22:23 Marlon Richert
2021-03-20 18:09 ` Bart Schaefer
2021-03-20 23:52   ` Bart Schaefer [this message]
2021-03-21 15:19     ` Marlon Richert
2021-03-22  1:46       ` Bart Schaefer
2021-03-22  7:16         ` Marlon Richert
2021-04-03 19:37           ` Lawrence Velázquez
2021-04-04 18:35           ` Bart Schaefer
2021-04-04 19:31             ` Bart Schaefer
2021-04-09 19:11             ` Oliver Kiddle
2021-04-09 19:35               ` Bart Schaefer
2021-05-09 20:51                 ` Lawrence Velázquez
2021-05-10 17:11                   ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZL+soLWYiKUb1Ej20WHbs7johzVWJ+qEvevLP5tK_Z4w@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=marlon.richert@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).