From: Bart Schaefer <schaefer@brasslantern.com>
To: Philippe Altherr <philippe.altherr@gmail.com>
Cc: "Zsh hackers list" <zsh-workers@zsh.org>,
"Lawrence Velázquez" <larryv@zsh.org>
Subject: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements
Date: Sun, 20 Nov 2022 16:43:12 -0800 [thread overview]
Message-ID: <CAH+w=7ZLr8R_pQfpcAdHiNyYH0K_A8ha815nz1zPBakYmCJ6Dg@mail.gmail.com> (raw)
In-Reply-To: <CAGdYchufLwUgpKVU6b5eOiF15p0njFr59H1q9XizypwNjzqKzw@mail.gmail.com>
On Sat, Nov 19, 2022 at 5:39 AM Philippe Altherr
<philippe.altherr@gmail.com> wrote:
>
> I recommend submitting the 4 patches attached here.
Thanks again. I'm generally more pleased with this set of patches
because the number of places you had to save/restore this_noerrexit in
the previous go-round seemed intuitively wrong to me.
Each time though, you've removed the NEWS item. Although we've
established that the behavior it describes was not actually
appropriate, there still has been a change in ERR_EXIT behavior that
probably warrants a mention. What's the best description of that?
Question for the wider list: With this patch, anonymous functions
behave like functions with respect to ERR_EXIT. This is reasonable,
but it does mean that
set -e
{ { false && true } } # does not exit
() { { false && true } } # exits
Are we all OK with this, and either way does it need to be called out
somewhere? For the record (and per my above remark about NEWS) the
previous behavior was that neither of these would exit. Frankly I'm
still not certain that the extra level of { } should matter in the
function example.
next prev parent reply other threads:[~2022-11-21 0:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 14:40 Philippe Altherr
2022-11-19 13:39 ` Philippe Altherr
2022-11-21 0:43 ` Bart Schaefer [this message]
2022-11-21 7:22 ` Lawrence Velázquez
2022-11-22 2:52 ` Philippe Altherr
2022-11-22 4:51 ` Bart Schaefer
2022-11-22 10:17 ` Peter Stephenson
2022-11-23 8:11 ` Lawrence Velázquez
2022-11-23 6:59 ` Lawrence Velázquez
2022-11-23 9:43 ` Philippe Altherr
2022-11-23 16:11 ` Bart Schaefer
2022-11-23 20:57 ` Submitting multiple patches (was: Re: [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements) Daniel Shahaf
2022-11-23 21:11 ` Bart Schaefer
2022-11-23 21:22 ` Bart Schaefer
2022-11-23 21:54 ` Bart Schaefer
2022-11-24 2:21 ` Philippe Altherr
2022-11-26 2:28 ` Bart Schaefer
2022-11-26 4:02 ` Philippe Altherr
2022-11-24 1:47 ` [PATCH] Fix ERR_EXIT behavior in function calls and "always" statements Philippe Altherr
2022-11-24 4:28 ` Lawrence Velázquez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZLr8R_pQfpcAdHiNyYH0K_A8ha815nz1zPBakYmCJ6Dg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=larryv@zsh.org \
--cc=philippe.altherr@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).