From: Bart Schaefer <schaefer@brasslantern.com>
To: Clinton Bunch <cdb_zsh@zentaur.org>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH] zsh/random module
Date: Thu, 3 Nov 2022 10:50:50 -0700 [thread overview]
Message-ID: <CAH+w=7ZMsco03M4+hbWUsURJ8na-EMiC8RzSEvOB7Q1_o9=0iQ@mail.gmail.com> (raw)
In-Reply-To: <741b77be-b679-76cc-f8ec-49c9d89323c1@zentaur.org>
On Wed, Nov 2, 2022 at 10:14 AM Clinton Bunch <cdb_zsh@zentaur.org> wrote:
>
> I'd appreciate if someone would test it on a few other platforms and try
> to break it. I tried everything I could think of, but...
Seems to work on MacOS Catalina. If you add a Test/ file for "make
check" we'll get more coverage.
Documentation suggestions:
-s SCALAR
Save the random data in SCALAR instead of printing it. Only
useful in string mode or when LENGTH is 1.
Actually say that this is an error for -i with length > 1, rather than
just "Only useful when". Avoids use of the undefined term "string
mode" and better describes the behavior. I wonder if using both -i
and -s should default length to 1 rather than 8 ... otherwise you
should state that you can't use them together without also using -l.
I'd have put -L before -U but I suppose you expect -U to be used more
frequently.
next prev parent reply other threads:[~2022-11-03 17:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 17:13 Clinton Bunch
2022-11-03 17:50 ` Bart Schaefer [this message]
2022-11-04 3:17 ` dana
2022-11-04 6:22 ` Clinton Bunch
2022-11-04 7:27 ` dana
2022-11-04 12:57 ` Clinton Bunch
2022-11-08 0:18 ` [PATCH] zsh/random module [UPDATED] Clinton Bunch
2022-11-18 14:30 ` Clinton Bunch
2022-11-19 6:42 ` Lawrence Velázquez
2022-11-18 16:23 ` Stephane Chazelas
2022-11-18 17:08 ` Clinton Bunch
2022-11-18 18:12 ` Stephane Chazelas
2022-11-18 18:38 ` Clinton Bunch
2022-11-23 19:52 ` Daniel Shahaf
2022-11-24 16:19 ` Stephane Chazelas
2022-11-24 16:30 ` Roman Perepelitsa
2022-11-24 22:39 ` Clinton Bunch
2022-11-25 8:53 ` Stephane Chazelas
2022-11-25 9:40 ` Stephane Chazelas
2022-11-28 16:37 ` further discussion of zsh/random (was [PATCH] zsh/random module [UPDATED]) Clinton Bunch
2022-11-21 1:07 ` [PATCH] zsh/random module [UPDATED] Matthew Martin
2022-11-21 1:59 ` Clinton Bunch
2022-11-21 2:21 ` Matthew Martin
2022-11-21 2:57 ` Clinton Bunch
2022-11-21 3:14 ` Lawrence Velázquez
2022-11-21 4:17 ` Bart Schaefer
2022-11-21 5:05 ` Clinton Bunch
2022-11-22 13:42 ` dana
2022-11-23 19:49 ` Daniel Shahaf
2022-11-22 17:44 ` Oliver Kiddle
2022-11-22 19:48 ` Clinton Bunch
2022-11-23 1:23 ` Matthew Martin
2022-11-23 2:58 ` Clinton Bunch
2022-11-23 4:14 ` Matthew Martin
2022-11-23 13:41 ` Clinton Bunch
2022-11-23 20:33 ` Daniel Shahaf
2022-11-23 21:42 ` dana
2022-11-23 23:54 ` Daniel Shahaf
2022-11-24 0:17 ` Daniel Shahaf
2022-11-24 1:05 ` dana
2022-11-24 13:52 ` Clinton Bunch
2022-11-23 19:46 ` Daniel Shahaf
2022-11-24 2:58 ` Clinton Bunch
2022-11-24 10:07 ` nimaje+zml
2022-11-24 13:19 ` Clinton Bunch
2022-11-24 14:33 ` Clinton Bunch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZMsco03M4+hbWUsURJ8na-EMiC8RzSEvOB7Q1_o9=0iQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=cdb_zsh@zentaur.org \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).