From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5704 invoked from network); 3 Nov 2022 17:51:43 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 3 Nov 2022 17:51:43 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1667497903; b=DbQYrbutVx2Xpu07vPOvoRG8b/THT7C0sXZ6RrrprTTYvt/migc4QqWbD13HOBeCaXEnvqM1aw bpsr6U5hpoD/FBlw9RnaTzHx5l8slNy2cshyDMBFET5C8MoQ4K1HbnP27OWjkILEQ50fXPaS47 BNNIOCyepVGVJO/Iok/gY9BfKtslSk1ABS/+k0vivccLAjJITd28MzpH49e0zdJg4S1YUnyTDT FJ8yTEkvQ4UiyosdYmvBqDtW9oennGrYG3sRLaWpIoGKqjiX+6afpHDWRrdG0IAuihlTBjJEwJ 91csKvatDd6F8f+BWdtthgzFUPz+bAM1GXSVW1ZcIcqJTw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f53.google.com) smtp.remote-ip=209.85.218.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1667497903; bh=HBilde0QIkF0oZJj1nz5RMN8EfdiokC6S9gaKw9CP7s=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=fXFNy7EMmD7BOdTLPChYC/5sTpn/mnXrLJn5G5NhedQP1kYhckU2FU057PJ+J0xaAxb/2bDAnK zt2SfXtgXeGrDqmoBc6GfiamiOt/zzooJ1N6wwYfbTVtGA9Hk17fpGT4wDhujpiGLdgUlnnJEM v8tfuWr0VzzfSHpn8kJ+AayuQlXZIBF1wbIK1uhvBAya0lPI6CMTOQ/00zfocdheV9M9wQ+SUr Gp9H7MWgbLCG+p1Q1ZEGRAzUGnfsV7sW43/iRuna+/2qJpUHBX5sKKWyE9BIBf9b0/W6lV/3yf dJYfm8CpFuhDfywGLDki2H6r/AxkyX+W6YFVnUZiqhomHA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=a1dMoLhqjy9SnH9wCQ3aqw1+1GhpEZx/f9by+n1sjcQ=; b=O6smj5MoRIRvZLXsuhoXQ6H9wN Y4sUpa3XIFaLpLx7eGIMx1bh1dwMLeXJr/1Ls53AON9pck0wRoS8pdtWLY1tgjQvpmARuHUG17j2t i7Ervnio3OILw8hcLobh0flM1mafo5mnnRdnPpTZfQ15zKxen3Z+7xCL1IbV4UVR8EWZcPKC+LhsA 1yPXAYqnH+QqBA+JFo/CZ3cUJXakJM8NiaEPoYd4mNgVRGxU+bsC/V0gxU7Jv2t7eAd0Yw2odSm5v 4NX1/91dw8RVe57XeG+c5+eI0iTkL9n1estyN8Wwx26bNl15Rd2wDQuH+q8AabN3vJo4M5VlhCpFt wgJI/LPg==; Received: by zero.zsh.org with local id 1oqeNR-000Fhd-8X; Thu, 03 Nov 2022 17:51:41 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f53.google.com) smtp.remote-ip=209.85.218.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f53.google.com ([209.85.218.53]:42843) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1oqeMo-000FNP-QI; Thu, 03 Nov 2022 17:51:03 +0000 Received: by mail-ej1-f53.google.com with SMTP id y14so7321791ejd.9 for ; Thu, 03 Nov 2022 10:51:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=a1dMoLhqjy9SnH9wCQ3aqw1+1GhpEZx/f9by+n1sjcQ=; b=qsG+b07SSmVU8cKuAT566eZIeJGLNL9JLHwiNy0KrtIL+asglgrpDqsccIfN1Tp61o cWrhp81XHyoe10MDG7paWIjdcBY6p19ND0orYaTJqogZihW7RE1vLn3xPuFxNEN7tqKK f8fFc0T/71GkOg0ePdlHIe9oG0vtVTNI1reGBlnGfluYC1vvyEWd9nWT7VFagBpn00Ea KGn58DQ74GutfukXR/xzsrYiANwxZUZjNbXbmREUAns+Yc2NwWvoASIa9y3hhXq2KrvE 9ne6W+5/v4wUqxjd1XWLv92f6v1QOvqxAIbLgwcTsMKwLFlHb6Hk4PcQ3/ZG8Zl0vqEh deLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=a1dMoLhqjy9SnH9wCQ3aqw1+1GhpEZx/f9by+n1sjcQ=; b=bQQj1oH6FoP1jgQuN5VsO9hvnNtoYJYACPlj4ELzQGemnbxEyxwj6ruV+62mAlUDCY UvKcfh5e6w9Od+0+JSaEWhumY5Cbs8RmmXzbNQOLMEso5STam2Puaat6mQccb46kqZbJ mpwjfX6OicIoyxeZe3GhoPdwv4uAv/nmD17+Yqd0iIKQKRID2PjtgbLFs3+O6kmctWr7 b9f3eBVj7gH5lAXSZQU2zxPIFubwRbLolSOH4Lt11SnK+Oo3NtawiQMrVKjco1l/h9vB Q3PrWnRp3NcWMGHskrMvbwiktUq7WEtMAUeNDfkfPyz7KT2/H0oQMJ3tFe4XEAAv7ZzP EKng== X-Gm-Message-State: ACrzQf0KmaF7+BGQRJcJXqn9mfw74S+9Mmo9r9dz0Gx/wcmpamiIsFZA Pnl8zZgFibNGCspwuwERNGVAQHHi3XfEn1L1hJST/r16DBMaBQ== X-Google-Smtp-Source: AMsMyM4PaNX2K8ygVTlXQ75ptBgqrHdyV1wqqw/QbzsZiUbJo+Vcn6BxbDYu2sy+WLJDVoTiKpJqy3JINhuS9780c6w= X-Received: by 2002:a17:906:58c7:b0:722:f4bf:cb75 with SMTP id e7-20020a17090658c700b00722f4bfcb75mr29783747ejs.450.1667497861838; Thu, 03 Nov 2022 10:51:01 -0700 (PDT) MIME-Version: 1.0 References: <741b77be-b679-76cc-f8ec-49c9d89323c1@zentaur.org> In-Reply-To: <741b77be-b679-76cc-f8ec-49c9d89323c1@zentaur.org> From: Bart Schaefer Date: Thu, 3 Nov 2022 10:50:50 -0700 Message-ID: Subject: Re: [PATCH] zsh/random module To: Clinton Bunch Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" X-Seq: 50859 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Wed, Nov 2, 2022 at 10:14 AM Clinton Bunch wrote: > > I'd appreciate if someone would test it on a few other platforms and try > to break it. I tried everything I could think of, but... Seems to work on MacOS Catalina. If you add a Test/ file for "make check" we'll get more coverage. Documentation suggestions: -s SCALAR Save the random data in SCALAR instead of printing it. Only useful in string mode or when LENGTH is 1. Actually say that this is an error for -i with length > 1, rather than just "Only useful when". Avoids use of the undefined term "string mode" and better describes the behavior. I wonder if using both -i and -s should default length to 1 rather than 8 ... otherwise you should state that you can't use them together without also using -l. I'd have put -L before -U but I suppose you expect -U to be used more frequently.