From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 22623 invoked from network); 17 Mar 2022 19:18:14 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Mar 2022 19:18:14 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1647544694; b=VfA8Pni4DGNljPP9kvxiAwgJy8iw9WsjWJkQIzmNjzA+DtykGLJqZgQVL9rPHr5FxJu6JuHngh f5Lo+Ip/M1vRKUvYFZMr6ZtPSPwPDAGvJFiX+P7o8HS55ymJ2r0T76W4eqQKFsEcRqFQau/LEQ gv/jzxm6mSGpWeWbWC40KDseWcLdUNjq17JDohGx0ukSrrpyjHeLuVVdraV55/PWKlBwFHC+Kb HTgE8prdKJzn4De35BgExdqZ5mcu+kAFo1ViLFZqx9eYyhdvWVZLduAIwGhLwB2+L8bNW3WxnY HHlRJtNStO8kpv5csmoixe90XvG6aphaq6YQseuERXbXTQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-yb1-f175.google.com) smtp.remote-ip=209.85.219.175; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1647544694; bh=7nCppNUmg8qZoUUIH41qKc7XMDPmXdCAFy4vceQWNr0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=LY0RMPfzqAvj4djb/ESwR2CiYNqEKyAxpjNCDqg+evIe52JKTZplg7f1qiHEkIjqO0ueqDO3U2 TR9yND+XfiXnNbrYMZKmrldEB5Hz8WvVY4N5qxOWVLM4AA1Qb1No7SSg7tGmFaTMEa8bcRgUis X455Ik6oxQ7Arkg/NWHPk4DgMIL8V08af/4H7nKCfnD6cB3o2xX0EsEboeALuuIbuRKN4UZzMQ CsRsudAiZaEeMEjPhT62YpLwTAjReJDaHVeGNL6+JLUX6b4i9R4GA6rwAAZ/jcvF9/+BpR7lje pkdfEsLLa8w5OaWkzl8GuNxwbAICXojy/wEZs2pF41JgZQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=dtLBQx0zYWPdPeMtzuFLVdWUTF0gjYzW31JojwF+NgE=; b=kkJbdeU9FoUqf/aJ467lBJdqin xfzL6QbvOOQYifNnhpQMTeOhTvSHtIeMyydR9LD48i9jf1l6X3AIs9ux+fBegICmEKlRzWAHg0j0Q XFMrjZ6G2cnbt0PmtaSOx3Qnx9tjkgfXIQ6UCDW9pb+9fct5iTDnHNVn8sjpu/sxoc3zeUqh1lOjt EqBzG5IXKcIF0fdA13zdwy2vDi5oCrffXn2p/zvmirZlBZ4QqKemYugAEYuuKEqdaOniiqnbqJQvR 2+wYfpocOEbYS7VtAKsKCk9egBxARTgwLhWxmVVnUupqFHkvRHNcqHGmB9amMIDupQGh4tuy2+yde k8VJ9Y8A==; Received: from authenticated user by zero.zsh.org with local id 1nUvdV-0003BB-Im; Thu, 17 Mar 2022 19:18:13 +0000 Authentication-Results: zsh.org; iprev=pass (mail-yb1-f175.google.com) smtp.remote-ip=209.85.219.175; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-yb1-f175.google.com ([209.85.219.175]:35533) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nUvdC-0002oz-1f; Thu, 17 Mar 2022 19:17:54 +0000 Received: by mail-yb1-f175.google.com with SMTP id o5so12075356ybe.2 for ; Thu, 17 Mar 2022 12:17:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dtLBQx0zYWPdPeMtzuFLVdWUTF0gjYzW31JojwF+NgE=; b=ZPpXGF8nf4oI9/f+aGC3ftwPNr+yM4J77aZeLgGA7zL6er9CiFJ84ats31vER9qdmO wnzO9uHuFq9y5NxJvY2rqH2+3lUMQxyLOwgC7Oq9RlvIRIV5k/YZnbpPjvi8xmYnGUjh 2ogvJlIXPTTTxEb2cw/giLE+4MaqCIZDFUmuNHzm87bIoExk5USlfvQxjXGmhYfyBJqP tPIapGY0A5rVAPAYj4ct6ErOAlYGWFOYSACEqOuHvA84QRHBQ+kdEUQ6Gqec7eq8tSOA bwgI4ArQw7S7obiFLH2mOUeUm1f55wrEfK2DRdyrFf8+G2RB0mI16AW482MBjiINy1HY MBJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dtLBQx0zYWPdPeMtzuFLVdWUTF0gjYzW31JojwF+NgE=; b=Pa0ly39gvYb0n3tkBa9mhZoVgP80ASAtUXNrpCPfvUUawmT4YAGaqsWLi8q9HVsEas sprMleAyycdLzgCNDpork6UgRenL67yYmO8aBVjT6l7p4tyVIU/Xx+hQN3tCecJJA1kr oaX82yTsyK6KwtvduZVG+gdtEfseYnA9Bq5KceqFD9OLa/crL+WukeqtOesbmySAaFVP gJ39QwLiJFsKLSqTj1qOBgxW7epyOuOc9vDpW7KWVIk3xnkr2QdX1sqVS1yNwZeGVv71 rX76wJoZg2L8OLplcIRa92scRB14IT9nOFIc4YFrZM4sox56X7wRqsWilHfQk3bLsUUh dlfw== X-Gm-Message-State: AOAM531f3pUIlSX7MIuHSMoiZmZqeuFOGq+5qABtYq4XWYg8DELEPgXo BY1hQ2BmEKkbpMEEDDPq7v9nDuIM/YqYRbTkVIZDUg== X-Google-Smtp-Source: ABdhPJwJ8NVIOUVZVDLbGhToEzCVu2uQ9Bu6+37vj+CgVv7JyFbAxUZx7nAk+dyygedG7hxYyBsmEFsFYy4x7Klk8Eo= X-Received: by 2002:a25:7806:0:b0:633:8b31:fd0e with SMTP id t6-20020a257806000000b006338b31fd0emr7123048ybc.444.1647544672778; Thu, 17 Mar 2022 12:17:52 -0700 (PDT) MIME-Version: 1.0 References: <20220315115648.10521-1-mikachu@gmail.com> In-Reply-To: From: Bart Schaefer Date: Thu, 17 Mar 2022 12:17:41 -0700 Message-ID: Subject: Re: PATCH: Fix inverted condition for unique completions To: Mikael Magnusson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49865 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Thu, Mar 17, 2022 at 10:09 AM Mikael Magnusson wrote: > > Okay, so UNIQALL means to remove only consecutive duplicates, and > UNIQCON means keep all duplicates. Right. That doesn't make any sense, > but it does match what the original code does (I think). I suppose it depends on what CON is supposed to mean. I think the meaning is to collapse only consecutive duplicates down to one occurrence, so duplicates with intervening non-duplicates may still be left. E.g., similar to the difference between "sort -u" (UNIQALL) and "uniq" (UNIQCON). > With that in mind, I have the following patch instead, any objections > to this? I don't immediately see any problem with it, unless my remark above changes your understanding somehow. > PS the manpage says -V is required for -1/-2 but -J with -o nosort > works as well which is what happens below. That makes some sense, yes.