zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: mapfile and unset: Does this actually work?
Date: Sun, 21 Jan 2024 18:05:12 -0800	[thread overview]
Message-ID: <CAH+w=7ZQfwdNLPS1=Z4mWpV--Uedft3M-gSwD3Qn-3PxfK3O_A@mail.gmail.com> (raw)

Doc says:

mapfile
     This associative array takes as keys the names of files; the
     resulting value is the content of the file.  The value is treated
     identically to any other text coming from a parameter.  The value
     may also be assigned to, in which case the file in question is
     written (whether or not it originally existed); or an element may
     be unset, which will delete the file in question.

However:

% touch removable
% zmodload zsh/mapfile
% : $mapfile[removable] ; unset 'mapfile[removable]'
% ls -l removable
-rw-rw-r-- 1 schaefer schaefer 0 Jan 21 17:17 removable

I tried several variations of this and I can't get mapfile to remove anything.

Looking at the code:

static const struct gsu_hash mapfiles_gsu =
{ hashgetfn, setpmmapfiles, stdunsetfn };

There is an unsetpmmapfile function but it doesn't seem to be used
anywhere.  Even after recompiling with that in place of stdunsetfn
there is some strange behavior:

% zmodload zsh/mapfile
% echo 'text' > removable
% ls -l removable
-rw-rw-r-- 1 schaefer schaefer 5 Jan 21 17:42 removable
% noglob unset mapfile[removable]
% ls -l removable
ls: cannot access 'removable': No such file or directory

(so far so good, but)

% echo 'text' > removable
% () { local +h mapfile; unset 'mapfile[removable]' }
% ls -l removable
-rw-rw-r-- 1 schaefer schaefer 0 Jan 21 17:43 removable
% noglob unset mapfile[removable]
% ls -l removable
-rw-rw-r-- 1 schaefer schaefer 0 Jan 21 17:43 removable

Using "unset" on the local has somehow made that file inaccessible, it
just gets truncated instead of removed.  I think this is because:

% echo ${+mapfile[removable]}
0

The hash element for that file is still present but tagged PM_UNSET?

I started playing with this because I was concerned that having a
local mapfile go out of scope would cause files to be removed, but
even with unsetpmmapfile that fortunately doesn't occur.


             reply	other threads:[~2024-01-22  2:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22  2:05 Bart Schaefer [this message]
2024-01-22  3:25 ` Bart Schaefer
2024-02-04  4:24 ` Bart Schaefer
2024-02-04 17:57   ` Mark J. Reed
2024-02-04 18:04     ` Mark J. Reed
2024-02-04 23:13       ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZQfwdNLPS1=Z4mWpV--Uedft3M-gSwD3Qn-3PxfK3O_A@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).