From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3827 invoked from network); 14 Dec 2022 04:47:42 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 14 Dec 2022 04:47:42 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670993262; b=knvOu7DmPDkz/YHtIeeTtLoqSNMHY8gFlxEVf9SLEJjezpjWOxEQJovAOo92Q6L4jMPM5yheLe lVSukJBJBIypU6hFXBj+6tl9BBC0S/EbAkzwx6AzRWsR/lR7fSF4Jn6152CdVpHN1JdfowrBS/ MUdfw+mxen15LSrWT6V3APRCg9PXsKGkJMTxsYz76SmLT/6Y7wqYonQR7JYw+aF0sMJOl5fjDZ yULv/Wa1hkUhTrRNQlFTayCOucCTKcuGixN3RfW7KNnK2J2DVP9G9zMVagyMM6G+yD5RhRUWpE Jc5Bs1syRHGupoB/dq+KquaLQugv7zYo8GfvuObhRiY/wA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f54.google.com) smtp.remote-ip=209.85.208.54; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670993262; bh=+r4dfbxCtLQUdxPVK4nucZrvhMvN8d1159PNjpI5wTw=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=pnH2OK+2ATn/4hwQ1op8R72zAuMIVceucHwoFyiMgveG4Bfj7v+4cfvMuek463MtEcbNqqmFbY fr/49yd+HZR7fa8ChgngmnV7n9pF5mQcMfAXss5fH5ccKlcMK1sqd8mowWbxF2nrNjXGjqpgf3 7GeH3xL1jOzZbHRdzZNZjtbmNREFKk8ZgmQYo/oLQweTJkCc8a27HOBGm46AThDwJCYNcszHxN oytP2jyMwBEF7cAut5SFeoiB6rrCugC/WJfkzJyh8yZyAON1Jcv8XsvAYOdKQEWZ86VP686wUK 7tu6MSH4QpymuppRdTuJ+dhQBpO6PboZ22seiAN4IhYxzg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=+r4dfbxCtLQUdxPVK4nucZrvhMvN8d1159PNjpI5wTw=; b=Mw7si1n57eMs9SliTX0cic8zb+ 8AoxqyZySIMgBycGkYUxkSZMpRlDR4CKzoyttGpLqIAv9zzjay9IS6FQQEIns+Xfi52w+j6CXedYX 1maf/J7mwhiMI5OmmVTc2y9aET6lEogFRKZNd8DySLjknALZMLHcIvY1x9013EwIKeEEqVAVDCYsW wDv0425vWSqdMQmaKX0+ViWwxR9UZShkd2nRtDWsyXl/z1/1Fh9xQ2OGByV9vmYC0bXQ45EmBOatn vcjvDgjQAQks9v9aeUobzSTmd0XtniKw96KeJG+iiMy/zrjgl6CHyiPHVh6yHj0N70NPTWlG1qBrB KjBZ0lHA==; Received: by zero.zsh.org with local id 1p5JgD-000KGk-QJ; Wed, 14 Dec 2022 04:47:41 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f54.google.com) smtp.remote-ip=209.85.208.54; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f54.google.com ([209.85.208.54]:44558) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p5Jft-000JyA-94; Wed, 14 Dec 2022 04:47:22 +0000 Received: by mail-ed1-f54.google.com with SMTP id d14so20848828edj.11 for ; Tue, 13 Dec 2022 20:47:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=+r4dfbxCtLQUdxPVK4nucZrvhMvN8d1159PNjpI5wTw=; b=pnDGlpKgzzbOCSKB5Kd0eqxWRfrjsB7VoJnaAwVeLEL7SeXcdeyJl0S7QlfqCGpfHy eHPuSfceRkp+QJNBFjmcp+6CFLRpljHbW8o2r630aY66d5h9Logl9Kw3UNT7f4uPrdav kfuKGD9wy24XnG/tRFKppLjBZHGiIz7RL0V3A0W5lC49WNRvbJrGEysObRAxjdWIKDWh zjxx6H5lmKCb5v+UeGUTe+Cew5gGt8mCjKOQoDzs3QW8Gvpl6h47h+1EqNMK39CeNq1o Efky/JzrwxnIxkAILSE8mhLx48yjwngyDUctkVOgI1ws9aVpZPWMy8jKgWWYrDTnyrTA 9JPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+r4dfbxCtLQUdxPVK4nucZrvhMvN8d1159PNjpI5wTw=; b=3b9wB181tyF066K1VYEo96Ln8XbYHksQAwqjGegJLLbMgnJFiZpnCv5k7CsnNcfegl nvXNhRdAmi/ZpVQRPssI2dvOQIkkEUWr90dD37vaDSCGnJCDIWbGXGMAlaxdRZupDn6y vBZQkwX+DxehFpa94oVG38K2ia2RHzh18L42K8RLOJN9Xa3z6tgD7rwH4DXnmWxwhebt XOIt9YPDuXmlzMkICdGuJpd6Ta071Q+/xyZekAXDrRFPTlYD00PZLrhnYllHTxECAyhY QNysSb0/0355yGVK2od9/VOXBcW6RUA/74QCaNPf5FpswZJaK7yl+lBqtOiZu1XDEOQX D2gQ== X-Gm-Message-State: ANoB5pkyEktwnzqmbe59AtLYYmmxRvOXVc3PT5fqUOF/xQTCauOqcTta +bBHB4ckjmde92yG3+CI9c4ek26SxAAvzB89r9n8/90bcWNw1vt8 X-Google-Smtp-Source: AA0mqf5ETIhrHKCUcZjs/KxfugZI0KJZ9LtNjHMuIlyW9RYiZSJowpzXiXTZPK2tojrg31m87NPYDU7r+EdD05uNltQ= X-Received: by 2002:a05:6402:4507:b0:467:205b:723d with SMTP id ez7-20020a056402450700b00467205b723dmr7231568edb.69.1670993239958; Tue, 13 Dec 2022 20:47:19 -0800 (PST) MIME-Version: 1.0 References: <1939278e-89c4-812d-5dea-e836568dc100@inlv.org> In-Reply-To: From: Bart Schaefer Date: Tue, 13 Dec 2022 20:47:08 -0800 Message-ID: Subject: Re: EXIT trap not executed on error To: Zsh hackers list Cc: Martijn Dekker Content-Type: multipart/mixed; boundary="0000000000007dc3ac05efc26e82" X-Seq: 51210 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: --0000000000007dc3ac05efc26e82 Content-Type: text/plain; charset="UTF-8" On Sun, Dec 11, 2022 at 8:52 PM Bart Schaefer wrote: > > I don't recall why this suppresses traps on errflag, if I ever knew. > However, the comment suggests the calling code should be clearing > errflag around the dotrap(). > > The question is whether its OK here to just clear errflag like this, > or if it should be saved and restored? Seems reasonable to errflag on the side of safety (ahem) and do the restore. The new first hunk covers another possible case; immediately outside that diff context we call realexit(), so there is no possibility of errflag being referenced again. --0000000000007dc3ac05efc26e82 Content-Type: text/plain; charset="US-ASCII"; name="special_exit_trap.txt" Content-Disposition: attachment; filename="special_exit_trap.txt" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lbn62wh30 ZGlmZiAtLWdpdCBhL1NyYy9leGVjLmMgYi9TcmMvZXhlYy5jCmluZGV4IDcwMDFmZDYxNS4uMmI3 ZTBjN2M1IDEwMDY0NAotLS0gYS9TcmMvZXhlYy5jCisrKyBiL1NyYy9leGVjLmMKQEAgLTE1OTgs NiArMTU5OCw3IEBAIHN1Ymxpc3RfZG9uZToKIAkJCSAgICAgICAoaXNzZXQoRVJSUkVUVVJOKSAm JiAhZXJycmV0dXJuKSkgJiYKIAkJICAgICEobm9lcnJleGl0ICYgTk9FUlJFWElUX0VYSVQpOwog CQlpZiAoZXJyZXhpdCkgeworCQkgICAgZXJyZmxhZyA9IDA7CiAJCSAgICBpZiAoc2lndHJhcHBl ZFtTSUdFWElUXSkKIAkJCWRvdHJhcChTSUdFWElUKTsKIAkJICAgIGlmIChteXBpZCAhPSBnZXRw aWQoKSkKQEAgLTE2MzAsOSArMTYzMSwxMiBAQCBzdWJsaXN0X2RvbmU6CiAJdGhpc2pvYiA9IGNq OwogCiAgICAgaWYgKGV4aXRpbmcgJiYgc2lndHJhcHBlZFtTSUdFWElUXSkgeworCWludCBlZmxh ZyA9IGVycmZsYWc7CisJZXJyZmxhZyA9IDA7CS8qIENsZWFyIHRoZSBjb250ZXh0IGZvciB0cmFw ICovCiAJZG90cmFwKFNJR0VYSVQpOwogCS8qIE1ha2Ugc3VyZSB0aGlzIGRvZXNuJ3QgZ2V0IGV4 ZWN1dGVkIGFnYWluLiAqLwogCXNpZ3RyYXBwZWRbU0lHRVhJVF0gPSAwOworCWVycmZsYWcgPSBl ZmxhZzsKICAgICB9CiAKICAgICB1bnF1ZXVlX3NpZ25hbHMoKTsK --0000000000007dc3ac05efc26e82--