From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: One possible answer to typeset vs. unset
Date: Fri, 4 Dec 2020 16:22:12 -0800 [thread overview]
Message-ID: <CAH+w=7ZVbUFVigzqmntzG2CwOP2v5rZ6v5WhFosOnMUHEy_v1g@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7Yv3ntH=0SxkBYz=KLKKsmvEXL=j_99kSm0jTSJhuySUg@mail.gmail.com>
On Fri, Dec 4, 2020 at 11:47 AM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> I've just noticed that the D04 test "Unsetting and recreation of tied
> normal parameters" silently crashes the test harness. The fix for
> this is probably closely related to correcting the flags.
Not so closely related after all. Unset of a tied local scalar left
it using tiedarr_gsu, even though the tie data was null.
That seems like an accident waiting to happen; I tested the patch
below on the master branch, and it still passes the full test suite.
I suggest it be applied there (it's already pushed to the declarednull
branch).
diff --git a/Src/params.c b/Src/params.c
index a0d4caf52..1a047d9e0 100644
--- a/Src/params.c
+++ b/Src/params.c
@@ -3659,6 +3659,8 @@ unsetparam_pm(Param pm, int altflag, int exp)
}
zsfree(altremove);
+ if (!(pm->node.flags & PM_SPECIAL))
+ pm->gsu.s = &stdscalar_gsu;
}
/*
next prev parent reply other threads:[~2020-12-05 0:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-28 19:49 Bart Schaefer
2020-11-28 20:00 ` Bart Schaefer
2020-11-28 20:21 ` Bart Schaefer
2020-12-01 8:54 ` Felipe Contreras
2020-12-03 21:19 ` Bart Schaefer
2020-12-04 11:04 ` Felipe Contreras
2020-12-04 15:49 ` Bart Schaefer
2020-12-04 19:47 ` Bart Schaefer
2020-12-05 0:22 ` Bart Schaefer [this message]
2020-12-05 0:28 ` Bart Schaefer
2020-12-05 0:51 ` Bart Schaefer
2020-12-05 22:17 ` Bart Schaefer
2020-12-23 23:00 ` Felipe Contreras
2020-12-02 17:18 ` Vincent Lefevre
2020-12-02 18:03 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZVbUFVigzqmntzG2CwOP2v5rZ6v5WhFosOnMUHEy_v1g@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).