From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 9692 invoked from network); 5 Dec 2020 00:22:50 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 5 Dec 2020 00:22:50 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1607127770; b=GiDnuUfe0vNntBZHD4iXzyenMjzkmOxl0ZIaYGkuPQ5Fgva7ydbfviSbI/vb2n9irenr0plLjB quPJyHpbjTB7X2fYzDW9+68A/tQAQOi1oKKIDSCDvYTNqRXhz1OhbUyr+vzR2DLk8RMfoLTziZ 03wmPGPRWmU+8Pk9z4wCnt/rQQPXdLXhboP/kML5DiAXerOJmST32FLTNoXcb0GfAZnQYsh/1i B6FlM4Ugl2lql7r/QCr2yDQTBu4FCcnMOmVNoe+fwcUg4UBVAx0Y5YU/Q3KzSHWkPEH9Pqe0Cx cBH5TIQ3V5LUjCYf5Lzf7Sqxv54/q4N2+AJMdxyceRgi+Q==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-oi1-f171.google.com) smtp.remote-ip=209.85.167.171; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1607127770; bh=eEHsrWY/OM5v+7Y2FUex55HMnJiNfnSY7tsmJ11CIbY=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=PF4ZiR3KQChO8eXIQFFd4/bAvboohPeU9oUKMJpjOwUzD03Vi0bIIU8fjQXEb3EkDzjQl7OgQq s7VasY8FWOCvqO0UsL2ZtT5LHUXQ1V17B1WqFyNS8N3iu80N5e40BOIDmq5WzWtuo/J8a1aieI BtzEhusBYzE23HnbfWDiP1wMfoa9gxrNWHANJIKRp5/296Vd8PsttYY2vvXdkBv5L2YhAbcdcv UKhX1HTGxsgBbJjqOV+XkE807F6BosoAkoMQKCUVgUF8IvC+lIpuCjE+JITooquwW28Qpe90+1 RObP2TIuvCTuuakpu3twSMdxuInRO/KO/aib1v97NZbOXg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=5V5wxJYAi0LOEzc5ikWWI1L4NaH7C9nMDMdNPHLBx1k=; b=DBsYd9Dt6c3xt6gQnUpDS0Mpcz 3+juEjpcV1muWV2kK9vZ6deE5MkE8eFaH49yCav+Gkh53g1YT3THyjgZxqVxIkIq/sccYW196hLxu 2II57w09BQIDPuohXdQoQFRVIhTnNK/1O/nChlYXwPi5qP957UAEZVfWM/MMyzgYhC6aRTzFlw3Rx Op4HF2ey82kL3/PrBL3QZoJNkLJTrlTc7zr2nDEmfbvPzl7u5DgQ5SQKJ+UsF0uMjP249W7XAMGHH eAVFHOL/DZ5TsOe/B1NRyF8f1rYpUMjGUdTNJXIwNvT+XK7osygU3CalHQpKiA3n3uIL0yAYB01RY dJNLFfYw==; Received: from authenticated user by zero.zsh.org with local id 1klLLY-0004up-0V; Sat, 05 Dec 2020 00:22:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-oi1-f171.google.com) smtp.remote-ip=209.85.167.171; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-oi1-f171.google.com ([209.85.167.171]:38769) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1klLLF-0004l8-K0; Sat, 05 Dec 2020 00:22:27 +0000 Received: by mail-oi1-f171.google.com with SMTP id o25so8231716oie.5 for ; Fri, 04 Dec 2020 16:22:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=5V5wxJYAi0LOEzc5ikWWI1L4NaH7C9nMDMdNPHLBx1k=; b=PwrxjnPRTYOPjOQTiMC/wVqDMw7fw8rAdzjQCyF9r37H4Cf3GUsK4brjhAxo60zQof sUm4HARy6ht/vY2dKMzqFNMqLOZhcVKHAeAziMomFVpFdfZ4Gr5jiiZtWOdswn5Hs5e3 +mTkjc3C8CzmtaidTMriFxkNqBMZvPb+6gYAMrit2Npefbrq+rzs+bsZDT3FEtPRXVLH RbDy/6bXJLC7A6P4V7dratyfMRvQI87W5MePoHkXRHevj8XngZEpcstOeEEgpdg/6ex5 RAWybxLM0FV5oEFIPxicS0n/6/xst9lQnoRPbWuhNcydwPlsIAgkidquNJnT9JDzjvix A5+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=5V5wxJYAi0LOEzc5ikWWI1L4NaH7C9nMDMdNPHLBx1k=; b=GbTvoqKzb1N10kpiojs7tvKZJNxf7HTc1QZ76af73o6DdX7oqzNYgLkcFdUUUPCNKK 2kn7FizoaBwOq26xT6w251kmdtgGG0eNg+r8BtCR8lIurwM2FcMxydRgYQKqiLjM3QcO Z6cUIIqfqIesLEPOtVSxmq8Fg8JmnwtapTzt0+4KpwfdYmsZCaLcGtrE+rVGt+bIyRqB 9mUKFnpE7Tym+BjnFjG51xQw4gcq5X0HvuaWOIfZkNncY+p5MKedz0SYgC9nEPp7WW5d 4b8JDSoqTADhKEuHpxESkc+p7cHPr+O/61BSn5ey8eSnZBRIX1eGLrVJjWN9YQTLF40b xUGA== X-Gm-Message-State: AOAM531DzpF1+WUG7YvvvhXlvYoVAzv3nRdFgrMEPdrXHlBnMoM4Rke5 2P7z0kvZtz9a53kR1CakruMcYmxZXxZ1TGkia0AHMwOafjFitQ== X-Google-Smtp-Source: ABdhPJyi2mKEfOM2f5i9ytnBGNi5Blf+cV8FlNv74pIArtIn/loz7WoqblieEOgPl419bR00Skd/usCy1Gr1xAEfREo= X-Received: by 2002:aca:bd45:: with SMTP id n66mr4959576oif.132.1607127743863; Fri, 04 Dec 2020 16:22:23 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Fri, 4 Dec 2020 16:22:12 -0800 Message-ID: Subject: Re: One possible answer to typeset vs. unset To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 47724 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Fri, Dec 4, 2020 at 11:47 AM Bart Schaefer wrote: > > I've just noticed that the D04 test "Unsetting and recreation of tied > normal parameters" silently crashes the test harness. The fix for > this is probably closely related to correcting the flags. Not so closely related after all. Unset of a tied local scalar left it using tiedarr_gsu, even though the tie data was null. That seems like an accident waiting to happen; I tested the patch below on the master branch, and it still passes the full test suite. I suggest it be applied there (it's already pushed to the declarednull branch). diff --git a/Src/params.c b/Src/params.c index a0d4caf52..1a047d9e0 100644 --- a/Src/params.c +++ b/Src/params.c @@ -3659,6 +3659,8 @@ unsetparam_pm(Param pm, int altflag, int exp) } zsfree(altremove); + if (!(pm->node.flags & PM_SPECIAL)) + pm->gsu.s = &stdscalar_gsu; } /*