From: Bart Schaefer <schaefer@brasslantern.com>
To: zsh-workers@zsh.org
Cc: Connor Olding <cloningdonor@gmail.com>
Subject: Re: Crash with read-only CDPATH
Date: Tue, 2 Jul 2024 11:04:34 -0700 [thread overview]
Message-ID: <CAH+w=7ZWBefYS_a+uOQxLHCtu+KGuqDT8Jr4Qsn7UjOFueoSEg@mail.gmail.com> (raw)
In-Reply-To: <A4710344-95A0-48DC-BD1E-A4CCD1B08251@kba.biglobe.ne.jp>
On Tue, Jul 2, 2024 at 3:27 AM Jun T <takimoto-j@kba.biglobe.ne.jp> wrote:
>
> If CDPATH (a special parameter) is made readonly, save_params()
> (called at exec.c:4071) does not allocate any memory for tpm,
> but the original pm (obtained by paramtab->getnode() at line 4410)
> is added to the restorelist (line 4442).
>
> I _guess_, in save_param(), we need to add tpm to restorelist
> only if a copy of pm (i.e., tpm) is allocated.
>
> Is this reasonable?
It looks reasonable to me, yes. Thanks for investigating.
prev parent reply other threads:[~2024-07-02 18:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-30 0:11 Connor Olding
2024-07-02 10:27 ` Jun T
2024-07-02 18:04 ` Bart Schaefer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZWBefYS_a+uOQxLHCtu+KGuqDT8Jr4Qsn7UjOFueoSEg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=cloningdonor@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).