From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id E815A260EE for ; Tue, 2 Jul 2024 20:05:24 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1719943524; b=bwj3W8/RK+XNueyxmXB7oYjAyiLphsg+FflzQEN+R5C9BIeZ/sMfofHagJaqxb7yX8kb9yJAw6 aMRs+R35YiG5ibgaTTVWaA1NviyklNM+ynDA2J9rmvMK0Ty6pnphv/ZYPY3ZJ9GjBoO2ew4pHh /Jr0NDPcYuSabIv4kxTbFuI339vbfrOUrgoJQpCnXbYak5WGg+mA0HiTmaqYJLIkT7QoZp6HaY Em6I1AzArATpGNMLxza29BSHbErMNxYzSSWzXbjCXJwc8Fl69LSvNYXpw9r4c+1PxFsiLr10M5 GudUcw3hQSEk4SRd3yem1SAOWl5k2oPOEX3AO5+SODE2tQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1719943524; bh=c+8Bhe7jeza8sDVl6gkHgjnKPci/5p4cVv1x1iJcDxE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=QYKX6bpXIR67Jj0ptjyLw/5WxZmAKK//hPs+msmm/iV4wtmdLtUR7n+kjPgLxfx2pdG3q5HAt3 I/bS77vFzxOvF6g5KW4Xj8sBmM8y5w7JLg8Td/BIy3N84E7fDWr5tEI2q6v5p+RQKkz6Conk+k CQiQDjBELfa/uvjvIifZC0XpUxSZUzsILEdLZ78mncYazuGlYNRGrn2WInN/snf9Hj8aADViKo JOImKD1l6YZJkrc9YwxjkrzsliDMhGdwYR+5vwlxc6VrXBU+y8IyA0kN49dQMiqAX/tPqtP9/G pEstHKOPJjn6N3NRzYuxviwrwu4uhWL8mwPDgQc9bVsJ4g==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=EqFk0Q5nff7hGW2aOMYv2Sc6UEZR2oZbSyM/MMBUUy0=; b=J4ogxwNtDUu5Lq5YJZOlfNStGN 54UlYLpdvbgK3Fqv0jU7PfH1QddiSUQ3/21LcUBOhdgxo+jTn/STcz39gawIncWd/zLlS6ke83OuF tIenBtXFjI2uAxowbtMiAXT31FxSTWmuJSzHD4UkLZ5wXMRbiJVXbiULLZ6sJg02rY771unn5YOpw 3FKjPkZvtd2r4VJlO4m3i79RF0x1Uf0GzX9sN3+ukmk+3Gpokn3YCfRYI5sEWSqtq6MXsyfm6i1jM un36weoS0oqad1w0yFltK6jNRW3VCP3LCsQRUIgXTchsgeyusvhaiK4oj54zkAyrvs2+HQZ2oICgO mUqgp56A==; Received: by zero.zsh.org with local id 1sOhsZ-0006RU-2T; Tue, 02 Jul 2024 18:05:23 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f42.google.com) smtp.remote-ip=209.85.218.42; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f42.google.com ([209.85.218.42]:44482) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1sOhry-00066W-JP; Tue, 02 Jul 2024 18:04:47 +0000 Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a70c0349b64so597429366b.1 for ; Tue, 02 Jul 2024 11:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1719943486; x=1720548286; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=EqFk0Q5nff7hGW2aOMYv2Sc6UEZR2oZbSyM/MMBUUy0=; b=mFuLyv4TNo34Nrw2NPn3yWZ8E1a/kSTX19kTSbr2jiPe72/hn6nbIX6t4DYz/ZdAd3 iga3SrhmQYXirROJV8LDTwEFnjPuJUGHEh/rvCn+dTr7fAuX+KrdOFh9zcmv5y/EmSUl BnR0SRW2uoR7NpmHi4pGY0H7FNOUba/ilyIisyvU7cj+DnjgY89CvpMH3WhxMF53zp4n tA8Vh0Yznh4UnaF4iZGDYuSXTQOfVFclLEKOo5hH4x8dopphl41R5cQWQ/FOs+aXKEgk OZ8ChhtS3cxIIiYqJ3DrO4LadW/3T0Rn3cC0iq3bHXMf8Mm1GPqwGrouGP3B263A2l54 jRPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719943486; x=1720548286; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EqFk0Q5nff7hGW2aOMYv2Sc6UEZR2oZbSyM/MMBUUy0=; b=YAjj2IfM5a/PfdDSESnmto29EzEfFkiK1NkEvNEHjMAW6O4u+2P5rt/piIpEa4mfI2 Goz1Z6DRVuOBNC+nd5pTFF0LzIwKRCk7vH9Pt86vITsX2OcVAM4c5nZdPKfNw/A8xXMj t2n7wxiXpdNLDJaYuyzI4pwn5BmxgpgOBR5jqGtdBsizslw5twM7dnsh4ANsO6AD6NGZ 9T1zUsg190nJQoldWeImkAWnr0f9uKgm5Bv/z286fvVMLAxqqnnGbEv8LBqWIdvulB3z MQfKkucXjaD5AF5d3x261IKGIYs4q2kye4tRvnVXqXYaUEwYkHLG8026+/pL6oNuurBz wwPw== X-Gm-Message-State: AOJu0YxmgmyT4wWwnMh6iTEOFcJ9cWaDTIXuH1uN9PMGcDfsZbXMF/fC Suwa5lMGswhCzkYoNVhG/dfrwy5F51TbS3yn+HttdpJTz9qXi0iE3C8MJ3woTwbNGYqSlL/3nki mbf7l3o8UGNns7QgMcsx2phsHQWMwsR7rerxwriYbdJdNCX5J9Q== X-Google-Smtp-Source: AGHT+IFGUJDTrvN/ZvuXHjvgrEwAVtx60SC3lxsUhHoS7NWVDicaiREplOQ6FtrUCElxzceci7IuRrHh7UVWQW4nN2Q= X-Received: by 2002:a17:906:a0c4:b0:a72:5f9a:159a with SMTP id a640c23a62f3a-a751440bc76mr591519266b.2.1719943485764; Tue, 02 Jul 2024 11:04:45 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Tue, 2 Jul 2024 11:04:34 -0700 Message-ID: Subject: Re: Crash with read-only CDPATH To: zsh-workers@zsh.org Cc: Connor Olding Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52986 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Tue, Jul 2, 2024 at 3:27=E2=80=AFAM Jun T = wrote: > > If CDPATH (a special parameter) is made readonly, save_params() > (called at exec.c:4071) does not allocate any memory for tpm, > but the original pm (obtained by paramtab->getnode() at line 4410) > is added to the restorelist (line 4442). > > I _guess_, in save_param(), we need to add tpm to restorelist > only if a copy of pm (i.e., tpm) is allocated. > > Is this reasonable? It looks reasonable to me, yes. Thanks for investigating.