From: Bart Schaefer <schaefer@brasslantern.com>
To: Roman Perepelitsa <roman.perepelitsa@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [patch] Avoid race in zf_mkdir
Date: Thu, 15 Oct 2020 08:29:02 -0700 [thread overview]
Message-ID: <CAH+w=7ZWYjRC8TX0-BekfW932pw_P15YSad03SJaHL8=3-S+zA@mail.gmail.com> (raw)
In-Reply-To: <CAN=4vMqihCrowyGTxKhkdzOQq3GcmWes3fuzYXJ1DBN9WsLnmA@mail.gmail.com>
On Thu, Oct 15, 2020 at 3:02 AM Roman Perepelitsa
<roman.perepelitsa@gmail.com> wrote:
>
> Does anyone have an opinion on the value of N? My latest patch sets
> N=8 but N=1 would be fine in practice, too.
Any value > 1 would probably render the chances of an incorrect result
astronomically small.
Minor nits about the patch:
- zsh coding style prefers a space between keywords such as if/while,
and the open paren.
- I'm paranoid about tests like "while (n--)", I prefer "while (n-- > 0)".
next prev parent reply other threads:[~2020-10-15 15:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 20:07 Matthew Martin
2020-10-09 20:24 ` Bart Schaefer
2020-10-09 20:35 ` Roman Perepelitsa
2020-10-09 20:47 ` Bart Schaefer
2020-10-09 20:53 ` Matthew Martin
2020-10-09 21:22 ` Roman Perepelitsa
2020-10-09 21:27 ` Bart Schaefer
2020-10-10 11:50 ` Roman Perepelitsa
2020-10-15 10:01 ` Roman Perepelitsa
2020-10-15 15:29 ` Bart Schaefer [this message]
2020-10-15 15:36 ` Roman Perepelitsa
2020-10-15 16:47 ` Bart Schaefer
2020-10-22 13:30 ` Roman Perepelitsa
2020-10-09 21:40 ` Matthew Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7ZWYjRC8TX0-BekfW932pw_P15YSad03SJaHL8=3-S+zA@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=roman.perepelitsa@gmail.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).