From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: from zero.zsh.org (zero.zsh.org [IPv6:2a02:898:31:0:48:4558:7a:7368]) by inbox.vuxu.org (Postfix) with ESMTP id 63D2E242EF for ; Sun, 28 Apr 2024 20:59:49 +0200 (CEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1714330789; b=n/x1kNt5GYO5ZS2BSAKyYRBv6VIK8uMzlANCqNxhaIDtrT56otGfl88pGpSQVVxYdOzzioz94I UWi/Ei+Dd1/fdM0rcwU72Hdny9UcnojS7cx8m7Xh1glT0N6O1wsOQsQp/xgx8uL5x3LQn4x5SR CidxB+gtDgdZiDoix1MzE7POspMTDXIAtKju3fNgZRbslR4A0c4bl0S/UQOI8QP/tidgcnQBdS ikiaYsjv7Cf6kWT0Gu66KOLaL617RbwmIkyn7dxSlqgl1QB+98sRKrQ4KizGzaNUBRjcD9gz5C dU3+SkXRlGq1Zm9M/62mQ7LDutymGU8uNs9VU+2au0IVpw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-wm1-f48.google.com) smtp.remote-ip=209.85.128.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1714330789; bh=FDVBXvrjYpLKKCeys0Y/jno+H/L+uw25E5RejRBJEr0=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Fv6bU4fiS/jS1gbfJRTBbfyKMSv8wGLC9p8clO+ndJ4VJbPsICi0/l7OJ9LxRtOaSBdWs69d5m BSfRTBeaszfVV1ZfWDxCvKHCtdPrZVtXBLq6MUcHq1P/Yl4iKbJEg9EzCLS8/eRLvmWYAa0WLk UdNCokUV/xid+i5ptW5NFf1sU63Ggbm0M4AA7hCg+1nBF6KjRdeZcz7Ob/I1IozOyMDm8iZ1W6 G1V/F9Fh0gsVaTLGBl8DQDC7NvdPXewOW4okIdQR+ld6HX0AtTfjyuzlVXh14AQbe5n/7bUbmt 8QDKlNsWcQTbtcbPsDTJ1VI6TDOfMBNTS1sYkMffVdLDjQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=HcCpttrLOHvGszXXXQUju/hpp4pYNpWhFGpIFtK7eR0=; b=R9/dWWxJcAQ+HbDCH2gqmEZBrp 8OoHcyyUG8cqDZNVnlkiDsunHFjjXn3M+IlDoV7xu9la42NGKTVShccWyaIGPo02ApoBo06BkhUV4 3U8hBageOxIds1QmdFrcpOXqswjr2+kvcgJHQxtCidWBv7obHHcTdN1B2MQVBgfqZ2T6RTAIXuUYS FGbghK3F2ft386rhmV+DxCRNsPNocOkzl2/59hRd+dBDiiuhmYFBNVbV3/Saovbx04D8CG/rqjef7 srIPty0ybAKPYOymvZXbyy4Mu+sutDwDa91+u89nU2milw/P+xQq0LaqG19vXAtinkkGqHkdUTWy2 k5zyQWZg==; Received: by zero.zsh.org with local id 1s19ka-0008UA-R0; Sun, 28 Apr 2024 18:59:48 +0000 Authentication-Results: zsh.org; iprev=pass (mail-wm1-f48.google.com) smtp.remote-ip=209.85.128.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-wm1-f48.google.com ([209.85.128.48]:52642) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1s19kK-0008BI-Kg; Sun, 28 Apr 2024 18:59:33 +0000 Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-41bab13ca81so19398295e9.1 for ; Sun, 28 Apr 2024 11:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1714330772; x=1714935572; darn=zsh.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HcCpttrLOHvGszXXXQUju/hpp4pYNpWhFGpIFtK7eR0=; b=nrXkWl2qto/f6yvPv8iRLnqvA7tnMuUqeIUawqifqRTtktgHT1S2OKiP30SrAxPHTJ nJJboeHWRu072esg4cgIq5OFv9pmvZlryQdUdLVEkBbz0+1FFmJRcEe/FJVS5os4FCu3 PhkS+qGNqV+8einmnhTDU+K/vddpkMrSX29DIO4eL+4HOklyeF21aOGkOZcejrnBRFZh FPMFjDUxViVkYQYtKmGk5SVYkY062E+HtuVJa3c4hDEu+gAwh1MenSafVyr7Bv7xacbI Qjvgwe6jrYCbuEJurwLZGetSA+RvCQ480Oc3+8mz1qimAsGaz3Be1PErtsUMMtMckFfD c6EQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714330772; x=1714935572; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HcCpttrLOHvGszXXXQUju/hpp4pYNpWhFGpIFtK7eR0=; b=SzuahZWHpgXhyS3LF4lmLZ+HTpeguncjFohkaKJJ02/xNpbduMITMl1dilKj7vQd8D IB9se0uc5j+dpGIurm5g90SlMduHmsJDIcJjQDuWfodZUG00ixjCENqMSHRKQMiV+o/F NLZYxPFzzo83Du3dMQCWtlRALEFqGbv1MuGwDnqdC49BXDkbYbyhL2HbZSpiZKGXu4BG TRfzaP6+Ba1j/IPAPJPWVjR/u6NYBYTcyGUJNCpS7BmZXUB59p4km2IOvI0cLpYGitG+ xT4R52ijVmVzvCcJkdjXhFzGIpQ3SSr+AZYXaelFFZM5D4ZrZEUoa74LD6JFQm2WS648 spBg== X-Gm-Message-State: AOJu0Yzr+e6R/3OpB57bmSXSLsZ51kuRgi1ncDkzTil08rqLpYeJTnOm ZxRZXpY54//EAchwAxRJosu8JmeCcbLRqa+CsR1Wkee3/64aPezZY3iNYvGmsUw/H1qpROSfa8h OPIiGHDtLSIR9RJbgIi31qtPYPCMgUCYo5Qq2 X-Google-Smtp-Source: AGHT+IEICzamZDtAtXerH2C7k0p35WSe2Cqbnfylwnlu+t1CZ3hqVI//agoV/7ZDyyMV2elh5G9bARUpJA+oMXPaWU4= X-Received: by 2002:a05:6000:4013:b0:34c:b1a9:1816 with SMTP id cp19-20020a056000401300b0034cb1a91816mr4046139wrb.31.1714330771773; Sun, 28 Apr 2024 11:59:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sun, 28 Apr 2024 11:59:20 -0700 Message-ID: Subject: Re: Bug report; git tab-completion on macOS within paths containing unicode characters To: pu.y@delley.net Cc: zsh-workers@zsh.org Content-Type: text/plain; charset="UTF-8" X-Seq: 52903 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: This used to work in 5.7.1 (default shell on Catalina). Then this change was made: - local pref=$gitcdup$gitprefix$PREFIX + local pref=${(Q)${~PREFIX}} + [[ $pref[1] == '/' ]] || pref=$gittoplevel$gitprefix$pref Unquoting the prefix with (Q) seems to have broken it. That came from workers/45313 ("revised version of workers/41523"). Daniel? A different fix to try: diff --git a/Completion/Unix/Command/_git b/Completion/Unix/Command/_git index 7370aaead..22b945e38 100644 --- a/Completion/Unix/Command/_git +++ b/Completion/Unix/Command/_git @@ -7531,7 +7531,7 @@ __git_files () { # First allow ls-files to pattern-match in case of remote repository. Use the # icase pathspec magic word to ensure that we support case-insensitive path # completion for users with the appropriate matcher configuration - files=(${(0)"$(_call_program files git ls-files -z --exclude-standard ${(q)opts} -- ${(q)${pref:+:\(icase\)$pref\*}:-.} 2>/dev/null)"}) + files=(${(0)"$(_call_program files git ls-files -z --exclude-standard ${(q)opts} -- ${(q)${pref:+:\(icase\)${(qq)pref}\*}:-.} 2>/dev/null)"}) __git_command_successful $pipestatus || return # If ls-files succeeded but returned nothing, try again with no pattern. Note