From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 25971 invoked from network); 4 Dec 2022 05:29:45 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 4 Dec 2022 05:29:45 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1670131786; b=jG/PpRXUeggRBiZ5wqCfS1rBGkthdYyxLCzrnoCj5jxJfpeiTR/IYBcCtfGkBKjoT0Y5cII2Nx z0VL2JabLEAxVy196q8Fie+8mpZgqCSrITekh91R6lhcWvFvzABQcaG0VEgjKl/d4nG0fZXtyu b+BxqNAqHSurpcqQ+Jp2/Ngw2JNkYQMrnUG8P8MnbZ6e2W/vMsxOKR1GvPIi9ckoM/F1IDfGhb nhYz+pHq2Zc70RxEH52f2BxcaSmblNBcC8reLGm0OybF3atwaZEiDggQvIv9eyEchog7tvmue3 yS+C8uSVVv1ifkYHgEQejoOeUh0hgpdupGNV3TBS4TpP3w==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f50.google.com) smtp.remote-ip=209.85.218.50; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1670131786; bh=tcZZiDHJTfhpI5QF9vwOO/ORc+GRKIgT4KtgleXwr70=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=H1Gravz2Zu75bT91SN6/gwfYXbi48KnxWizsPwZxOE0/9Tt7FGDbvWCOm0qnJHRYiKueBgXjmX J4fXk6hPNEMoX+ZosdTFg7xDnHA+7o2qLHA+G5PVibATxPgvmb7LwCgvAB/2puENoeZ+sRFvFY AxXLf8y77fOv55FV5GyeF81rl+SPK+wUBLHmUNuiVXfyAk27nO4fpfcBdGCgKHP30U9c8CX35p AvfGs5KaGWGpFMAANFIrazMv4BO3xjThexRFfPnKJWzmyINC6fEbICVZg4fg4LdNy+3RqK8Dgu QjLJpfLgf5huVKn4uzvOuNwd3MXWevFfAYm3ps+R70ID7w==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=zF2xbVMVbnsboHSMRWFGDU1I1Bf8oLREvRrS+tSReoM=; b=RyO2IMYkD2sQuAlWN7lk6k8tYs Hz1SG2HzpC1q8mu2tnvXDQVxSve/7ziTLPxTJIutTy3yg6ivYcpx26oq9NnNl8C86pkI/IRDYqXbi Fkbo0eYJiTnZ6JCnxyFT4aUtTMd1SYRxUybgOmnjp5AL+nqtQ1BMqJh3L2fgPm1TBsGAS9e3DJEa8 6ksHGWOk/j5j5lBCf+JN/c8FqI/GY28gvaCUGCWYiIVHQLVgZN9/dvnLdYCwhpvez7iKMlM3LYy0s 8XRqm4e5V4eHD8JHqWwXkPb23ARQsua6+I6EsLhY3++IADVNwybiZT8+R5m2eptuSJ1pU0+sUo28k PxYToF1Q==; Received: by zero.zsh.org with local id 1p1hZQ-00066V-9I; Sun, 04 Dec 2022 05:29:44 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f50.google.com) smtp.remote-ip=209.85.218.50; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f50.google.com ([209.85.218.50]:36664) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1p1hYn-0005j9-PD; Sun, 04 Dec 2022 05:29:07 +0000 Received: by mail-ej1-f50.google.com with SMTP id qk9so2779551ejc.3 for ; Sat, 03 Dec 2022 21:29:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zF2xbVMVbnsboHSMRWFGDU1I1Bf8oLREvRrS+tSReoM=; b=H8HwU+ywAN81FWvcKj7DauMA0nAdPzzN2Qu59wCcRrr/h4Ytpvli7CK47Die8XDxQ9 s0s42EDJDjw7KGd+FW97QbP+ZWCtKuEz7kKiTEFrJ4EHEleepwiY8hEywZCBxNNtCZCQ mG64rTN2FSxmo5c36UHfvqGCLePjl2ARivW0eZiia8zx6q7rNF1de7qL/N81kCHBK3YO OgNYLbfd6lbf00bHn9fzL/zQ3nh9xFocmMOV1mVUgkvYJep9GOyNH4xcAyDkSvsra0j4 QPh+ZPTyemDOFFnZ2yLnColCtNckyzaRiCxyDMImP0xp4lvruZ5TN+xK9/FBilB87PEI jF9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zF2xbVMVbnsboHSMRWFGDU1I1Bf8oLREvRrS+tSReoM=; b=kPiyiFvV5WHemSSPFtA706Yrqu69BaPa4OZ/mRrjInoirf361eWUt2pIFfeofQnjPE tly54NJTznwP6u4MmArzeQbE7KqRBdAKCG9LwV6NocQABOj4Cz8cLzDDT3LpgBNJ846o jMYtOwz/JNO6PALj3x+ZIG/kUl26YMTPYqm6bhjKtnZNiAsWYtkbnVLgNOVgp0dsghhj wK50ZporX35rTTTK+InfUcS08Tb6rjJV0tFGqNJkhKVU/qGgbBNMglGUXRr5n9Yz2ZI/ O4G3YicKjtrnPzDwPzol1XSB84TjAuA6w1AlfL5ycSq9PbRAohr2LHv+DnTPuRS+H/5+ 7y0g== X-Gm-Message-State: ANoB5pn9iu2IiVg5mfhhV7tHSlwfea19K+FE3SgSxhky21gYgd7Ikyyc 01D7gsHkAZ1OWtTkKCggMfBlj6jHTHTTP80SrywH6A== X-Google-Smtp-Source: AA0mqf4Ky/8VCtVcl/KR6LrhYBOVsxmdiTwIsvjR0RkJk6LeMzKK96OY9ianQld3FqPbM4XHAD1O9RKzTdG5lBNy94M= X-Received: by 2002:a17:906:2c51:b0:7b2:8c66:9bda with SMTP id f17-20020a1709062c5100b007b28c669bdamr23251196ejh.732.1670131745152; Sat, 03 Dec 2022 21:29:05 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sat, 3 Dec 2022 21:28:54 -0800 Message-ID: Subject: Re: [PATCH] Remove NOERREXIT_UNTIL_EXEC To: Philippe Altherr Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 51100 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Fri, Dec 2, 2022 at 4:31 PM Philippe Altherr wrote: > > The noerrexit NOERREXIT_UNTIL_EXEC bit is never set and can therefore be = removed. In other words the patch only removes dead code. That explains MY confusion over the meaning of NOERREXIT_UNTIL_EXEC when you first asked about it: The use for which it was originally intended had gone away. > One thing that distinguishes the NOERREXIT_UNTIL_EXEC bit from the other = noerrexit bits is that it seems intended for the caller(s) of the function = that sets it, while the other bits are intended for the callee(s). This is = similar to today's this_noerrexit variable. Moot point now, but I believe it was still intended for the callees -- the original bug being fixed involved error state propagating down into for/select loops. > QUESTION: Should NOERREXIT_SIGNAL's value be changed to 4 (from 8) since = the value 4 is no longer used by NOERREXIT_UNTIL_EXEC? I don't think that's necessary.