zsh-workers
 help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Zhiming Wang <zmwangx@gmail.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: Regression in bracketed-paste-magic (not in 5.2, but affects 5.3's test releases)
Date: Tue, 6 Dec 2016 19:25:27 -0800	[thread overview]
Message-ID: <CAH+w=7ZbZdfN7rhXQ-yi4_kqyjyAv1w8B7hKi55TPEBnc5Yfvg@mail.gmail.com> (raw)
In-Reply-To: <B3CEC842-B789-472A-8C8B-89391950787A@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 908 bytes --]

On Dec 6, 2016 6:58 PM, "Zhiming Wang" <zmwangx@gmail.com> wrote:

Commit 20948d0 (38579: Functions/Zle/bracketed-paste-magic: simplify saving
and
restoring of state) introduced a regression that results in the ZLE buffer
being repeated when pasting under certain conditions.

[...]

Here's a simple reproducer:

2. Press the following sequence of keys (no space): ^R echo ^R ^E
   (history-incremental-search-backward, "echo",
   history-incremental-search-backward, end-of-line), then paste something,
   say, "zsh".


This probably indicates a problem with undo-point handling around history
search, which has been a sticky wicket in the past.  The patch you cite
replaced b-p-m's internal handling of $BUFFER with reliance on the undo
mechanism.

 For the 5.3 release the easiest approach is likely to be to back out that
change and re-apply it after the release when it can be more thoroughly
debugged.

  reply	other threads:[~2016-12-07  3:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  2:57 Zhiming Wang
2016-12-07  3:25 ` Bart Schaefer [this message]
2016-12-07  4:02   ` Zhiming Wang
2016-12-07 12:39   ` Oliver Kiddle
2016-12-07 18:23     ` Zhiming Wang
2016-12-24  8:28     ` Bart Schaefer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZbZdfN7rhXQ-yi4_kqyjyAv1w8B7hKi55TPEBnc5Yfvg@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=zmwangx@gmail.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/zsh/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).