help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: linuxtechguy@gmail.com
Cc: devs <zsh-workers@zsh.org>
Subject: Re: colors_plus
Date: Sun, 12 Feb 2023 12:51:38 -0800	[thread overview]
Message-ID: <CAH+w=7ZkCYJAVUScRzYuRkqdDuAQ2dmGb8t=b_UXMAHuAz2k=A@mail.gmail.com> (raw)
In-Reply-To: <CA+rB6GJ26iFONg6Z0=J8aa6QAQS9FuCAZ702tp+c_kkcDDE2fg@mail.gmail.com>

On Sun, Feb 12, 2023 at 9:05 AM Jim <linux.tech.guy@gmail.com> wrote:
> Anyway I was hoping that some on this list would run the function and give  me
> feedback on what you think of the output. It has several defaults so autoloading
> the function and then typing the function's name will give you 8 lines of output.
> The 8 colors match those used in the colors function.

There was a post-5.9 patch to the colors function to extend it to 16
colors (workers/50212).  The additional 8 may not work on the console,
I haven't checked.

You might add the named set you're creating to the hash tables
initialized by colors, and bypass re-creating your new names if
they're already there.

I also suggest anyplace where you're doing something like
  var=...$(print -r ${(%)x})...
it would be preferable to do
  print -r -v var ...${(%)x}...
to avoid the command substitution.

This function will be directly affected by Oliver's repairs in 51258,
51272, 51280, 51281, 51289, 51320, 51383 and maybe others, so you
might want to grab and build the latest sources from sourceforge git.

No other immediate commentary.

      reply	other threads:[~2023-02-12 20:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-12 17:04 colors_plus Jim
2023-02-12 20:51 ` Bart Schaefer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZkCYJAVUScRzYuRkqdDuAQ2dmGb8t=b_UXMAHuAz2k=A@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=linuxtechguy@gmail.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).