help / color / mirror / code / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: zsh-workers@zsh.org
Subject: Re: [PATCH v2] prompt: support generic non-visible regions
Date: Wed, 17 Aug 2022 15:31:05 -0700	[thread overview]
Message-ID: <CAH+w=7ZrUfQV6QRcfjCzJkdYM8bTgZkR3p0W4cWxJZEUOSS8CQ@mail.gmail.com> (raw)
In-Reply-To: <CAMP44s0F-wz79s+ba3zA0BqOmobPP+jXbrrLNGse1mdwyLu3Kg@mail.gmail.com>

On Mon, Aug 15, 2022 at 2:37 PM Felipe Contreras
<felipe.contreras@gmail.com> wrote:
> Do we want something like "\001foo\002%\001bar%\002"?

More on this below.

> On Sun, Aug 14, 2022 at 8:00 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
> >
> > On Sun, Aug 14, 2022 at 3:47 PM Felipe Contreras
> > <felipe.contreras@gmail.com> wrote:
> > >
> > > That would defeat the primary purpose of the patch, which is to be
> > > able to write prompt helper functions which work in multiple shells.
> >
> > In that case I think the patch is incomplete, because it's not keeping
> > track of bv->dontcount and will be confused if both \001 and %} are
> > used (or %{ and \002).  See lines 602 through 628 of Src/prompt.c
> > (line numbers as of commit c5a891a2).
> Yes, I've seen that code, but in my view mixing \001 and %{ doesn't
> seem to be a useful use case.

Your point above about writing helper functions would seem to imply
that someone might inadvertently use such a helper (e.g. via
PROMPT_SUBST) inside a section that was already surrounded by %{ %}
(or surrounded by \001 \002 though that does seem less likely).  The
purpose of bv->dontcount (or at least one purpose thereof) is to
permit nesting zero-width sections.  I agree it wouldn't make sense to
(for example) begin a section with %{ and intentionally end it with

> I can add code to make %{ and \001 be equivalent, if that's what we
> want to do,

Ideally they'd in fact be distinct (so it would be some kind of an
error to have %{...\002 without an intervening \001 and so on)  but
that might require a lot more fiddling.

> but how am I supposed to do a reasonable test?

There isn't a Test/ case for it yet even now.  How are we handling %}
when there's no %{ before it?  I think the answer is that we don't
have a test for that either ...

  reply	other threads:[~2022-08-17 22:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-11 23:09 Felipe Contreras
2022-08-14 19:57 ` Bart Schaefer
2022-08-14 22:46   ` Felipe Contreras
2022-08-15  1:00     ` Bart Schaefer
2022-08-15 21:37       ` Felipe Contreras
2022-08-17 22:31         ` Bart Schaefer [this message]
2022-08-17 22:48           ` Bart Schaefer
2022-08-22  0:17             ` Felipe Contreras
2022-08-22  0:15           ` Felipe Contreras
2022-08-22  0:11 ` [PATCH v3] " Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7ZrUfQV6QRcfjCzJkdYM8bTgZkR3p0W4cWxJZEUOSS8CQ@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=felipe.contreras@gmail.com \
    --cc=zsh-workers@zsh.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).