From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 6661 invoked from network); 11 Sep 2023 03:44:11 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 11 Sep 2023 03:44:11 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1694403851; b=JA2lSAYLwObwWU0dUM/7o0HkmPjUReKhPUC2uMMMe3Q1kAS0JyEt+Bz2HujhhbfpXbdmVyGCSz Ky++4T9AsvDeEGWlnz/jrIG1rLisLbkZrPyZfPbrAI6CkfMTzgO9sbKqGuJX9UwC9J2LPqM1o5 uYqnpml9gN8CalfyTL85D1UvgdGRJ8XAR8/eURty/pLXvkoPO1YsQHq18BblJUk2tO29+UEwjZ dDznxgGR/g0MPe7UJC0NuiC67M0DCru/eWhm/VNCTFPe9KSeE4a8b4AnD+ZydHzqBm6KdoHVA2 MKGz31ivc6jzR8wJsWHj/NcutvtOeN9gOlI7o6dwvZXhxw==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f45.google.com) smtp.remote-ip=209.85.218.45; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1694403851; bh=bCOuwg3+bmZPT3qFsqPJeCs4wId7MELjbHeYA56GIP8=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:MIME-Version: DKIM-Signature:DKIM-Signature; b=BhZK6GNvUWPyvcoNik+JgAG7AUsnyKDq3u5l1134XWCC83UNcS6IznDohO6gHVz8MfzvSIYBoZ b91KafixzvGksZpxM2fPm30VJLurtBlHXLoaCGnOV/6tBmsHj3XRht+uRBSnK7rjbNdU9NKgwR lUGgDqYVr/UmfgKF+xNjY6OxANXmv+YcIiII8Oz9gzMuYfRH+deGE2HPdlhd7TxMxTUVK/iML8 6oFdWB889togdTBcsEv4rrXT6Zh8Y4M8IY9g0J0yEAVvca40S2nYqfIo9Mg0k4fpcbF8UqieRx Q5YIIK4reKwIIJbMmlSo9tg8fTsj41i8/HaRS0zavgZ9GA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:MIME-Version:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=IX7o0iYpp6NcTlu3956nCy3isT4LXTqtIHCn56McHnM=; b=Yqdrz38Ejq6MXI8LCQSU+s4HQw G3S+2OIZMLzE/3wsakpd0UJIZCkFAyEAABydsX/Aqf0SKrMwNY5EXnm1nZ+3NHTN/C3B3xngeTNJ0 WE3dvMS86visRmJNmVF7fIHfCK30N5Snyoe/wj/b54AiusehKqTlsskau/1RjnhTQnndfOHl8Oohn qcyMxF2ORgY4fKBXkMTmz94cJLb0ZuI9fNWVT/yW8eqisTrw0TM8oYT1O0GHUFX7ZS07ts/jlqMdk HIO3/A0c76KkDqwudSkDRb3o3KHyXVVXTrEfWip9Ei1SYPwf/NurMrBUJSM5+UyD4Fyx9m8U+P2WG WYPudCfQ==; Received: by zero.zsh.org with local id 1qfXqK-0007Wg-8j; Mon, 11 Sep 2023 03:44:08 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f45.google.com) smtp.remote-ip=209.85.218.45; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f45.google.com ([209.85.218.45]:45235) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qfXl0-00076L-Pf; Mon, 11 Sep 2023 03:38:44 +0000 Received: by mail-ej1-f45.google.com with SMTP id a640c23a62f3a-99357737980so486929066b.2 for ; Sun, 10 Sep 2023 20:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1694403518; x=1695008318; darn=zsh.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=IX7o0iYpp6NcTlu3956nCy3isT4LXTqtIHCn56McHnM=; b=vyUBuDM3wu+0UCHTlJDKP7TdUbIEQ7pQYCJd5Ya7KnpGjtBFjTw2duPF49yEyFEmKP zbSA2NTb/C8X8u4pFox7ZRIlTrH206iCUAWYHf3qMqPuRCFy//sAdjMumcFZrV0WR2mY 8/D+S3OMICctrz1wex6r5LsvVs7S4zwKfJML+8C1xgKpnkoXRtElPqEgEygBo/c/0BNC oQV/I7tOy53M+FKI7r9Amch38t2Tr5KdwHDgdcH+3f9acac4bWDtrOHxsErq9wrawZUX RIueIFcD4eQSjM0tR5u5rtEAtnj++DnvijABoOXxVTsh5dpr/o2L1bwh43JjykqAK5ww JImg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694403518; x=1695008318; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IX7o0iYpp6NcTlu3956nCy3isT4LXTqtIHCn56McHnM=; b=ejcn3YrVUZlpOnYJMG9RxdPuL6O/dIkQYo+RrZN5m3jz9Vf5QeDprs0lKlLAhwurzD UEtCM6rBknw0SroD0tyZjGHTL0LTGUXLgIf5mW4au8MbmVNp6JeXajrpdXWGU38HG7it +B6M/fIgSF+uKiyfICcef0/COy9HVVXvY5RX+30XToEx57k3VuFFetap6OTaBVshEAfN gZFJksncIJCOHz0nu3MqVFiRXNrK7FX3GrXM81iHm0sD+9FNb/sChiqO295ojVqRyeR0 i2tKcxmF49FoBA56/OY37xXQrCj/a7NIFkmdeWM6oyhoS2Nftw/NosEpKDstS5GC64O6 Ng8g== X-Gm-Message-State: AOJu0YxoID830y9S7vy+FMuk4uwLJ5WI2sFqg+fOLUCjLJ1qc8HSzrg8 PzGkDp3Tyul7rGijDauTpGBhg/VxHALqJHvY0DeRKKZ/gDxB5Q8aYrM= X-Google-Smtp-Source: AGHT+IFc7c5FtO1ektd7SDRhF9FNlPOFheMVdYKBWQKg3G2CM3JdQX4ZM0uxEiJWh1ZBCU64NtnKkSRZpTSqJhCYH84= X-Received: by 2002:a17:907:a06a:b0:99c:6692:7f76 with SMTP id ia10-20020a170907a06a00b0099c66927f76mr7000734ejc.16.1694403518130; Sun, 10 Sep 2023 20:38:38 -0700 (PDT) MIME-Version: 1.0 From: Bart Schaefer Date: Sun, 10 Sep 2023 20:38:27 -0700 Message-ID: Subject: [PATCH] Crash if $TMPPREFIX has invalid or read-only path To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 52125 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: Easily seen with zsh -fc 'TMPPREFIX=/tmp/xxx/zsh; echo =(<<<"")' getoutputfile() calls free() on memory that was allocated on the heap by gettempname(). diff --git a/Src/exec.c b/Src/exec.c index 8f9d5a885..3a8b3e951 100644 --- a/Src/exec.c +++ b/Src/exec.c @@ -4897,7 +4897,6 @@ getoutputfile(char *cmd, char **eptr) if ((fd = open(nam, O_WRONLY | O_CREAT | O_EXCL | O_NOCTTY, 0600)) < 0) { zerr("process substitution failed: %e", errno); - free(nam); if (!s) child_unblock(); return NULL;