From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24068 invoked by alias); 17 Mar 2018 23:39:14 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: List-Unsubscribe: X-Seq: 42476 Received: (qmail 22313 invoked by uid 1010); 17 Mar 2018 23:39:14 -0000 X-Qmail-Scanner-Diagnostics: from mail-lf0-f48.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.215.48):SA:0(-1.9/5.0):. Processed in 0.574082 secs); 17 Mar 2018 23:39:14 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_PASS,T_DKIM_INVALID autolearn=ham autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to; bh=9mkYBFFneIDlRt1ICPeVUvb+XO7bsLmudYnIuvjtXZg=; b=QTBcDcN4QjH92D/14YJBKLae0ic5jjA4OcKfO3dn5b4i/y6tyOxTvES1AGnA/8kQ3k SMTpbeUYuSJLuHXvDAJJ3D12HbEZ/COl/Sviqk2/MnJCnPrayiuNKBCHbho8+mcUimEm dLw8UjJc9GMzVAAUv15nariA0fP/xCMPDWhKf4sEv243fqesi7T+/u38Sim6eBdr6g68 qKrxkqdGQFS4ajr3qMXWcQAniabZ0cwnZAPAbYahYu58Hnp/9GxLLLXpoU1UH77EW4gh 1E+HSnO5rNTUUDQF2tWF5pw/emb99DKqDfLdME+g31tEjNDjEzbsff6ZF6q8EkUDuuks z8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to; bh=9mkYBFFneIDlRt1ICPeVUvb+XO7bsLmudYnIuvjtXZg=; b=ADp8/Udq+bqZMloApyCshXCJPAcp9d1L1SGnjF02e6wKhZHHg+afl5QVMXlrB9OpKm kRbsbCb15LmfNPD2VeVJwl8nfRcmfQwXHku03MfFQzvojxJ+zqHufdMjbzUGYRTHy5on lBtU1bilxrtXCpFn+D7Ehyl+M10wJZH3jkfoi3TfxMkviLpY2BOIbaaruruR/biYfo3e QO1itWTw350cpPZ9IOutwGZzKVQ+7W97At4y/6aY7ExmDFo/eQitraVBugiheMCZPv15 /2T3KZKmMTboD8AGdpz1CNvJcLRg0kP+syia3nLmPy+IY1BJE/Jhv9YjrFcABTX91AQF H4IA== X-Gm-Message-State: AElRT7F+yPa0YMGfsWCo9904IkIgVqvneWJ2xTUSKZQt+goVcil0IOoA liPy3YPcv4Cae35MG7sXd4neSCx9STu0u6J3RVeRDw== X-Google-Smtp-Source: AG47ELuXhQk+EvI8xJrgu+ELDkH+ylDBQ3vSpZHLK6USvacjb55Dy747/+R1V/vzTjzvEVzDSoPVtSp1aqd/6j8ZeCM= X-Received: by 10.46.62.12 with SMTP id l12mr95034lja.66.1521329949547; Sat, 17 Mar 2018 16:39:09 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20180317231715.dc5zcswwoe5vf2zx@gmail.com> References: <20180316203930.f6mikhp7iiltgmpb@gmail.com> <7323.1521286049@thecus> <20180317231715.dc5zcswwoe5vf2zx@gmail.com> From: Bart Schaefer Date: Sat, 17 Mar 2018 16:39:08 -0700 Message-ID: Subject: Re: [RFC] Looking for opinions on accepting refactoring patches To: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" To what Oliver said, I would just add: I'm much happier accepting patches that stay somewhat close to the code formatting style that's already in use, which is pretty lax in general but boils down to: - don't use // comment to end of line - don't use CamelCaps except for typedef names - indent 4 spaces with 8-space tab stops if you use tabs at all - stick to 80 columns where possible (yes, we're old fogeys) - use whitespace after keywords and commas and around open/close braces, but not after open or before close parens and brackets - violate that latter for readability, especially with extra line breaks