From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 29103 invoked from network); 10 Sep 2023 22:01:02 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 10 Sep 2023 22:01:02 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1694383262; b=esEBsbnXuKaNuB6LMK40ePa5b9l7sUUf5ywuu/RhTF69gJYiZGFSbHu0eVN2PQZ9wNh/qlEm92 gJn4+zAwDRzmKLpE2HMzV8YjYpgTErgfaGbw+u1Vpvk2FnhKp7gX6VOvExXSMx+TeGpkRw4Ssm VMKm7+CzB1YMOPYtX8abcGIlN4/KD/q8nyZZA7vA/kJz+iyzHK02zs5t0yRCvyVUo33TAKTvG7 5qy+wlfwrBQLJ7OkDTB4EW8uq7Sova9Nk9eKwEcptGcHgsF1+I4dGRovtggV9JBN6GPS3rYzXN sz/viPH0mkrWFuGb2W+hySpm65msTT4Qdvd8GYS7/NsOag==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lj1-f170.google.com) smtp.remote-ip=209.85.208.170; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1694383262; bh=CAfvmN1mDXZXIwNxFdZveJn1hcKj3XCq6UUVIqa6w8s=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:To:Subject:Message-ID:Date:From:MIME-Version: DKIM-Signature:DKIM-Signature; b=b+jqr2yxfHavRFTaLd14QmklNyjdbuqzTwnK2K40vGkgFKJnFZih707TlpxqWxlU1ZsImvB60a UaL9MSoRVzM8amDxnESVo2BGdIVv5XFTBqB7kpXhyV6qnabO9GCxawkjSRf9XUyHXILzll6LDM 5h3+3wjx2ethKWyZJyfIQUM4TpKL7RzQpqeV121x0EQCeOc/oDY+gYwdwT+F5sJIhUEQgUHLQ5 fC86EEaAYynXG5/zzLmUqXLLV39agdCQd2JJJujof380HizhBZGdVIOYE1Xy3q/lyleIVdOTId TDB9Mp9NlGQcv4brw4aaJkE5kdFXdbWAlujlcyKK4ihyfQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:To:Subject:Message-ID: Date:From:MIME-Version:Reply-To:Cc:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References; bh=zCrxOM/rgZ2ARKrg44II+ep5no5C+JWvp39ar0aWH2Q=; b=n7u3Ne9ULGM1fQ96b3zPrDlCku qXWYDP0Jnt0J3ToxX7uouwj9GXqKoKvJ4LOZrT3E8VAzN+do378gtYKqRaFr0yhq19o4gdua2fd1T 2sCBP4umiSIyRrs0A+441iAa6grsALwsA7VczxpSDYa5oAZSUKNTHGEQIIMcizIFlOg3oZKtoDXkb oSxGNO44D+G6gakvOWRVPFnncZxit9rerXgGCz7cHn5Q6oUV25q9jbEm3jzUXGot2nlHNogd5Q8Nz gDYH/mwSjJ+8zODMflTY4ZmTzphIdIR0RZkgr1ubmCnTPRSU11XbMezpmvte4c7L3nqq7HesRWoHi Y7QStEig==; Received: by zero.zsh.org with local id 1qfSUG-000OU1-9Z; Sun, 10 Sep 2023 22:01:00 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lj1-f170.google.com) smtp.remote-ip=209.85.208.170; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-lj1-f170.google.com ([209.85.208.170]:44084) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qfSU0-000OBt-Ng; Sun, 10 Sep 2023 22:00:46 +0000 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b974031aeaso65407381fa.0 for ; Sun, 10 Sep 2023 15:00:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1694383244; x=1694988044; darn=zsh.org; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=zCrxOM/rgZ2ARKrg44II+ep5no5C+JWvp39ar0aWH2Q=; b=c9UN7o6b+9Z7RXPvvrp5mEOXgqguSMeDh1POEcFqC23HnDvjvpwbijPSWfZB1BidMW AVickLZAqy8AI4sHFczXtO7gdP3yXL2fMsKUmN1d1rdAOkIvf4DnJjVsJu1GcTTknR6o BAGMBNqO7g3yFskGKp1bksAM98WUyJe6xqQBzliGB1zEA1dEs6mSP9tf4pa7hgKDXsjd tjstwr1oWlezjv1161rW7Tx+cv5BPG5EY7fVXuPHJ/LBpOjvrwhiCvogJtLxzHmuvWBk ZKxdCnIFIrsEUhpJWCxlomOepD3Mtr/+cZInx3WBllx9pIIh5JjJl3/NKWekJB6EiAjl 5xdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694383244; x=1694988044; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=zCrxOM/rgZ2ARKrg44II+ep5no5C+JWvp39ar0aWH2Q=; b=wIRk/O6ccX5XgzmgAjzH5wJVx084fkI7AbPOX4MxsgrcuJIU2Wns8FVSCtPfXTWkOa 2qDbdeBumyiU3zXA5X2waCYmOpT0Y0xiSqLKIXEROQAE4u0Ysba4pLqXUKkvLiSpw187 Y2sXbUPTymfN6jd0OsI8tL8aDubPZF4+glSosiMfcnHMCI3UtUB5YPi5rlD7Eg8fCQA7 arcDdxNrojKoZINXwY9YViZAGCXm6QP+0P4/5ejzgxXV0tThpkVbq9U5YZAREwS0lVHL iA7L4hdH8808bF+CTmWqmmDpiIUnQIg0le/q6eQvbOUcPqBGDgyVEWgq7dhhQav/+DP8 FugA== X-Gm-Message-State: AOJu0Yxzz/UW9mMxLVnciFVjPm4sUXAgPNcha1ieD8aNqmTt6dGcjS2L 7IP1+E/+VAyHBX22K9HAfmu3Dt8Dk9efewo7GBb8UZZog+WQLvdTcTg= X-Google-Smtp-Source: AGHT+IEtB3WqhjBWOWVq0YT1DEsJPIf/Yn2JMoPXIiWVYrxkV8G+OGuGulI1R49m7E4yZrihN6r+CMe6IYdT1FwvOXY= X-Received: by 2002:ac2:5e29:0:b0:500:c348:7efb with SMTP id o9-20020ac25e29000000b00500c3487efbmr5304557lfg.48.1694383243075; Sun, 10 Sep 2023 15:00:43 -0700 (PDT) MIME-Version: 1.0 From: Bart Schaefer Date: Sun, 10 Sep 2023 15:00:32 -0700 Message-ID: Subject: Should we "fix" this declaration? To: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 52124 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: /**/ void forget_edits(void) { if (!have_edits) { return; } have_edits = 0; Histent he; That's from users/29175, but we've previously followed the old C format that declarations have to be at the start of a block. If so, it should be /**/ void forget_edits(void) { Histent he; if (!have_edits) { return; } have_edits = 0;