From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <zsh-workers-return-38974-mason-zsh=primenet.com.au@zsh.org>
Received: (qmail 10756 invoked by alias); 30 Jul 2016 14:40:18 -0000
Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm
Precedence: bulk
X-No-Archive: yes
List-Id: Zsh Workers List <zsh-workers.zsh.org>
List-Post: <mailto:zsh-workers@zsh.org>
List-Help: <mailto:zsh-workers-help@zsh.org>
X-Seq: 38974
Received: (qmail 7878 invoked from network); 30 Jul 2016 14:40:18 -0000
X-Qmail-Scanner-Diagnostics: from mail-lf0-f65.google.com by f.primenet.com.au (envelope-from <schaefer@brasslantern.com>, uid 7791) with qmail-scanner-2.11 
 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1.  
 Clear:RC:0(209.85.215.65):SA:0(0.0/5.0):. 
 Processed in 0.169677 secs); 30 Jul 2016 14:40:18 -0000
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=HTML_MESSAGE,T_DKIM_INVALID
	autolearn=unavailable autolearn_force=no version=3.4.1
X-Envelope-From: schaefer@brasslantern.com
X-Qmail-Scanner-Mime-Attachments: |
X-Qmail-Scanner-Zip-Files: |
Received-SPF: none (ns1.primenet.com.au: domain at brasslantern.com does not designate permitted sender hosts)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=brasslantern-com.20150623.gappssmtp.com; s=20150623;
        h=mime-version:in-reply-to:references:from:date:message-id:subject:to
         :cc;
        bh=wfhXe4gkGE0C19p/GqmBeyX6quCz8pqzz6WEAmJdm0c=;
        b=0SNm4nkZK0qSyulv2AW78md3JyzftmNEsIkxcl+XNOs5a9od7gVccBr01JkyfXGTeV
         fIiMKMM3T5jXQ868ERoN/qQjmV2evpAvwSgzuCoX+cBZxyGZ2dPoi/UOopz3MCZ0UAWI
         LwQz+KG7Tgxabg9YFQI/jGrX8ylkvG7JBJRS8r/HqmNnoZBljvkYBe6Smev3J21Djk2u
         8nUJjiYZkZW3RZ+Y7m+7+bhmwu5OFvOIoQRQnydB73T2QmjUWctEu2cMhF/IdbKxwOlx
         x3jU2lyJ0oVSHza78NywpzT2udgjPBb2FPbFFmcHcFdfKiVJI52ogBBYQpk7SY4mV46c
         FB9Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20130820;
        h=x-gm-message-state:mime-version:in-reply-to:references:from:date
         :message-id:subject:to:cc;
        bh=wfhXe4gkGE0C19p/GqmBeyX6quCz8pqzz6WEAmJdm0c=;
        b=gO29CIGSfRWhxGZbMxiRK8XElSDaJbUdE2t4o7MOAlR4OzlpVY6+yTMUjE/vQidsnh
         kKe6kllkFMBSAxquVRqSizpD1cFP8RpvnSHYmAuIM4XAwtnj51dY+ZdqZOONsZOyPokN
         WtQb692QqhoFlsDH0p5LyHFcksCS6nzV6jZAW1pGk0SxqPhKjBBmqLMh3oqAOGfkDlib
         gBJwitnQjixgk2ZoIt55VLz+MqRykFRyTijyNJblwZp4q7SUhtVSBO2dw1mnRIEyVuI2
         OUroNt0Gb3OFjKSBXgyYfdVZz3rEgqVpTqjKHKBOwh37a5st0QskDQlhB/AglLczcU7Y
         rHhQ==
X-Gm-Message-State: AEkoouuZXqo2AFiiflykqcRTrFQwwFeKs1lMRLje9f0RQ2vtpTrsfps7oxFbAdzxbjZ3NQo0+rNjPbvv6ogZAg==
X-Received: by 10.25.84.132 with SMTP id i126mr13380511lfb.116.1469889608857;
 Sat, 30 Jul 2016 07:40:08 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <1469884317-3192-1-git-send-email-danielsh@tarsus.local2>
References: <1469884317-3192-1-git-send-email-danielsh@tarsus.local2>
From: Bart Schaefer <schaefer@brasslantern.com>
Date: Sat, 30 Jul 2016 07:40:08 -0700
Message-ID: <CAH+w=7a-OvaCh7qriz86kSXEKj7v5xHoWcKnJVdC56f_VgPjJw@mail.gmail.com>
Subject: Re: [PATCH] _widgets: Complete zle-* widgets too.
To: Daniel Shahaf <d.s@daniel.shahaf.name>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Content-Type: multipart/alternative; boundary=001a1141292efed0b60538db5763

--001a1141292efed0b60538db5763
Content-Type: text/plain; charset=UTF-8

I don't think this is right.  Those names should be completed only if they
have already been created with "zle -N", and it is not appropriate to
autoload add-zle-hook-widget in the generic widgets completion function.

On Jul 30, 2016 8:13 AM, "Daniel Shahaf" <d.s@daniel.shahaf.name> wrote:

> ---
>  Completion/Zsh/Type/_widgets | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Completion/Zsh/Type/_widgets b/Completion/Zsh/Type/_widgets
> index fdab281..0e7f491 100644
> --- a/Completion/Zsh/Type/_widgets
> +++ b/Completion/Zsh/Type/_widgets
> @@ -2,8 +2,14 @@
>
>  local expl pattern
>
> +local -a fake
> +autoload -U add-zle-hook-widget
> +add-zle-hook-widget -h >&/dev/null # sets the zstyle
> +zstyle -g fake zle-hook types
> +fake=( zle-${^fake} )
> +
>  pattern=( -g \* )
>  zparseopts -D -K -E g:=pattern
>
>  _description widgets expl widget
> -compadd "$@" "$expl[@]" -M 'r:|-=* r:|=*' -
> "${(@k)widgets[(R)${pattern[2]}]}"
> +compadd "$@" "$expl[@]" -M 'r:|-=* r:|=*' -
> "${(@k)widgets[(R)${pattern[2]}]}" "${(@M)fake:#${~pattern[2]}}"
>

--001a1141292efed0b60538db5763--