From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 1406 invoked from network); 17 Jul 2023 15:22:58 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Jul 2023 15:22:58 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1689607378; b=nbrw/6kS94tQfqU+j+uSmhrQIDRzuysf9bUhbVB8sa6pICvTmytDPHE6OFYW8ygY/jolgnq4uE p5p3cn73/501GntMjAqmp86CWZrr/KWr4OcLjsxxsRG4K2HjXQd5i1PYdMXSzh7PqDFVBTdSVU 5r6mbJ1G5tY43ZSiOTOiY+XLGanU9xywSdla9uhcKhb7GHy+B7B2KEXVonCI/58a2DVB3BWuuX sNdV9pW1Z8QqHUMIBf/NWbibjAsdQSRKjaMgZE7keQfg2Y5y1NzSZ6ewg5rsd2uCIOdLGTVL9j lJhfoi7BlekRbE6PJkxWD1WEdNoIY2GJyBzf1ragSLRibA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f41.google.com) smtp.remote-ip=209.85.218.41; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1689607378; bh=DR9W/ATxBF24+VrLj8G2yfIBlIBafZSta8+K9u9WLGE=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=G3WvepNVt1D05Gx2JCrKdj1ykJKr8C6o7UsYYN8xmrU1akpYS4PPZBnM2hy1bqpJdlIsXDPtYT VIv0iTRNvSfMqOptC6LmGTBY3nQ59k1mhOd4kbL9GM9dvhD0aiMYsArmvZ0HHdy4Lh/vISV+46 fl5XARBgqe3DjWdwt+Gx5uuYn83j5iLW7FHmLeeNn2SoH0SaneAci5fTHm3HBF2jnkw0lPqHJ4 kzYTCRfR3prII0HFI6Y1TJs/yW4GGLhgNIYFJApMXe3CLgINtWrS+EP+3M8RcDzCyR8FCj+fGd i0L+H8P2//GQFJaGUMamobR83o+nDc2Hjw4xQ8D+WovRJw==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=8UmiV9nAfM8OzOJmzWwEw7JQR3h9HNILVJWmQ8SSlF0=; b=oYrSKbwXMTWm4xDRGYGBXQQmTB 5OmcO0fVX9GsiORxJZPF21XzW1ktjDVx3kFE8H7tWjEM6VLsxcgsDJn7gXRfZ4C+I26ZAG9az/aEw lY4of6kPxYk0ZSvtgz3K1W8TkEEZD0Tx8h50IJZ32GVCZ5TX1w0TB7P6pm/4Mm/kJqqOV9ZA/nXbu 4IP7D93MJSwcLbEp/lwcQLpsmIOfibRU7QfDRoJQyl4Vftmg6gUaX1+F8ppPZ32NPzQoXaTDCqLQG DgDbdgOOXmCGWPYi4yhsr+eTLtJflg7xm0XXQLXvuqyZxV0IYXc+zoLzElpRp/1ctURF7opDaAqBG MzAbzypg==; Received: by zero.zsh.org with local id 1qLQ3t-000CHT-Um; Mon, 17 Jul 2023 15:22:57 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f41.google.com) smtp.remote-ip=209.85.218.41; dkim=pass header.d=brasslantern-com.20221208.gappssmtp.com header.s=20221208 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f41.google.com ([209.85.218.41]:62577) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1qLPyW-000BqE-Oe; Mon, 17 Jul 2023 15:17:25 +0000 Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-991ef0b464cso1229518866b.0 for ; Mon, 17 Jul 2023 08:17:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20221208.gappssmtp.com; s=20221208; t=1689607044; x=1692199044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=8UmiV9nAfM8OzOJmzWwEw7JQR3h9HNILVJWmQ8SSlF0=; b=KLjYMsVTijmfdSwLo5wCFcxgy/FK/GJQWnQBctq4mnAkmig8jq7dLP0ByngKwYlQ0b HOmvQGgOBUXLz+Ea1agCAz/mHleFxBQkHkDZoUDm1UWgDm+dXfgHDfuqd2bFWJtY40hq 6zRQETe597mUg9LqvoAOlTrPnu4SlIYxvxuX675M/wSK4Ieyfa8EnubkCnaoCimyYXXk Vzp7yRmXlq5P+zIVJCdyzlYgYJ9QPLexAPVf/VzMab+/7x0udK0wVlPycsoXiVIxX5kx FvIHXZTZQmpewoo5BQOeQ60K5lBt6qICv/dE3jR/sFMceZqFmP24QMUYC49f3jAUMlao OiNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689607044; x=1692199044; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8UmiV9nAfM8OzOJmzWwEw7JQR3h9HNILVJWmQ8SSlF0=; b=fCjrbH5L7nKOs2xXeGhM6nF/+AzSOut4jZD/Ys2EG3jWUbh8F8+rLXB8x6oj9eNREE PKRwb5ta9V1MjScciyLZeL3N69Ww2L1/uj1bFgEl34inSDlRSYf0xbU3Itrf8YKNDxib nejhjF9I1JhbFP5lY5k+w67BysPpDznzfyieri2E8efd31NuBC7RrCT1dojZI8OnSDcg 36VTbTiVIomW0Pt+eYmk+9IulSUcFa4sV2eNI3aM03JJOM0TmKLPHC7pElqxbNKzXxQ8 BHmOdbvxJaAscNVgg/D2L8cQ/qb+00tWbXu7sG8lPJjn5Na7LXPFtL2UGK89HkDpYsBf y2lA== X-Gm-Message-State: ABy/qLYChfpOk3pqeLYkSb/jxceuBLcUFG5uAWh5vhCOD69UpVZLrD3I EcOK2A1A66srNxYHa87PJbZXA8BONLj8SfrVhGe+4K8s/l+jDKdq8f0= X-Google-Smtp-Source: APBJJlG35PgtMyePV+gStq4iOUlpA3nKVVUSpuX35dU7EcEqW5bCejrBcf5Qp38/72Wegzd4T71fGc2dVZrcPXHFpx4= X-Received: by 2002:a17:906:9e:b0:989:1a52:72a1 with SMTP id 30-20020a170906009e00b009891a5272a1mr10747914ejc.28.1689607043986; Mon, 17 Jul 2023 08:17:23 -0700 (PDT) MIME-Version: 1.0 References: <422608219.9324398.1673947338127@mail.virginmedia.com> <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com> In-Reply-To: <974250f6-d143-4543-872e-05c72f67a98c@app.fastmail.com> From: Bart Schaefer Date: Mon, 17 Jul 2023 08:17:12 -0700 Message-ID: Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw ` shouldn't change $LASTWIDGET To: dana Cc: Zsh hackers list , Peter Stephenson Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 51947 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Sun, Jul 16, 2023 at 3:29=E2=80=AFAM dana wrote: > > On Tue 17 Jan 2023, at 12:00, Bart Schaefer wrote: > > My concern is that the Thingy pointer becomes invalid > > I think this was justified > > I've just tried running a new HEAD build for the first time in several mo= nths > and found that back-spacing causes the shell to crash. The patch from the start of this thread has never been committed, so is not directly related. That is, if the Thingy is invalid, it's not $LASTWIDGET that's making the bad reference here, so fixing save/restore there probably will not resolve the problem. In your backtrace I see _zsh_autosuggest_widget_modify and _zsh_autosuggest_invoke_original_widget followed by _zsh_highlight_widget_orig-s0.0000030000-r21548-backward-delete-char and finally _zsh_highlight_call_widget causes the actual crash below unrefthingy(), so I suspect this is a reference-counting problem.