From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw <widget>` shouldn't change $LASTWIDGET
Date: Tue, 17 Jan 2023 10:00:43 -0800 [thread overview]
Message-ID: <CAH+w=7a4x+BDM=cxAtu5AsryF0Do9=nO5P+11uR2U2M3VcYeYQ@mail.gmail.com> (raw)
In-Reply-To: <422608219.9324398.1673947338127@mail.virginmedia.com>
On Tue, Jan 17, 2023 at 1:23 AM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
>
> > On 17/01/2023 00:01 Bart Schaefer <schaefer@brasslantern.com> wrote:
> > Is this good enough, or is there a need to consider that the handler
> > might delete the previous last widget?
>
> I think just keeping
> the old name and letting the user deal with it further is good enough.
My concern is that the Thingy pointer becomes invalid. If that won't
happen, nothing further is needed here. If that COULD happen, then
the implementation of $LASTWIDGET needs to start storing the name
rather than the Thingy.
next prev parent reply other threads:[~2023-01-17 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 15:06 Marlon Richert
2022-11-16 18:24 ` Bart Schaefer
2022-11-17 13:04 ` Marlon Richert
2022-11-17 13:28 ` Roman Perepelitsa
2022-11-17 16:18 ` Bart Schaefer
2023-01-11 7:45 ` Marlon Richert
2023-01-17 0:01 ` [PATCH] " Bart Schaefer
2023-01-17 9:22 ` Peter Stephenson
2023-01-17 18:00 ` Bart Schaefer [this message]
2023-07-16 10:28 ` dana
2023-07-17 8:42 ` Peter Stephenson
2023-07-17 15:17 ` Bart Schaefer
2023-07-17 15:52 ` dana
2023-07-17 15:57 ` Bart Schaefer
2023-07-17 16:57 ` Bart Schaefer
2023-07-20 4:01 ` dana
2023-07-20 4:25 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7a4x+BDM=cxAtu5AsryF0Do9=nO5P+11uR2U2M3VcYeYQ@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=p.w.stephenson@ntlworld.com \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).