From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 3334 invoked from network); 17 Jan 2023 18:01:32 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 17 Jan 2023 18:01:32 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1673978492; b=U7ErWGnIW4co9CSMbp6Sy56tzNA2yo4DonY23959l5AOdkAIK+0HfbLdL3lsCYVr0uXDlZeOnB MktYUUXkQH4cUQ1dfn4Nk5/8DKviGdMUG6n0ALCzBf90Ul4kFR7bJ5VhJ3MrzEKV1qJpldAky2 IDwInH3vJ5F07RN93TSoYSS1MTT6aJrpre+P+0KBcfsBIOBK/rR2u/uyh/DrICP0JrJ+5Uj4o+ X/p8K8QiM7uyvr8CkP4NuDdflJdKN4S3ZSkSkL06ZvBTXap+4l4LLAuaDfnzAKgYJWpLacN3fw cccxiaA+Ip/yv2U+NW0zmDP0+Dzcdg32xyfd2pQMZwlQaQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ej1-f53.google.com) smtp.remote-ip=209.85.218.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1673978492; bh=SQQiHHdawhwPy7hXtAf1meqXKytgXRjKbDKh5OdSMr4=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=IyT2y3DDHIHqJCDgBhvWLfjh5Vz/uLb2gM6OoNbH26XSbzc3vNCn7fAz57xuFDcf99MDseUhIm UwFixmnsuMQrFUn1mvdACVUIIPYaGeJL8mGlWYIvhMV1ADtZViaGxbSMOBMyeVU+xbIQklxt2U EvJrqclGcmWCbOLP8bJTQ5YiOCjD//gZG/vrzCXUehUrCat1zG9DcxNqA6lF2RJETYHt6YC5HJ 4g1MC/ZZ1AxYF3IHmEluGJlFjCTylaZdesc/0GMS31OFDw559RExUEwgxZZBCpwRw/F0ksDBlL vXE/8v51ovCZQbQDCLMR0b61o8HKEFanTwOWxTODJl0UvA==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=x0s1mWxLWX/0dlZX92jJb3zCpns54oEfHdBBPf4nNq0=; b=Uo6ddpCHUFDKbnj968hk2H0YP4 DddRSbHT16bk/W0FOmntZiTYlxKwicsIEnA7pj7FDqnPfiIlvsjOg00JFjvzWC8oAzj6HuAkGIwmh qW9WdVkrbsVnNLIPecFJjwpPnYkVpsC/gQHhhhCJO9dOPsn4lRNko+WK/mzzvAGm24TEEWlaceO0K g3r8cOlfc3rAxRblGXqH2t7ji8fCTxOjArb3zUQ+7DbrCybU2qQ/NPfFoiEy7IA8CdOKitVDMVtTE wUiWpA6iJlQZeWbqdS4lrwzl3s2ECR4TuDjK3DKfooFbdsuVqsAH9FzaWvDKl8YtzKeTHASnrCvuV sDBep+tA==; Received: by zero.zsh.org with local id 1pHqH4-000ChE-U1; Tue, 17 Jan 2023 18:01:30 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ej1-f53.google.com) smtp.remote-ip=209.85.218.53; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ej1-f53.google.com ([209.85.218.53]:37584) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1pHqGV-000CN7-ME; Tue, 17 Jan 2023 18:00:56 +0000 Received: by mail-ej1-f53.google.com with SMTP id ud5so77290649ejc.4 for ; Tue, 17 Jan 2023 10:00:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=x0s1mWxLWX/0dlZX92jJb3zCpns54oEfHdBBPf4nNq0=; b=Ze2vR6eX3gn6zI1LI+i6XFWOByNX05kbwIjiNKJBOWkJwu/MoAd55QIg2RyqI/4Xf1 /FuVf/SJIc2ZG56DtVxAYy+MJ6pnlLp06COj2KScjiXnOLwiDgKE6M8tMFT7TsAI4YwH 2VrGVbed7qLFggX6uCJMvlVWkFCm5TLfHXtJP2/dyhkpbEPy848AOFQtzi7zyDxk18Hz txnvVLviM+Fwk9jH8zcUmyS1LFcjBy+ldgSYR6EwEf33o9qU/ogYbRQaj2n/9ET1+WFK 6JJrEvQC3p1gdeMrED68Am9IP5tq3EFG8qmtFgbIH73BEe7fNXuVxhi711/9QzVl45Rw w4AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=x0s1mWxLWX/0dlZX92jJb3zCpns54oEfHdBBPf4nNq0=; b=7kB1qqgGVwlH6/C6Upyl5bRDz5yCTOsimW21OWpzlGXMeCE1vLn7eqXPCUbN8EmzPp Vqu7mm+Ax7awlgPe/pvMt9BQrAU4z4y5NhjgrIgDHgI3eLecgITtY29XlzyXjKpBry9t uQbcO2lx5d7i64JDooJZ2WxIM6g08Ci7OWy2yS7EUy0dndjw7PqZdLuguSU1IxMDiBzI aUl7NAcEhTeYQy50erdHQq9m37xzRW9xYMVxGerDwnIiVv8KpJSyvfD/XsZySqrG2Km9 Lmm9LSQB0/YUiO6CEglVfobaaOdcPBAZgxjWyDZ7ikonl4RWVFSwTjkjN4AgUhCDjN/7 VIWA== X-Gm-Message-State: AFqh2kqD3VeOtCQisewNy7EwGYxAMDLJUrISRYNnmSDKBTGkpcaHjqGj FH6ZgnssmYiCVjc1fvfoF7ZPj3G9AuGnOO9GW6V34w== X-Google-Smtp-Source: AMrXdXtzIG8c7e4uD2zx8YV80b49L9Ujs9MTy+3nN3SQ904i2mbwL685Z784C2vALrwmHz7G1peA6SkxpZfvGNN8Yl0= X-Received: by 2002:a17:907:774d:b0:846:2f3b:13af with SMTP id kx13-20020a170907774d00b008462f3b13afmr400009ejc.214.1673978454479; Tue, 17 Jan 2023 10:00:54 -0800 (PST) MIME-Version: 1.0 References: <422608219.9324398.1673947338127@mail.virginmedia.com> In-Reply-To: <422608219.9324398.1673947338127@mail.virginmedia.com> From: Bart Schaefer Date: Tue, 17 Jan 2023 10:00:43 -0800 Message-ID: Subject: Re: [PATCH] Re: Bug: Callback to widget set with `zle -Fw ` shouldn't change $LASTWIDGET To: Peter Stephenson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 51315 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Tue, Jan 17, 2023 at 1:23 AM Peter Stephenson wrote: > > > On 17/01/2023 00:01 Bart Schaefer wrote: > > Is this good enough, or is there a need to consider that the handler > > might delete the previous last widget? > > I think just keeping > the old name and letting the user deal with it further is good enough. My concern is that the Thingy pointer becomes invalid. If that won't happen, nothing further is needed here. If that COULD happen, then the implementation of $LASTWIDGET needs to start storing the name rather than the Thingy.