From: Bart Schaefer <schaefer@brasslantern.com>
To: Vin Shelton <acs@alumni.princeton.edu>
Cc: "Jun. T" <takimoto-j@kba.biglobe.ne.jp>,
"Zsh Hackers' List" <zsh-workers@zsh.org>
Subject: Re: Y01 Test Failure on Arch
Date: Sun, 4 Apr 2021 11:27:26 -0700 [thread overview]
Message-ID: <CAH+w=7a7Pm4JUPLUYvDnVACfbpZTOB+RXF7281CNasRH9iSbKw@mail.gmail.com> (raw)
In-Reply-To: <CACeGjnUdhkOfFysohkDxZP6=-dBwv_Rhe0Y=fJF62UEWM5C4OQ@mail.gmail.com>
(I'm on "vacation" this week so won't have as much feedback as I have lately.)
On Sun, Apr 4, 2021 at 7:01 AM Vin Shelton <acs@alumni.princeton.edu> wrote:
>
> Also, why was the test change necessary in the first place?
The test was not checking the correct thing. expand-or-complete first
invokes the built-in expand-word and then falls back on completion,
but the patch updated the _expand completer (which was never reached
after expand-word produced a result).
next prev parent reply other threads:[~2021-04-04 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 13:40 Vin Shelton
2021-04-01 4:05 ` Jun T
2021-04-03 11:32 ` Vin Shelton
2021-04-04 4:05 ` Jun. T
2021-04-04 14:00 ` Vin Shelton
2021-04-04 17:02 ` Daniel Shahaf
2021-04-05 14:58 ` Marlon Richert
2021-04-06 4:23 ` Jun T
2021-04-06 11:38 ` Marlon
2021-04-06 9:53 ` Oliver Kiddle
2021-04-04 18:27 ` Bart Schaefer [this message]
2021-04-05 0:39 ` Vin Shelton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7a7Pm4JUPLUYvDnVACfbpZTOB+RXF7281CNasRH9iSbKw@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=acs@alumni.princeton.edu \
--cc=takimoto-j@kba.biglobe.ne.jp \
--cc=zsh-workers@zsh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).