zsh-workers
 help / color / Atom feed
From: Bart Schaefer <schaefer@brasslantern.com>
To: Peter Stephenson <p.w.stephenson@ntlworld.com>
Cc: "zsh-workers@zsh.org" <zsh-workers@zsh.org>
Subject: Re: [PATCH?] Re: Autocorrect for commands with a hyphen (dash) in the name
Date: Sat, 23 May 2020 14:18:14 -0700
Message-ID: <CAH+w=7a82S7rpnTSZ24MzpXrNWCtRQ1ZpQSxeXvu_Yz4NZig=g@mail.gmail.com> (raw)
In-Reply-To: <b20887d9dee281c346812e19b41b22f6d5cd7b97.camel@ntlworld.com>

On Sat, May 23, 2020 at 1:31 PM Peter Stephenson
<p.w.stephenson@ntlworld.com> wrote:
>
> On Sat, 2020-05-23 at 12:54 -0700, Bart Schaefer wrote:
> > > > >
> > > > >             if (*w == Tilde || *w == Equals || *w == String)
> > > > >                 *x = *w;
>
> Yes, I guess you need to skip over those before untokenizing.

zle_tricky is actually re-tokenizing them again after untokenizing but
before calling spckword().

> That matches this line in spckword():
>
>     if (*t == Tilde || *t == Equals || *t == String)
>         t++;

Right, and then it uses those tokens to decide which hash table to
search.  OK, I think that answers the question.

> But still not sure we
> actually need two separate token-based interventions.

Which two are we talking about?  You mean you think we can unify lex.c
and zle_tricky.c inside spckword()?  Yes, we could move the whole
thing to utils.c, and then spckword() would be expecting to take a
tokenized string rather than an untokenized one.

  reply index

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOoO2vg=-9P7v=ATOzrbh6VF35o_xzK_-yF+EA6OgTHsQBik-A@mail.gmail.com>
     [not found] ` <CAH+w=7bKpm7GO2ZhbA5Apr0sBDz5=kmX1=WK2X0nTcWxpkHPPQ@mail.gmail.com>
     [not found]   ` <ab8b7655-83e8-45b2-889f-043314faea62@www.fastmail.com>
     [not found]     ` <CAH+w=7aqAO37qpSvtmJXMPWq3zP=pUAZCe3i-BFyn0knRmFjVQ@mail.gmail.com>
2020-05-23 19:33       ` Bart Schaefer
2020-05-23 19:44         ` Peter Stephenson
2020-05-23 19:54           ` Bart Schaefer
2020-05-23 20:30             ` Peter Stephenson
2020-05-23 21:18               ` Bart Schaefer [this message]
2020-05-24 17:11                 ` Peter Stephenson
2020-05-24 18:39                   ` Bart Schaefer
2020-05-25  5:46                     ` Bart Schaefer
2020-05-25 16:35                       ` Peter Stephenson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH+w=7a82S7rpnTSZ24MzpXrNWCtRQ1ZpQSxeXvu_Yz4NZig=g@mail.gmail.com' \
    --to=schaefer@brasslantern.com \
    --cc=p.w.stephenson@ntlworld.com \
    --cc=zsh-workers@zsh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

zsh-workers

Archives are clonable: git clone --mirror http://inbox.vuxu.org/zsh-workers

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.zsh.workers


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git