From: Bart Schaefer <schaefer@brasslantern.com>
To: Zsh hackers list <zsh-workers@zsh.org>
Subject: Re: pipeline that cannot be interrupted
Date: Wed, 27 Apr 2022 13:29:47 -0700 [thread overview]
Message-ID: <CAH+w=7a9j_1b6n-5wvgkazNmXOG208U42nFmmV6Jmxckvo7Hdg@mail.gmail.com> (raw)
In-Reply-To: <CAH+w=7YTOoez2yrOeUXVyxC3P=M6yV=7z1gehUadvjC=m-K-8A@mail.gmail.com>
On Wed, Apr 27, 2022 at 1:07 PM Bart Schaefer <schaefer@brasslantern.com> wrote:
>
> I don't have time right now to dig any further
OK, I fibbed a little ... but I really don't have time to chase down
what is really going on.
> zsh-5.5.1 - a single ^C returns to the prompt
zsh-5.6 - a single ^C returns to the prompt
zsh-5.6.1 - broken as Vincent describes
That points to workers/43409 as the culprit, but ...
> zsh-5.6.2 - first ^C jumps to R2, second ^C to prompt
... that means workers/43446 partly fixed it?
> zsh-5.7.1 - broken in the way Vincent describes
And workers/43535 broke it again.
Naively, the following not-really-a-patch-yet fixes it, and all tests
still pass.
diff --git a/Src/jobs.c b/Src/jobs.c
index af0a1233d..8ed2219bb 100644
--- a/Src/jobs.c
+++ b/Src/jobs.c
@@ -1476,7 +1476,7 @@ addproc(pid_t pid, char *text, int aux, struct
timeval *bgtime,
* set it for that, too.
*/
if (gleader != -1) {
- jobtab[thisjob].gleader = gleader;
+ jobtab[thisjob].gleader = pid /* gleader */;
if (list_pipe_job_used != -1)
jobtab[list_pipe_job_used].gleader = gleader;
/*
next prev parent reply other threads:[~2022-04-27 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 0:36 Ctrl-\ while executing a pipeline made zsh quit Vincent Lefevre
2022-04-26 0:44 ` Vincent Lefevre
2022-04-26 1:24 ` Bart Schaefer
2022-04-26 3:00 ` Vincent Lefevre
2022-04-26 4:05 ` Bart Schaefer
2022-04-26 9:07 ` Vincent Lefevre
2022-04-26 9:18 ` pipeline that cannot be interrupted (was: Ctrl-\ while executing a pipeline made zsh quit) Vincent Lefevre
2022-04-26 10:07 ` pipeline that cannot be interrupted Vincent Lefevre
2022-04-27 20:07 ` Bart Schaefer
2022-04-27 20:29 ` Bart Schaefer [this message]
2022-04-29 0:24 ` Bart Schaefer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH+w=7a9j_1b6n-5wvgkazNmXOG208U42nFmmV6Jmxckvo7Hdg@mail.gmail.com' \
--to=schaefer@brasslantern.com \
--cc=zsh-workers@zsh.org \
--subject='Re: pipeline that cannot be interrupted' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.vuxu.org/mirror/zsh/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).