From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 24374 invoked from network); 29 Mar 2022 03:49:51 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Mar 2022 03:49:51 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1648525791; b=ApiDwLdkYwAHyiOtpQL+JTsCbg6o6uGwTGcwXPwjV5EE7o7CJ1J0GMqImjdqtJqMXvp7pZnIAn Hxwh1UKSNfPlErMsQzQJjEurDDy8u8LWREMC2LMjJ+P9t3nn1yyaJ7/cuQAK3uXv6wMb/2m0pZ AZr6ozQ6cpCrMelZfcbBks0uWpO59qELigDQbp3FIpVRWwcqtkO7ZEv8vKb6Ldu0iR7YBgxih3 eB0r9Um+UXXZcmYKUfXRh25QDEQRu/YQ45i1yISs6EqfOrrk3YGvW6CqmszCRRK1AmjaT5XydE Vv88CUaHrRlaGTih52I0d8a0BjpfO+Jdyl2eBbIMsYZs5g==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-lf1-f43.google.com) smtp.remote-ip=209.85.167.43; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1648525791; bh=q3pbOsX558TJGOdmIitq4tgQf6P4kiRREvgasMpvMMU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=Rr5YobaBo/Z1pkAcM2l9Tp1KmPj+WwdYHlxnyCkt3hbTWcrMKy71fxmqSTtJGh+DSQI27kqEw2 mu0EP62oK85yaGo9zF2y6omVq+V8v9iQuGyY17+mh/AFgXyPabMMHG2twn/XqCWr8R5dBToJ1l UYe6TK+BhuVGMOOD3B/QtRTWZGdB1/ReOI+BcsbT+OlZr44qzuuGTVX7Pb4MDh1rq6GJMGA+MA 0cufqazaX6m9+YEn1cfRj7tlYdd07t0xZhDxYtzTXZJH9Nej3m0Usvy2ALK7nqSOghsA8r928q jqb3q+c3JW4FBJVTYxFKtwbEvTo09MgpXky0GrrtvEsJjg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=4iUou8FuPz4QkKEwY0s0qTBlRNlg/zNzxk4AYh+EO4o=; b=eoctby52Xv4pTOqrOeJ+QDmmsA hCtt+rTHMAuQJqXQNsy2DEJG7eWkX+n6u43rr6hriVsWg+2aXR9tT/5+Om8AAxLsgp2vUxbvuxfgn zYs1D9s9Q6eMpXEKr8s48k5QElPMo3nSfpGnXuPjhCD9Q7QB1BMmQWwKN9PXzHC6gjy73AAOTjagw bFNgTTgsOUJ12zxzCMx1tAsG2rficsN1f52lKe8akJdF9vp3xWTharUWkMa2BfJpuIieYzkSVOqnf TvJV4eeUyqA4S+nt6MqdWKXHFkTZsJX324OFjNdPwX7K47oO2nVi+d8CL2SL9mtoIouOQQ6AIJHZh qB7004Ag==; Received: from authenticated user by zero.zsh.org with local id 1nZ2rd-000H55-LG; Tue, 29 Mar 2022 03:49:49 +0000 Authentication-Results: zsh.org; iprev=pass (mail-lf1-f43.google.com) smtp.remote-ip=209.85.167.43; dkim=pass header.d=brasslantern-com.20210112.gappssmtp.com header.s=20210112 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-lf1-f43.google.com ([209.85.167.43]:40790) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1nZ2r6-000GkO-5V; Tue, 29 Mar 2022 03:49:17 +0000 Received: by mail-lf1-f43.google.com with SMTP id t25so28085204lfg.7 for ; Mon, 28 Mar 2022 20:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4iUou8FuPz4QkKEwY0s0qTBlRNlg/zNzxk4AYh+EO4o=; b=5zzuIE0+MqkmMjpuKrTzFllfw6AzzGhP88Gk0JFP6N4aEiyijBPuuoo/6xx3G8fLO6 UEOmgjpA72h0FPGHM4jNQmvRG4xmh4IpSZZzvI2HYmIC538CMFGb2bzWfEi4LCjBEPz+ CcYz3FhMVQOw34Wa0C1GLmfe9XfWXIHedae7UNc8B95tLMn9/IJgO4vfVFJh2UdMgY+j tjus5rTFPJHY+dpkel/fFJyEtiOQKkDjItA/hiNISkbqgTmbyfLCJJA87gOrGm9PJA99 L89ENkj+3jmNGSG9OERbqTh9yVPm5RYrnp1TJ/J4YqDZDgICQbl6VHijBImFLg55Pg3f AAxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4iUou8FuPz4QkKEwY0s0qTBlRNlg/zNzxk4AYh+EO4o=; b=eu/pLX8arWc42YPXjW+oQUXO2BjkC/dp3rnejLpCPhME+sgaZmUxZmWZNePsEy76Fz Gc5EsVudUdtXjoqA8FzbxtA5L0WwogSJf1rhi+w7BD3XKfdEq+0uZCEUJN6kQe9ZWH91 c12NQcI8lhL+ViBltZWwnzSchbyxLuYGQG6GLo1Fg8f3EVw7LuPxD5WrLZ5KcVz+Xn7h ziv9GGXrBzvHfkQmAfD2Fz+QDaZHV64aVVc9b6+l7+y1dMqBwB03NqUNTk5/GJy3EBB6 HC4RPqg66aEbk84ZbJMTgJJNcHELq/Qf1P+wHqVLWlWVzi128FOiXjG+l5Y2jvtGT3lO jgcw== X-Gm-Message-State: AOAM5323uUL3gQTIyjxLuOdd6kaiWoXJLX6pgsbScyn4C/SmWXk/7PKq W6XeA9I5OrOgI8WAZ7eijYOcMvrlF36lB6OfkPvnLAD79A/zeQ== X-Google-Smtp-Source: ABdhPJxnDttDtQEDpBOmFnmxpJ7HdxnguJvPaNjDOU9XNEEC61JaFQzZF8hpVOyVbrJO78xZGC/naLdDXOoQagPXwOo= X-Received: by 2002:a05:6512:3994:b0:44a:7125:c689 with SMTP id j20-20020a056512399400b0044a7125c689mr770916lfu.166.1648525755226; Mon, 28 Mar 2022 20:49:15 -0700 (PDT) MIME-Version: 1.0 References: <1409134730.698961.1648457237653@mail2.virginmedia.com> <1613542531.711035.1648478945973@mail2.virginmedia.com> <1830314137.713553.1648484054367@mail2.virginmedia.com> <1e36a19a15237624412bc502ebfcf99034dfbb79.camel@ntlworld.com> In-Reply-To: <1e36a19a15237624412bc502ebfcf99034dfbb79.camel@ntlworld.com> From: Bart Schaefer Date: Mon, 28 Mar 2022 20:49:03 -0700 Message-ID: Subject: Re: Crash on jobstates since workers/49783 (commit 6a8aa2a) To: Peter Stephenson Cc: Zsh hackers list Content-Type: text/plain; charset="UTF-8" X-Seq: 49906 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: On Mon, Mar 28, 2022 at 12:53 PM Peter Stephenson wrote: > > When I simply print > jobstates and it does crash I'm seeing what looks like the process > number of the subshell process appear right before the crash (i.e. it's > typically one more than the sleep that was just started). This? diff --git a/Src/jobs.c b/Src/jobs.c index 18e43f03c..83ffdbde5 100644 --- a/Src/jobs.c +++ b/Src/jobs.c @@ -1718,6 +1718,12 @@ clearjobtab(int monitor) /* Don't report any job we're part of */ if (thisjob != -1 && thisjob < oldmaxjob) memset(oldjobtab+thisjob, 0, sizeof(struct job)); + + /* oldmaxjob is now the size of the table, but outside + * this function, it's used as a job number, which must + * be the largest index available in the table. + */ + --oldmaxjob; }