From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 21086 invoked from network); 16 Jan 2021 18:35:01 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 16 Jan 2021 18:35:01 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20200801; t=1610822101; b=TsiL2qAoIQp6tlwExCxvsHE7ggM3Tx3VIl0hD1VIZIQMEyzq7UXWfmIfbVCInY/EdHBd/dyLrg Qy0Mvnu4MnK27Fj2TTI30HQqH8loXo/TFx4h1Va7G+eZA7DAkkWch1I02EhQyrMcnDrHkGxdSL yRer/VuWhvEET0/lEhmPlQkIs4o8gals10nMK91uSvPqY/zHVj+ZKE47Pd9xVPHRIbdiHpsYsM r29gEur0bB2xvm6XgH8HMCEFbFBH2VW3bK5nj0khf12Ry4jKnQpNh3yQ7p6O3jqp42ej4knZKr Z58ihwBjwQF1vIzgj5AfTdP0P5djAGkZHyUiZeqleCYWyA==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-oi1-f173.google.com) smtp.remote-ip=209.85.167.173; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20200801; t=1610822101; bh=M9VmMHmlYkKOu35hFt3yX9dpAnWh92dV1bVm27icMtU=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:DKIM-Signature:DKIM-Signature; b=pfhu8MREm99SGUlssRwPJFOJFzOs8Cc3/9lUt7bkwYB1Ke3sxlR6BaSN9kSwK06eDL87M/eUoC n0X3FJlb/p5IS6wI5hRRf46kkthHAGpKzITFj4Cfhv76kCckDMgky7Xr/MRloZbtb+bVDUbIvd t0MBvdOkrCx/rX3nVAXbYx/s5/EqpsJy522ssvzCSyN645xBzKT1zgvEz7De/L9ji0LJ96Do1K T8hocvlpjk7/f+fd35YyKas93egTt2GAChxmrYqCNWW3NUqi7NPRJ+kTGLmWMQ1Px/UX4Q8gMk aD6sieMKsGt2zezA5MftoiU9QFDBehmrVvvvH+dKA2lcMg==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20200801; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=fb9qUHeH22irizJos3JFTL867Q8Q+wT+tF+JAZx241M=; b=OmdoySWICe66NNL8NjoAGskEVe 9IG1A2FxbcLLxrtHqgcHPGm0BVEs24tQDLzs6urGIp35jR6A+bK8I5tx31oK5TJIDdsV/pXGchTDX Sj3U7ZQZz6C233Fx3vkyXs2vzm/3ObqO+NgkJyN1Vz6L2SThuY1iZNg9Y30LHfuTgNy/xpw1yYM95 PDgViYmjToK153JsXYoNA4gifmnmiPLTmho2siYQfyO+RJ3HNVE91sl1MkYJZH8Hk2V3DZgiPQ/BW sU60yfjIBgFyDtcr/2QLzB2HuyZ6ctaQDqkcr+s7nN7U6YocPz3/gGH4wkr2zHVEVtWazNIkjNzaP bu21rIvA==; Received: from authenticated user by zero.zsh.org with local id 1l0qPb-000OMH-F8; Sat, 16 Jan 2021 18:34:59 +0000 Authentication-Results: zsh.org; iprev=pass (mail-oi1-f173.google.com) smtp.remote-ip=209.85.167.173; dkim=pass header.d=brasslantern-com.20150623.gappssmtp.com header.s=20150623 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-oi1-f173.google.com ([209.85.167.173]:35739) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1l0qPM-000ODQ-86; Sat, 16 Jan 2021 18:34:45 +0000 Received: by mail-oi1-f173.google.com with SMTP id s2so13291083oij.2 for ; Sat, 16 Jan 2021 10:34:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fb9qUHeH22irizJos3JFTL867Q8Q+wT+tF+JAZx241M=; b=GbG+hzBPf0G2wYHKtexYDmXrIpgT07fjlJqCsdot6oldBoZzGXHeMIRznEDLrH7L3V JkngKSdEAS6At6wd04rkE36JekZsK7tT43wtdXn9fIT/8dvuOYMioR3huH3M5Z42q1R4 ROOb0kDdWYLFRFYXBiDQKRv/fu2FsponC7I1W1DNzYz327ZNRaUqGgVLZ1FE1UJ9I0k9 AnIdnsYeoY6CqI25Cy+DhiTPG1uO75GXMvaST6Nkr2OyWt+D9wX0t8yul7/sDj7JVzXU ua5fs0OlhdxaIjOD7QynvVYdpABVEgyiEqp/w3cMObGM2qUrsIFNBozXnHU6IWFOGg22 VzNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fb9qUHeH22irizJos3JFTL867Q8Q+wT+tF+JAZx241M=; b=jlqraVSs6cFBoqGLVBTVvP8clvGXNjXz9Fl9+swGvvp+wFBFPdDFjw7bXAEIGVshW6 LZOnTgLYZhpxSRD4l1LHb1vLAQS8Bbh1BLicJ+H1nZ8pWED58nDCB9t+e+SQfssx+wMn 50gcCtSjTJ2JKizTaIoA/zH0mSuMFoBUtayCKGns5ih9ldki128ATxmnXFV2SmRU1sA5 iu0SFTYv6zdrOMEPLXM88M+mEQrcB6pqyJbN01X6L/O+hdsN9dDbb6ec1qALe3cU8RT/ auBctVPe+/qSztoZXdv7WwDggoOkcqGsdxD62DkcQLQt/hgrNpiW2dpHJ8V8/drU6qDx DcWA== X-Gm-Message-State: AOAM531+YRqbYAJBlmY+Ri64cDpKFdaWmnIP0X7zL0j5d+kz9ngHGLt2 2Jb5ICu5evYj/hWccRih4JCD1KxqrSQbK5s3fgrq8S/wKixofw== X-Google-Smtp-Source: ABdhPJy2+Imue6RWbV97/JJ7jtw+JJKopte85kYRzj2YpHxMlEkT4HwPVvXG2QZJS8BLVh6JMaXr8qsu1XHieOsmwc8= X-Received: by 2002:aca:6089:: with SMTP id u131mr9144769oib.84.1610822082714; Sat, 16 Jan 2021 10:34:42 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bart Schaefer Date: Sat, 16 Jan 2021 10:34:31 -0800 Message-ID: Subject: Re: [PATCH v2] Make zpty module work in the cygwin and msys2 To: "zsh-workers@zsh.org" Cc: Peiyuan Song Content-Type: text/plain; charset="UTF-8" X-Seq: 47836 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: List-Subscribe: List-Unsubscribe: List-Post: List-Owner: List-Archive: Archived-At: On Thu, Jan 14, 2021 at 8:30 PM Peiyuan Song wrote: > > v2 change: make fdtable[master] I don't see anything technically wrong with this, but it does duplicate the code for check_fd_table. Anyone else have thoughts? Can someone else who compiles on cygwin give this a once-over?