From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-3.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 19441 invoked from network); 29 Nov 2023 23:45:30 -0000 Received: from zero.zsh.org (2a02:898:31:0:48:4558:7a:7368) by inbox.vuxu.org with ESMTPUTF8; 29 Nov 2023 23:45:30 -0000 ARC-Seal: i=1; cv=none; a=rsa-sha256; d=zsh.org; s=rsa-20210803; t=1701301530; b=IkasDf0GGwiQzfH87ES/j44elfb7o25fWpZTIBgksEIEAD/8R1Fp9uuNLOhK3SzIk6RKQdHTXd s9Q7lUlAQhXXQaW9vcENO+xuT4MyOtRiKXjt8auEVt6KiQyEGsMkaxH49spnokg/+quZxGfcX8 k6oLhhEGskfHkGgL8rEE/kblmw80m3959VwAFsidSEUDd8I309Jz7YiszkjyNOSiIWMoI7wQXt zeBOwF6j40lM3J5803wRvs1CzZ5phhiSupBbRi02kk1D+qfVYy29pXUpbl5Nsmk8+wx995d62y NiPrW0s4lGTAUI20SKlGZYuF0/M8TeMrGivom2CEkbusSQ==; ARC-Authentication-Results: i=1; zsh.org; iprev=pass (mail-ed1-f48.google.com) smtp.remote-ip=209.85.208.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed; d=zsh.org; s=rsa-20210803; t=1701301530; bh=ZXCNck88L679ALdjbXOYcSDtR+cqgm1MsL+Y7GtJwAM=; h=List-Archive:List-Owner:List-Post:List-Unsubscribe:List-Subscribe:List-Help: List-Id:Sender:Content-Transfer-Encoding:Content-Type:Cc:To:Subject: Message-ID:Date:From:In-Reply-To:References:MIME-Version:DKIM-Signature: DKIM-Signature; b=WLvbcvunwOny2ZzQWjk5CCHZl5AJROcMLDFA1lGmEPOccNox2Sbn6w16Z5ki+aIUD9OCQk05YL 5O+aXXmURVIBJjUMsONlLUDhMT88ue9TvLvqvhXOjOt/SEfhSflCMcgHWXo7afip16YutFK8VU ZSEcW4q3gOMsQE0GXVQ34fH0eReNPlV8crj67jZ2SE2g3O2UNzzu8f6vINaqb1DY5dd6bOHSpd a9g763H/KDHG3AE3Vy4Pc9wvwjE6jSy2pvxMrscBzsTYAl4/BvYUNVzUKaqmBBL6kqgQivFQ/u i1ySBCpyj5atTxd6RHh+9oRvZXhgDpd0t7aeetbGBIzzIQ==; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=zsh.org; s=rsa-20210803; h=List-Archive:List-Owner:List-Post:List-Unsubscribe: List-Subscribe:List-Help:List-Id:Sender:Content-Transfer-Encoding: Content-Type:Cc:To:Subject:Message-ID:Date:From:In-Reply-To:References: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID; bh=0VtfwWYpuHbZeRV2LgNwvUtA6vQ2MpzNl1owDIuJ4Is=; b=g17aBlx1MJ6uiZ0Ni7W8esbS9w n2JnjegxzVbiyXG2KPqUKryerZeeWY1hdgFr64bXRhtP0DTZVpKXSXRZtPwOcE7yMEo/wofNcelnv j88tRoacOwW3Qy2AnpvV54ni1F6NHP3exrZkOhpD7Bg5uSDMKB3cklDVgDkhBW+dxxLJIA6zDKOEg tYAUFzhdEIqfLft2zMMW2dFXiLyD2VXXM2Yv4cOpj5P1XRodC9+8u56TXrryGP63z1FlHYuAxPvCs sJ+H7DY7DK36+Foal4RiNskYADZiTl2gmZF+V0aW7fr0qXCVFQth/ATUR/UJN+UMYNIo9iKHCAnBW xvox6viw==; Received: by zero.zsh.org with local id 1r8UFE-000KSW-GP; Wed, 29 Nov 2023 23:45:28 +0000 Authentication-Results: zsh.org; iprev=pass (mail-ed1-f48.google.com) smtp.remote-ip=209.85.208.48; dkim=pass header.d=brasslantern-com.20230601.gappssmtp.com header.s=20230601 header.a=rsa-sha256; dmarc=none header.from=brasslantern.com; arc=none Received: from mail-ed1-f48.google.com ([209.85.208.48]:60686) by zero.zsh.org with esmtps (TLS1.3:TLS_AES_128_GCM_SHA256:128) id 1r8UEu-000KD8-7J; Wed, 29 Nov 2023 23:45:09 +0000 Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-548f0b7ab11so178921a12.1 for ; Wed, 29 Nov 2023 15:45:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20230601.gappssmtp.com; s=20230601; t=1701301507; x=1701906307; darn=zsh.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0VtfwWYpuHbZeRV2LgNwvUtA6vQ2MpzNl1owDIuJ4Is=; b=btm4jTqfUjpvz+XX0CBIAdVJvMrw45HhIV928nYYY5uObDyg3OcY1TlGHSKricKwoq kMdk9sshTY8KpiqEu/1kuFKA+NjbeTy42EMG+FKshJRPdsDsoVjeGWgPRw7QUb2ujt1T 59F4XbbmQnUN/ENTlFBBY6WPUaToKd0ccE9kqoL+DYivhZKynhro6wv84iLMHxn9JSxk 6LclD7EFFmr1b2e1zyKMBvmnRVi6fWK0QtUY6uFLBi6lzKUJ2OrSPr4I/TkpYlBG0yqW q5gcsCfjJftVycKYWhuIb4Nkw1vJDQsenEGtMABX3PqxvVCtka6OS3bSplb+iFhNimwj /1Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701301507; x=1701906307; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0VtfwWYpuHbZeRV2LgNwvUtA6vQ2MpzNl1owDIuJ4Is=; b=TKf8/l1IdkeuLLK2HwQbazAdx1tVnqAjRWi0rPqzafRd6u6ueE2gfBSweERnYMUQNi dlxDfhtH8LtafSQ5QFiAitCiil7UaVmzT3OkZEa6kOFOt1ijhJY75+/DggC2TYJfJHRr PP7el19E7LUhDWvCAcXAJUP7a5eXXuuFOiryRP5UUVWIyYeS/4ojBszqJcTKy4IkDbsa QFrN/t4WVxEEzwgiwfft6BYFYoAeopOHA1zQyLKDWcTQdRq/YRdZ9Pm1m6UYU3NPovs2 R/CjJdCEwXK5EFaaD+UdJ3p/gLgEfUNzq/rJyQ7m0sn4yhmZZLUdZ7xcyXtUxXU23roy wjwQ== X-Gm-Message-State: AOJu0Ywq9W+laTBhSkvlmby4KHl3glA/MnZgjqB4XzkhKbEsBlaceCpo C8kasE/l14Go9mTDrZ5aiJuUb8aC1uNidsyoJt1OcA== X-Google-Smtp-Source: AGHT+IHFcE0OXX9Pew2t5bkl7IzOBDSl11YCYhDL+cBjv8pfh8WTAEZtbzTaj7obtrjhhISnZH3rIdE0f7Etrfa7KYY= X-Received: by 2002:a17:906:1051:b0:a18:612e:19e9 with SMTP id j17-20020a170906105100b00a18612e19e9mr289500ejj.8.1701301507598; Wed, 29 Nov 2023 15:45:07 -0800 (PST) MIME-Version: 1.0 References: <207461559.9336309.1701221332233.ref@mail.yahoo.com> <207461559.9336309.1701221332233@mail.yahoo.com> In-Reply-To: From: Bart Schaefer Date: Wed, 29 Nov 2023 15:44:56 -0800 Message-ID: Subject: Re: PATCH: Improve quote handling in _ant completion To: Mikael Magnusson Cc: German Riano , "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Seq: 52338 Archived-At: X-Loop: zsh-workers@zsh.org Errors-To: zsh-workers-owner@zsh.org Precedence: list Precedence: bulk Sender: zsh-workers-request@zsh.org X-no-archive: yes List-Id: List-Help: , List-Subscribe: , List-Unsubscribe: , List-Post: List-Owner: List-Archive: On Wed, Nov 29, 2023 at 11:56=E2=80=AFAM Mikael Magnusson wrote: > > On 11/29/23, Bart Schaefer wrote: > > - print -n "'${default_target}:(Default target) ' " > > + print -rn -- "${(qq):-${default_target}:(Default t= arget) } " A similar change needs to be applied a bit later, I think: (*) # Return target and description - print -n "'$ln' " + print -rn -- "${(qq):-$ln} " ;; If this seems OK I'll prepare a proper patch. > >> Also I am proposing to shield 'find_targets' with '(( > >> $#functions[find_targets] )) ||' so that users can easily override the > >> function. > > It should probably also be renamed to _ant_find_targets or something Agreed.