From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13780 invoked by alias); 28 Aug 2017 06:45:29 -0000 Mailing-List: contact zsh-workers-help@zsh.org; run by ezmlm Precedence: bulk X-No-Archive: yes List-Id: Zsh Workers List List-Post: List-Help: X-Seq: 41613 Received: (qmail 15510 invoked by uid 1010); 28 Aug 2017 06:45:29 -0000 X-Qmail-Scanner-Diagnostics: from mail-qt0-f176.google.com by f.primenet.com.au (envelope-from , uid 7791) with qmail-scanner-2.11 (clamdscan: 0.99.2/21882. spamassassin: 3.4.1. Clear:RC:0(209.85.216.176):SA:0(-1.4/5.0):. Processed in 2.698923 secs); 28 Aug 2017 06:45:29 -0000 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on f.primenet.com.au X-Spam-Level: X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_SPAM,SPF_PASS, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.1 X-Envelope-From: schaefer@brasslantern.com X-Qmail-Scanner-Mime-Attachments: | X-Qmail-Scanner-Zip-Files: | DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasslantern-com.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yQ7Reeyxe2QvUFc3lrsSRlRCxudOQB0nFdVN9JQhUm0=; b=B/m2+OxXIbC/dY1FWiZsQS+X8q/irMOlrIiBhOoRSsZ1mTYvVu0PPip9ZjGYqE77Aa cix/npToUP8UPMfclca+zb0AfH+Eys9gHmhWSWbQZPhgyTOwuFLsi+8OgY+kX6RHmiNK ercWMVm2KclrTVLPKZUYbdF+Avz6H1rXpXcjdH6TWttb2edXOPo1skeRl8cg4eFwl5+c zLThQBNmStyATn/T6sRgOm9u1k394uzAzOqZlgY6coa19fLeNS+Rb0/sKhP79q/A/oqC +PvuxrbV/hIYqanSADqlBV4I4Y/RQHETkshSb47B38idSPhs+g4eOEy/O+wmP/waE+R5 p6vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yQ7Reeyxe2QvUFc3lrsSRlRCxudOQB0nFdVN9JQhUm0=; b=t3sx4VGkNSr9QtqaBSpZpKXOnM0/Os3xn4USJwy39jmphRp2k+i7QM+/gkd0YCKKqz cRqjsKmFlCbDicVfRTJ7GbJWvhlXC3mHd9gSk98/Tds2dhiyRHpO8Se464AhVrDc79Li J0hsLiZAz5B3B9t9Tk6xF0yQwXehb0GNzf0h6r7u8/MouLjZelrNExXaIYIHXJiVQa1C Nm02CyIycb/D3iQlFlgsG3kBzhK0NUnzpwjMdJ3JFineV0nKgdPjq5fjsW46MfuOhdJp RLx/yuyewsKw8Ciub/kyB/oJQ4uhou6W7oMz2TZvlffl9XMX0iro6O37l5EioIpuvYnt jmUg== X-Gm-Message-State: AHYfb5hdvquXcz4LYms4EOuc9hXW+PEobKNVly9Qvvo6M7BebloS1S1W cXYj7tlMhM8J3H33VIcEySx8LKdSh0L6PH0= X-Received: by 10.237.52.38 with SMTP id w35mr7879296qtd.322.1503902721637; Sun, 27 Aug 2017 23:45:21 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1503883531.3929330.1086829200.165C21BC@webmail.messagingengine.com> References: <20170827005040.GA12622@zira.vinc17.org> <20170827195648.6f078249@ntlworld.com> <20170827222618.GA3398@zira.vinc17.org> <1503883531.3929330.1086829200.165C21BC@webmail.messagingengine.com> From: Bart Schaefer Date: Sun, 27 Aug 2017 23:45:20 -0700 Message-ID: Subject: Re: "set -e" handling is broken with zsh 5.3.1 and 5.4.1 To: Daniel Shahaf Cc: "zsh-workers@zsh.org" Content-Type: text/plain; charset="UTF-8" On Sun, Aug 27, 2017 at 6:25 PM, Daniel Shahaf wrote: > Vincent Lefevre wrote on Mon, 28 Aug 2017 00:26 +0200: >> Perhaps it was needed in the past, and no longer makes sense now. >> Have you looked at the diff that introduced it, > > It's this one: > > commit d6a32ddeed914434f5b56b013c9d03b28781d065 > Author: Barton E. Schaefer > Date: Sat Dec 27 21:55:58 2014 -0800 > > 34065: following an "if" condition, do not test lastval for ERR_EXIT until a new command is run Background is in workers/34055 and 34059, and this looks to have something to do with noerrexit not propagating into the first sublist in a function body. It's entirely possible that the change from having a few numeric values for the flags to have a set of bit values has made that test unnecessary, or it may be needed in case that hasn't been tested yet -- the original report in 34055 involves calling a function within an if/else block.